Skip to content

Commit eb81564

Browse files
johnniwintherCommit Queue
authored andcommitted
[cfe] Remove use of 'fasta' in (file)names
Change-Id: Iac3850696fb5e48dff847d17f7110644e8b8bd03 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395920 Reviewed-by: Jens Johansen <[email protected]> Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Slava Egorov <[email protected]>
1 parent 9c59339 commit eb81564

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+408
-421
lines changed

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// NOTE: THIS FILE IS GENERATED. DO NOT EDIT.
66
//
77
// Instead modify 'tools/experimental_features.yaml' and run
8-
// 'dart pkg/front_end/tool/fasta.dart generate-experimental-flags' to update.
8+
// 'dart pkg/front_end/tool/cfe.dart generate-experimental-flags' to update.
99
const Version defaultLanguageVersion = const Version(3, 7);
1010

1111
/// Enum for experimental flags shared between the CFE and the analyzer.

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// NOTE: THIS FILE IS GENERATED. DO NOT EDIT.
66
//
77
// Instead modify 'pkg/front_end/messages.yaml' and run
8-
// 'pkg/front_end/tool/fasta generate-messages' to update.
8+
// 'pkg/front_end/tool/cfe generate-messages' to update.
99

1010
// ignore_for_file: lines_longer_than_80_chars
1111

pkg/_fe_analyzer_shared/lib/src/parser/listener.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ class Listener implements UnescapeErrorListener {
314314
void beginCompilationUnit(Token token) {}
315315

316316
/// This method exists for analyzer compatibility only
317-
/// and will be removed once analyzer/fasta integration is complete.
317+
/// and will be removed once analyzer/cfe integration is complete.
318318
///
319319
/// This is called when [Parser.parseDirectives] has parsed all directives
320320
/// and is skipping the remainder of the file. Substructures:

pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ class Parser {
435435
}
436436

437437
/// This method exists for analyzer compatibility only
438-
/// and will be removed once analyzer/fasta integration is complete.
438+
/// and will be removed once analyzer/cfe integration is complete.
439439
///
440440
/// Similar to [parseUnit], this method parses a compilation unit,
441441
/// but stops when it reaches the first declaration or EOF.

pkg/_fe_analyzer_shared/lib/src/scanner/errors.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ void translateErrorToken(ErrorToken token, ReportError reportError) {
2121
// Analyzer never generates an error message past the end of the input,
2222
// since such an error would not be visible in an editor.
2323
// TODO(paulberry,ahe): would it make sense to replicate this behavior
24-
// in fasta, or move it elsewhere in analyzer?
24+
// in cfe, or move it elsewhere in analyzer?
2525
charOffset--;
2626
}
2727
reportError(errorCode, charOffset, arguments);

pkg/_fe_analyzer_shared/lib/src/scanner/scanner_main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ void printTokens(Token token) {
3232
}
3333
}
3434

35-
/// Verify that the fasta scanner recovery has moved all of the ErrorTokens
35+
/// Verify that the scanner recovery has moved all of the ErrorTokens
3636
/// to the beginning of the stream. If an out-of-order ErrorToken is
3737
/// found, then print some diagnostic information and throw an exception.
3838
void verifyErrorTokens(Token firstToken, Uri uri) {

pkg/_fe_analyzer_shared/lib/src/scanner/token.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1299,7 +1299,7 @@ class TokenType {
12991299
isOperator: true,
13001300
isBinaryOperator: true);
13011301

1302-
// This is not yet part of the language and not supported by fasta
1302+
// This is not yet part of the language and not supported by the scanner.
13031303
static const TokenType AMPERSAND_AMPERSAND_EQ = const TokenType(
13041304
/* index = */ 14,
13051305
'&&=',
@@ -1336,7 +1336,7 @@ class TokenType {
13361336
/* index = */ 21, '||', 'BAR_BAR', LOGICAL_OR_PRECEDENCE, BAR_BAR_TOKEN,
13371337
isOperator: true, isBinaryOperator: true);
13381338

1339-
// This is not yet part of the language and not supported by fasta
1339+
// This is not yet part of the language and not supported by the scanner.
13401340
static const TokenType BAR_BAR_EQ = const TokenType(/* index = */ 22, '||=',
13411341
'BAR_BAR_EQ', ASSIGNMENT_PRECEDENCE, BAR_BAR_EQ_TOKEN,
13421342
binaryOperatorOfCompoundAssignment: TokenType.BAR_BAR, isOperator: true);
@@ -1686,11 +1686,11 @@ class TokenType {
16861686
//TokenType.IS,
16871687
//TokenType.AS,
16881688

1689-
// These are not yet part of the language and not supported by fasta
1689+
// These are not yet part of the language and not supported by the scanner:
16901690
//TokenType.AMPERSAND_AMPERSAND_EQ,
16911691
//TokenType.BAR_BAR_EQ,
16921692

1693-
// Supported by fasta but not part of the language
1693+
// Supported by the scanner but not part of the language
16941694
//TokenType.BANG_EQ_EQ,
16951695
//TokenType.EQ_EQ_EQ,
16961696

pkg/analyzer/doc/implementation/experiment_flags.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ To generate the declarations used by the analyzer, run
1616
`dart pkg/analyzer/tool/experiments/generate.dart`.
1717

1818
To generate the declarations used by the front-end, run
19-
`dart pkg/front_end/tool/fasta.dart generate-experimental-flags`.
19+
`dart pkg/front_end/tool/cfe.dart generate-experimental-flags`.
2020

2121
## Summary representation
2222

pkg/compiler/README.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,9 @@ functionality is publicly exposed.
266266

267267
* `lib/src/source_file_provider.dart`: _TODO: add details_.
268268

269-
* Parsing: most of the parsing logic is now in the `front_end` package,
270-
currently under `pkg/front_end/lib/src/fasta/scanner` and
271-
`pkg/front_end/lib/src/fasta/parser`. The `front_end` parser is AST agnostic
269+
* Parsing: most of the parsing logic is now in the `fe_analyzer_shared` package,
270+
currently under `pkg/_fe_analyzer_shared/lib/src/scanner` and
271+
`pkg/fe_analyzer_shared/lib/src/parser`. The `front_end` parser is AST agnostic
272272
and uses listeners to create on the side what they want as the result of
273273
parsing. The logic to create dart2js' ASTs is defined in listeners within the
274274
compiler package:
@@ -362,12 +362,6 @@ functionality is publicly exposed.
362362

363363
* `tool`: some helper scripts, some of these could be deleted
364364

365-
* `tool/perf.dart`: used by our benchmark runners to measure performance of
366-
some frontend pieces of dart2js. We should be able to delete it in the near
367-
future once the front end code is moved into `fasta`.
368-
369-
* `tool/perf_test.dart`: small test to ensure we don't break `perf.dart`.
370-
371365
* `tool/track_memory.dart`: a helper script to see memory usage of dart2js
372366
while it's running. Used in the past to profile the global analysis phases
373367
when run on very large apps.

pkg/compiler/lib/src/diagnostics/messages.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
/// The messages in this file should follow the [Guide for Writing
6-
/// Diagnostics](../../../../front_end/lib/src/fasta/diagnostics.md).
6+
/// Diagnostics](../../../../front_end/lib/src/base/diagnostics.md).
77
///
88
/// Other things to keep in mind:
99
///

0 commit comments

Comments
 (0)