Skip to content

Commit ecfce50

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[infra] Remove IA32 from dartfuzz, GCC and MSVC testing.
Bug: #49969 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-msvc-windows-try Change-Id: Idf24c48fee5fc5bb757b49bd8941573822496090 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429223 Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Alexander Markov <[email protected]>
1 parent 6859abe commit ecfce50

File tree

3 files changed

+3
-38
lines changed

3 files changed

+3
-38
lines changed

runtime/tools/dartfuzz/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ where
5959
--dart-top : sets DART_TOP explicitly through command line
6060
--mode1 : m1
6161
--mode2 : m2, and values one of
62-
jit-[debug-][ia32|x64|arm32|arm64] = Dart JIT
62+
jit-[debug-][x64|arm32|arm64] = Dart JIT
6363
aot-[debug-][x64|arm32|arm64] = Dart AOT
6464
djs-x64 = dart2js + Node.JS
6565
--[no-]rerun : re-run a testcase if there is only a divergence in
@@ -71,8 +71,8 @@ If no modes are given, a random combination is used.
7171

7272
This fuzz testing tool must have access to the top of a Dart SDK
7373
development tree (DART_TOP) in which all proper binaries have been
74-
built already (for example, testing jit-ia32 will invoke the binary
75-
${DART_TOP}/out/ReleaseIA32/dart to start the Dart VM). The DART_TOP
74+
built already (for example, testing jit-x64 will invoke the binary
75+
${DART_TOP}/out/ReleaseX64/dart to start the Dart VM). The DART_TOP
7676
can be provided through the --dart-top option, as an environment
7777
variable, or, by default, as the current directory by invoking the
7878
fuzz testing tool from the Dart SDK top.

runtime/tools/dartfuzz/dartfuzz_test.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,15 +122,13 @@ abstract class TestRunner {
122122

123123
// Convert mode to tag.
124124
static String getTag(String mode) {
125-
if (mode.endsWith('debug-ia32')) return 'DebugIA32';
126125
if (mode.endsWith('debug-x64')) return 'DebugX64';
127126
if (mode.endsWith('debug-x64c')) return 'DebugX64C';
128127
if (mode.endsWith('debug-arm32')) return 'DebugSIMARM';
129128
if (mode.endsWith('debug-arm64')) return 'DebugSIMARM64';
130129
if (mode.endsWith('debug-arm64c')) return 'DebugSIMARM64C';
131130
if (mode.endsWith('debug-riscv32')) return 'DebugSIMRISCV32';
132131
if (mode.endsWith('debug-riscv64')) return 'DebugSIMRISCV64';
133-
if (mode.endsWith('ia32')) return 'ReleaseIA32';
134132
if (mode.endsWith('x64')) return 'ReleaseX64';
135133
if (mode.endsWith('x64c')) return 'ReleaseX64C';
136134
if (mode.endsWith('arm32')) return 'ReleaseSIMARM';
@@ -745,15 +743,13 @@ class DartFuzzTestSession {
745743

746744
// Modes used on cluster runs.
747745
static const List<String> clusterModes = [
748-
'jit-debug-ia32',
749746
'jit-debug-x64',
750747
'jit-debug-x64c',
751748
'jit-debug-arm32',
752749
'jit-debug-arm64',
753750
'jit-debug-arm64c',
754751
'jit-debug-riscv32',
755752
'jit-debug-riscv64',
756-
'jit-ia32',
757753
'jit-x64',
758754
'jit-x64c',
759755
'jit-arm32',

tools/bots/test_matrix.json

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
],
8888
"front-end": [
8989
".dart_tool/package_config.json",
90-
"out/ReleaseIA32/",
9190
"out/ReleaseX64/",
9291
"pkg/",
9392
"runtime/tests/",
@@ -114,7 +113,6 @@
114113
"third_party/pkg/",
115114
"third_party/requirejs/",
116115
"tools/",
117-
"xcodebuild/ReleaseIA32/",
118116
"xcodebuild/ReleaseX64/"
119117
],
120118
"fuzzer": [
@@ -1478,16 +1476,6 @@
14781476
"description": "This configuration builds the VM with GCC."
14791477
},
14801478
"steps": [
1481-
{
1482-
"name": "build dart debug ia32",
1483-
"script": "tools/build.py",
1484-
"arguments": [
1485-
"--mode=debug",
1486-
"--arch=ia32",
1487-
"--no-clang",
1488-
"runtime"
1489-
]
1490-
},
14911479
{
14921480
"name": "build dart debug x64",
14931481
"script": "tools/build.py",
@@ -1521,16 +1509,6 @@
15211509
"runtime_precompiled"
15221510
]
15231511
},
1524-
{
1525-
"name": "build dart release ia32",
1526-
"script": "tools/build.py",
1527-
"arguments": [
1528-
"--mode=release",
1529-
"--arch=ia32",
1530-
"--no-clang",
1531-
"runtime"
1532-
]
1533-
},
15341512
{
15351513
"name": "build dart release x64",
15361514
"script": "tools/build.py",
@@ -3516,15 +3494,6 @@
35163494
"dartaotruntime"
35173495
]
35183496
},
3519-
{
3520-
"name": "build dart (ia32)",
3521-
"script": "tools/build.py",
3522-
"arguments": [
3523-
"--mode=debug,release",
3524-
"--arch=ia32",
3525-
"runtime"
3526-
]
3527-
},
35283497
{
35293498
"name": "build dart (arm)",
35303499
"script": "tools/build.py",

0 commit comments

Comments
 (0)