[vm/runtime] Call tzset() before localtime_r().

Closes #61302

GitOrigin-RevId: 5d29733
Change-Id: I74be3fa338aeab0e83d571877f42ac9f80dc89de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444983
Commit-Queue: Slava Egorov <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>

Author: JesseRiemens

runtime/vm/os_android.cc

@@ -102,6 +102,9 @@ intptr_t OS::ProcessId() {
 static bool LocalTime(int64_t seconds_since_epoch, tm* tm_result) {
   time_t seconds = static_cast<time_t>(seconds_since_epoch);
   if (seconds != seconds_since_epoch) return false;
+  // No need to call tzset() before localtime_r() because bionic
+  // will handle timezone changes for us (starting from Android O).
+  // See https://android.googlesource.com/platform/bionic/+/ea87716696bf635706b6f3fa56b8a145add83aff
   struct tm* error_code = localtime_r(&seconds, tm_result);
   return error_code != nullptr;
 }

runtime/vm/os_linux.cc

@@ -418,6 +418,7 @@ intptr_t OS::ProcessId() {
 static bool LocalTime(int64_t seconds_since_epoch, tm* tm_result) {
   time_t seconds = static_cast<time_t>(seconds_since_epoch);
   if (seconds != seconds_since_epoch) return false;
+  tzset();  // Not guaranteed by POSIX to be called by `localtime_r`.
   struct tm* error_code = localtime_r(&seconds, tm_result);
   return error_code != nullptr;
 }