[analyzer] Dot Shorthands: Add support for FutureOr.

Finds the namespace of `S` for a context type of `FutureOr<S>` and uses that to resolve the shorthand.

Unit tests written and language tests cover this behavior.

Bug: #59835
Change-Id: Iec7bfeaef2c0ab20ee2031c4dc0b3ef0b9e1fc66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422363
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart

@@ -209,7 +209,13 @@ class MethodInvocationResolver with ScopeHelpers {
       List<WhyNotPromotedGetter> whyNotPromotedArguments) {
     _invocation = node;
 
-    var contextType = _resolver.getDotShorthandContext().unwrapTypeSchemaView();
+    TypeImpl contextType =
+        _resolver.getDotShorthandContext().unwrapTypeSchemaView();
+
+    // The static namespace denoted by `S` is also the namespace denoted by
+    // `FutureOr<S>`.
+    contextType = _resolver.typeSystem.futureOrBase(contextType);
+
     // TODO(kallentu): Dot shorthands work - Support other context types
     if (contextType is InterfaceTypeImpl) {
       var contextElement = contextType.element3;

pkg/analyzer/lib/src/dart/resolver/property_element_resolver.dart

@@ -47,6 +47,11 @@ class PropertyElementResolver with ScopeHelpers {
     }
     TypeImpl context =
         _resolver.getDotShorthandContext().unwrapTypeSchemaView();
+
+    // The static namespace denoted by `S` is also the namespace denoted by
+    // `FutureOr<S>`.
+    context = _resolver.typeSystem.futureOrBase(context);
+
     // TODO(kallentu): Support other context types
     if (context is InterfaceTypeImpl) {
       var identifier = node.propertyName;

pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart

@@ -16,7 +16,7 @@ main() {
 
 @reflectiveTest
 class DotShorthandInvocationResolutionTest extends PubPackageResolutionTest {
-  test_dotShorthand_basic() async {
+  test_basic() async {
     await assertNoErrorsInCode(r'''
 class C {
   static C member() => C(1);
@@ -46,7 +46,7 @@ DotShorthandInvocation
 ''');
   }
 
-  test_dotShorthand_basic_generic() async {
+  test_basic_generic() async {
     await assertNoErrorsInCode(r'''
 class C<T> {
   static C member<U>(U x) => C(x);
@@ -93,7 +93,7 @@ DotShorthandInvocation
 ''');
   }
 
-  test_dotShorthand_basic_parameter() async {
+  test_basic_parameter() async {
     await assertNoErrorsInCode(r'''
 class C {
   static C member(int x) => C(x);
@@ -125,6 +125,70 @@ DotShorthandInvocation
     rightParenthesis: )
   staticInvokeType: C Function(int)
   staticType: C
+''');
+  }
+
+  test_futureOr() async {
+    await assertNoErrorsInCode(r'''
+import 'dart:async';
+
+class C {
+  static C member() => C(1);
+  int x;
+  C(this.x);
+}
+
+void main() {
+  FutureOr<C> c = .member();
+  print(c);
+}
+''');
+
+    var node = findNode.singleDotShorthandInvocation;
+    assertResolvedNodeText(node, r'''
+DotShorthandInvocation
+  period: .
+  memberName: SimpleIdentifier
+    token: member
+    element: <testLibraryFragment>::@class::C::@method::member#element
+    staticType: C Function()
+  argumentList: ArgumentList
+    leftParenthesis: (
+    rightParenthesis: )
+  staticInvokeType: C Function()
+  staticType: C
+''');
+  }
+
+  test_futureOr_nested() async {
+    await assertNoErrorsInCode(r'''
+import 'dart:async';
+
+class C {
+  static C member() => C(1);
+  int x;
+  C(this.x);
+}
+
+void main() {
+  FutureOr<FutureOr<C>> c = .member();
+  print(c);
+}
+''');
+
+    var node = findNode.singleDotShorthandInvocation;
+    assertResolvedNodeText(node, r'''
+DotShorthandInvocation
+  period: .
+  memberName: SimpleIdentifier
+    token: member
+    element: <testLibraryFragment>::@class::C::@method::member#element
+    staticType: C Function()
+  argumentList: ArgumentList
+    leftParenthesis: (
+    rightParenthesis: )
+  staticInvokeType: C Function()
+  staticType: C
 ''');
   }
 }

pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart

@@ -65,6 +65,54 @@ DotShorthandPropertyAccess
 ''');
   }
 
+  test_futureOr() async {
+    await assertNoErrorsInCode('''
+import 'dart:async';
+
+enum C { red }
+
+void main() {
+  FutureOr<C> c = .red;
+  print(c);
+}
+''');
+
+    var identifier = findNode.singleDotShorthandPropertyAccess;
+    assertResolvedNodeText(identifier, r'''
+DotShorthandPropertyAccess
+  period: .
+  propertyName: SimpleIdentifier
+    token: red
+    element: <testLibraryFragment>::@enum::C::@getter::red#element
+    staticType: C
+  staticType: C
+''');
+  }
+
+  test_futureOr_nested() async {
+    await assertNoErrorsInCode('''
+import 'dart:async';
+
+enum C { red }
+
+void main() {
+  FutureOr<FutureOr<C>> c = .red;
+  print(c);
+}
+''');
+
+    var identifier = findNode.singleDotShorthandPropertyAccess;
+    assertResolvedNodeText(identifier, r'''
+DotShorthandPropertyAccess
+  period: .
+  propertyName: SimpleIdentifier
+    token: red
+    element: <testLibraryFragment>::@enum::C::@getter::red#element
+    staticType: C
+  staticType: C
+''');
+  }
+
   test_object_new() async {
     await assertNoErrorsInCode('''
 void main() {