[analyzer] Return only relevant errors in sortDirectives.

Trying 3.7.0 I hit a case where this would succeed but return an error
"Doc directive 'code' is unknown." Per the doc comment it looks like
the error should not be returned.

[email protected]

Change-Id: Id2d65adcf4ce59caa16040fcce9457b2c7f244a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391740
Auto-Submit: Morgan :) <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: davidmorgan

pkg/analysis_server/lib/src/g3/utilities.dart

@@ -34,15 +34,15 @@ String format(String content, {Version? languageVersion}) {
 /// cause of the failure, a list of [AnalysisError]'s.
 ParseStringResult sortDirectives(String contents, {String? fileName}) {
   var (unit, errors) = _parse(contents, fullName: fileName);
-  var hasParseErrors = errors.any((error) =>
+  var parseErrors = errors.where((error) =>
       error.errorCode is ScannerErrorCode ||
-      error.errorCode is ParserErrorCode);
-  if (hasParseErrors) {
-    return ParseStringResultImpl(contents, unit, errors);
+      error.errorCode is ParserErrorCode).toList();
+  if (parseErrors.isNotEmpty) {
+    return ParseStringResultImpl(contents, unit, parseErrors);
   }
-  var sorter = ImportOrganizer(contents, unit, errors);
+  var sorter = ImportOrganizer(contents, unit, parseErrors);
   sorter.organize();
-  return ParseStringResultImpl(sorter.code, unit, errors);
+  return ParseStringResultImpl(sorter.code, unit, parseErrors);
 }
 
 (CompilationUnit, List<AnalysisError>) _parse(String contents,