Skip to content

Commit f11466b

Browse files
srawlinsCommit Queue
authored andcommitted
linter: Remove infra for removed integration-style tests
Change-Id: I0e8d4db0914fb72d451f7fbea389e0bf8cd36886 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399625 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent 5412f2c commit f11466b

24 files changed

+302
-1085
lines changed

pkg/analyzer/lib/src/lint/io.dart

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -13,42 +13,9 @@ StringSink errorSink = stderr;
1313
/// A shared sink for standard out reporting.
1414
StringSink outSink = stdout;
1515

16-
/// Collect all lintable files, recursively, under this [path] root, ignoring
17-
/// links.
18-
Iterable<File> collectFiles(String path) {
19-
List<File> files = [];
20-
21-
var file = File(path);
22-
if (file.existsSync()) {
23-
files.add(file);
24-
} else {
25-
var directory = Directory(path);
26-
if (directory.existsSync()) {
27-
for (var entry
28-
in directory.listSync(recursive: true, followLinks: false)) {
29-
var relative = p.relative(entry.path, from: directory.path);
30-
31-
if (isLintable(entry) && !isInHiddenDir(relative)) {
32-
files.add(entry as File);
33-
}
34-
}
35-
}
36-
}
37-
38-
return files;
39-
}
40-
4116
/// Returns `true` if this [entry] is a Dart file.
4217
bool isDartFile(FileSystemEntity entry) => isDartFileName(entry.path);
4318

44-
/// Returns `true` if this relative path is a hidden directory.
45-
bool isInHiddenDir(String relative) =>
46-
p.split(relative).any((part) => part.startsWith("."));
47-
48-
/// Returns `true` if this relative path is a hidden directory.
49-
bool isLintable(FileSystemEntity file) =>
50-
file is File && (isDartFile(file) || isPubspecFile(file));
51-
5219
/// Returns `true` if this [entry] is a pubspec file.
5320
bool isPubspecFile(FileSystemEntity entry) =>
5421
isPubspecFileName(p.basename(entry.path));

pkg/analyzer/test/src/lint/io_test.dart

Lines changed: 0 additions & 89 deletions
This file was deleted.

pkg/analyzer/test/src/lint/test_all.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,13 @@
55
import 'package:test_reflective_loader/test_reflective_loader.dart';
66

77
import 'config_test.dart' as config;
8-
import 'io_test.dart' as io;
98
import 'lint_rule_test.dart' as lint_rule;
109
import 'linter/test_all.dart' as linter;
1110
import 'pub_test.dart' as pub;
1211

1312
main() {
1413
defineReflectiveSuite(() {
1514
config.main();
16-
io.main();
1715
lint_rule.main();
1816
linter.main();
1917
pub.main();

pkg/linter/lib/src/test_utilities/analyzer_utils.dart

Lines changed: 0 additions & 5 deletions
This file was deleted.

pkg/linter/lib/src/test_utilities/annotation.dart

Lines changed: 0 additions & 65 deletions
This file was deleted.

0 commit comments

Comments
 (0)