[dart2js] Remove unused Map/Set literal helper functions

These functions have not been used since we switched to the new Rti.

In modern Dart it is not worth special-casing `<dynamic,dynamic>{}` and
`<dynamic>{}`.

Bug: #37715
Change-Id: I535bc67055a7dc02016b14d1a0ae43ca1f850e79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430320
Commit-Queue: Stephen Adams <[email protected]>
Reviewed-by: Mayank Patke <[email protected]>

Author: rakudrama

pkg/compiler/lib/src/common/elements.dart

@@ -483,18 +483,6 @@ abstract class CommonElements {
   )!;
   late final ConstructorEntity mapLiteralConstructorEmpty = _env
       .lookupConstructor(mapLiteralClass, '_empty')!;
-  late final FunctionEntity mapLiteralUntypedMaker =
-      _env.lookupLocalClassMember(
-            mapLiteralClass,
-            PrivateName('_makeLiteral', mapLiteralClass.library.canonicalUri),
-          )
-          as FunctionEntity;
-  late final FunctionEntity mapLiteralUntypedEmptyMaker =
-      _env.lookupLocalClassMember(
-            mapLiteralClass,
-            PrivateName('_makeEmpty', mapLiteralClass.library.canonicalUri),
-          )
-          as FunctionEntity;
 
   late final ClassEntity setLiteralClass = _findClass(
     collectionLibrary,
@@ -507,18 +495,6 @@ abstract class CommonElements {
   )!;
   late final ConstructorEntity setLiteralConstructorEmpty = _env
       .lookupConstructor(setLiteralClass, '_empty')!;
-  late final FunctionEntity setLiteralUntypedMaker =
-      _env.lookupLocalClassMember(
-            setLiteralClass,
-            PrivateName('_makeLiteral', setLiteralClass.library.canonicalUri),
-          )
-          as FunctionEntity;
-  late final FunctionEntity setLiteralUntypedEmptyMaker =
-      _env.lookupLocalClassMember(
-            setLiteralClass,
-            PrivateName('_makeEmpty', setLiteralClass.library.canonicalUri),
-          )
-          as FunctionEntity;
 
   late final FunctionEntity? objectNoSuchMethod =
       _env.lookupLocalClassMember(

pkg/compiler/lib/src/js_backend/backend_impact.dart

@@ -445,17 +445,13 @@ class BackendImpacts {
     globalUses: [
       _commonElements.mapLiteralConstructor,
       _commonElements.mapLiteralConstructorEmpty,
-      _commonElements.mapLiteralUntypedMaker,
-      _commonElements.mapLiteralUntypedEmptyMaker,
     ],
   );
 
   late final BackendImpact setLiteralClass = BackendImpact(
     globalUses: [
       _commonElements.setLiteralConstructor,
       _commonElements.setLiteralConstructorEmpty,
-      _commonElements.setLiteralUntypedMaker,
-      _commonElements.setLiteralUntypedEmptyMaker,
     ],
   );
 

pkg/compiler/lib/src/ssa/builder.dart

@@ -4153,21 +4153,7 @@ class KernelSsaGraphBuilder extends ir.VisitorDefault<void>
           _typeBuilder.analyzeTypeArgument(argument, sourceElement),
         );
       }
-
-      // We lift this common call pattern into a helper function to save space
-      // in the output.
-      if (typeInputs.every(
-        (HInstruction input) =>
-            input.isNull(_abstractValueDomain).isDefinitelyTrue,
-      )) {
-        if (elements.isEmpty) {
-          constructor = _commonElements.setLiteralUntypedEmptyMaker;
-        } else {
-          constructor = _commonElements.setLiteralUntypedMaker;
-        }
-      } else {
-        inputs.addAll(typeInputs);
-      }
+      inputs.addAll(typeInputs);
     }
 
     // If runtime type information is needed and the set literal has no type
@@ -4256,21 +4242,7 @@ class KernelSsaGraphBuilder extends ir.VisitorDefault<void>
           _typeBuilder.analyzeTypeArgument(argument, sourceElement),
         );
       }
-
-      // We lift this common call pattern into a helper function to save space
-      // in the output.
-      if (typeInputs.every(
-        (HInstruction input) =>
-            input.isNull(_abstractValueDomain).isDefinitelyTrue,
-      )) {
-        if (constructorArgs.isEmpty) {
-          constructor = _commonElements.mapLiteralUntypedEmptyMaker;
-        } else {
-          constructor = _commonElements.mapLiteralUntypedMaker;
-        }
-      } else {
-        inputs.addAll(typeInputs);
-      }
+      inputs.addAll(typeInputs);
     }
 
     // If runtime type information is needed and the map literal has no type

sdk/lib/_internal/js_runtime/lib/collection_patch.dart

@@ -551,19 +551,6 @@ class LinkedHashMap<K, V> {
   factory LinkedHashMap._empty() {
     return JsLinkedHashMap<K, V>();
   }
-
-  // Private factory static function called by generated code for map literals.
-  // This version is for map literals without type parameters.
-  @pragma('dart2js:noThrows')
-  @pragma('dart2js:noInline')
-  @pragma('dart2js:noSideEffects')
-  static _makeEmpty() => JsLinkedHashMap();
-
-  // Private factory static function called by generated code for map literals.
-  // This version is for map literals without type parameters.
-  @pragma('dart2js:noInline')
-  static _makeLiteral(keyValuePairs) =>
-      fillLiteralMap(keyValuePairs, JsLinkedHashMap());
 }
 
 // TODO(sra): Move to same library as JsLinkedHashMap and make the `internalXXX`
@@ -1079,18 +1066,6 @@ class LinkedHashSet<E> {
   @pragma('dart2js:noInline')
   factory LinkedHashSet._literal(List values) =>
       fillLiteralSet(values, _LinkedHashSet<E>());
-
-  // Private factory static function called by generated code for set literals.
-  // This version is for set literals without type parameters.
-  @pragma('dart2js:noThrows')
-  @pragma('dart2js:noInline')
-  @pragma('dart2js:noSideEffects')
-  static _makeEmpty() => _LinkedHashSet();
-
-  // Private factory static function called by generated code for set literals.
-  // This version is for set literals without type parameters.
-  @pragma('dart2js:noInline')
-  static _makeLiteral(List values) => fillLiteralSet(values, _LinkedHashSet());
 }
 
 base class _LinkedHashSet<E> extends _SetBase<E> implements LinkedHashSet<E> {