Skip to content

Commit f1d81e3

Browse files
mkustermannCommit Queue
authored andcommitted
[dart2wasm] Ensure tests/web/wasm/issue_56234_test runs in unoptimized mode
This test is a regression test for a dart2wasm compiler crash. It tests that the compiler doesn't crash anymore but the error happens at runtime. The particular error that will happen at runtime is that `unreachable` will be hit (in the place where a unboxed double is attempted to be cast to an unboxed integer). Since we run binaryen with `--traps-never-happen` it may optimize this `unreachable` away and make the test accidentally pass. So we force this to be run in `-O0` mode, which means we don't run binaryen on it. Change-Id: I6460982d4b32d773ee763e9687c8fec0bffa00f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415881 Reviewed-by: Ömer Ağacan <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 391b9ee commit f1d81e3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/web/wasm/issue_56234_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Formatting can break multitests, so don't format them.
66
// dart format off
77

8-
// dart2wasmOptions=--extra-compiler-option=--omit-explicit-checks
8+
// dart2wasmOptions=-O0 --extra-compiler-option=--omit-explicit-checks
99

1010
class C {
1111
final double x;

0 commit comments

Comments
 (0)