[analyzer] Rename error constants to camelCase.

This change was generated by the following process:

- The script `pkg/analyzer/tool/messages/rename_error_constants.dart`
  was run. This generated the vast majority of the diffs.

- Then all modified files were reformatted using
  `tools/sdk/dart-sdk/bin/dart/format`.

- Finally, the script `pkg/analyzer/tool/messages/generate.dart` was
  run, to rebuild generated code.

Change-Id: I6a6a69644ed8740ad6269d98cb169076151824ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444921
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/scanner/errors.dart

@@ -38,7 +38,7 @@ void translateErrorToken(ErrorToken token, ReportError reportError) {
       // TODO(paulberry,ahe): Fasta reports the error location as the entire
       // string; analyzer expects the end of the string.
       reportError(
-        ScannerErrorCode.UNTERMINATED_STRING_LITERAL,
+        ScannerErrorCode.unterminatedStringLiteral,
         endOffset - 1,
         null,
       );
@@ -48,7 +48,7 @@ void translateErrorToken(ErrorToken token, ReportError reportError) {
       // TODO(paulberry,ahe): Fasta reports the error location as the entire
       // comment; analyzer expects the end of the comment.
       reportError(
-        ScannerErrorCode.UNTERMINATED_MULTI_LINE_COMMENT,
+        ScannerErrorCode.unterminatedMultiLineComment,
         endOffset - 1,
         null,
       );
@@ -58,24 +58,24 @@ void translateErrorToken(ErrorToken token, ReportError reportError) {
       // TODO(paulberry,ahe): Fasta reports the error location as the entire
       // number; analyzer expects the end of the number.
       charOffset = endOffset - 1;
-      return _makeError(ScannerErrorCode.MISSING_DIGIT, null);
+      return _makeError(ScannerErrorCode.missingDigit, null);
 
     case "MISSING_HEX_DIGIT":
       // TODO(paulberry,ahe): Fasta reports the error location as the entire
       // number; analyzer expects the end of the number.
       charOffset = endOffset - 1;
-      return _makeError(ScannerErrorCode.MISSING_HEX_DIGIT, null);
+      return _makeError(ScannerErrorCode.missingHexDigit, null);
 
     case "ILLEGAL_CHARACTER":
       // We can safely assume `token.character` is non-`null` because this error
       // is only reported when there is a character associated with the token.
-      return _makeError(ScannerErrorCode.ILLEGAL_CHARACTER, [token.character!]);
+      return _makeError(ScannerErrorCode.illegalCharacter, [token.character!]);
 
     case "UNEXPECTED_SEPARATOR_IN_NUMBER":
-      return _makeError(ScannerErrorCode.UNEXPECTED_SEPARATOR_IN_NUMBER, null);
+      return _makeError(ScannerErrorCode.unexpectedSeparatorInNumber, null);
 
     case "UNSUPPORTED_OPERATOR":
-      return _makeError(ScannerErrorCode.UNSUPPORTED_OPERATOR, [
+      return _makeError(ScannerErrorCode.unsupportedOperator, [
         (token as UnsupportedOperator).token.lexeme,
       ]);
 
@@ -85,19 +85,19 @@ void translateErrorToken(ErrorToken token, ReportError reportError) {
         TokenType type = token.begin!.type;
         if (type == TokenType.OPEN_CURLY_BRACKET ||
             type == TokenType.STRING_INTERPOLATION_EXPRESSION) {
-          return _makeError(ScannerErrorCode.EXPECTED_TOKEN, ['}']);
+          return _makeError(ScannerErrorCode.expectedToken, ['}']);
         }
         if (type == TokenType.OPEN_SQUARE_BRACKET) {
-          return _makeError(ScannerErrorCode.EXPECTED_TOKEN, [']']);
+          return _makeError(ScannerErrorCode.expectedToken, [']']);
         }
         if (type == TokenType.OPEN_PAREN) {
-          return _makeError(ScannerErrorCode.EXPECTED_TOKEN, [')']);
+          return _makeError(ScannerErrorCode.expectedToken, [')']);
         }
         if (type == TokenType.LT) {
-          return _makeError(ScannerErrorCode.EXPECTED_TOKEN, ['>']);
+          return _makeError(ScannerErrorCode.expectedToken, ['>']);
         }
       } else if (errorCode == codeUnexpectedDollarInString) {
-        return _makeError(ScannerErrorCode.MISSING_IDENTIFIER, null);
+        return _makeError(ScannerErrorCode.missingIdentifier, null);
       }
       throw new UnimplementedError(
         '$errorCode "${errorCode.analyzerCodes?.first}"',

pkg/_fe_analyzer_shared/lib/src/scanner/errors.g.dart

@@ -29,52 +29,52 @@ import "package:_fe_analyzer_shared/src/base/errors.dart";
 class ScannerErrorCode extends DiagnosticCode {
   /// Parameters:
   /// String p0: the token that was expected but not found
-  static const ScannerErrorCode EXPECTED_TOKEN = const ScannerErrorCode(
+  static const ScannerErrorCode expectedToken = const ScannerErrorCode(
     'EXPECTED_TOKEN',
     "Expected to find '{0}'.",
   );
 
   /// Parameters:
   /// Object p0: the illegal character
-  static const ScannerErrorCode ILLEGAL_CHARACTER = const ScannerErrorCode(
+  static const ScannerErrorCode illegalCharacter = const ScannerErrorCode(
     'ILLEGAL_CHARACTER',
     "Illegal character '{0}'.",
   );
 
   /// No parameters.
-  static const ScannerErrorCode MISSING_DIGIT = const ScannerErrorCode(
+  static const ScannerErrorCode missingDigit = const ScannerErrorCode(
     'MISSING_DIGIT',
     "Decimal digit expected.",
   );
 
   /// No parameters.
-  static const ScannerErrorCode MISSING_HEX_DIGIT = const ScannerErrorCode(
+  static const ScannerErrorCode missingHexDigit = const ScannerErrorCode(
     'MISSING_HEX_DIGIT',
     "Hexadecimal digit expected.",
   );
 
   /// No parameters.
-  static const ScannerErrorCode MISSING_IDENTIFIER = const ScannerErrorCode(
+  static const ScannerErrorCode missingIdentifier = const ScannerErrorCode(
     'MISSING_IDENTIFIER',
     "Expected an identifier.",
   );
 
   /// No parameters.
-  static const ScannerErrorCode MISSING_QUOTE = const ScannerErrorCode(
+  static const ScannerErrorCode missingQuote = const ScannerErrorCode(
     'MISSING_QUOTE',
     "Expected quote (' or \").",
   );
 
   /// Parameters:
   /// Object p0: the path of the file that cannot be read
-  static const ScannerErrorCode UNABLE_GET_CONTENT = const ScannerErrorCode(
+  static const ScannerErrorCode unableGetContent = const ScannerErrorCode(
     'UNABLE_GET_CONTENT',
     "Unable to get content of '{0}'.",
   );
 
   /// No parameters.
   static const ScannerErrorCode
-  UNEXPECTED_DOLLAR_IN_STRING = const ScannerErrorCode(
+  unexpectedDollarInString = const ScannerErrorCode(
     'UNEXPECTED_DOLLAR_IN_STRING',
     "A '\$' has special meaning inside a string, and must be followed by an "
         "identifier or an expression in curly braces ({}).",
@@ -83,7 +83,7 @@ class ScannerErrorCode extends DiagnosticCode {
 
   /// No parameters.
   static const ScannerErrorCode
-  UNEXPECTED_SEPARATOR_IN_NUMBER = const ScannerErrorCode(
+  unexpectedSeparatorInNumber = const ScannerErrorCode(
     'UNEXPECTED_SEPARATOR_IN_NUMBER',
     "Digit separators ('_') in a number literal can only be placed between two "
         "digits.",
@@ -92,13 +92,13 @@ class ScannerErrorCode extends DiagnosticCode {
 
   /// Parameters:
   /// String p0: the unsupported operator
-  static const ScannerErrorCode UNSUPPORTED_OPERATOR = const ScannerErrorCode(
+  static const ScannerErrorCode unsupportedOperator = const ScannerErrorCode(
     'UNSUPPORTED_OPERATOR',
     "The '{0}' operator is not supported.",
   );
 
   /// No parameters.
-  static const ScannerErrorCode UNTERMINATED_MULTI_LINE_COMMENT =
+  static const ScannerErrorCode unterminatedMultiLineComment =
       const ScannerErrorCode(
         'UNTERMINATED_MULTI_LINE_COMMENT',
         "Unterminated multi-line comment.",
@@ -108,7 +108,7 @@ class ScannerErrorCode extends DiagnosticCode {
       );
 
   /// No parameters.
-  static const ScannerErrorCode UNTERMINATED_STRING_LITERAL =
+  static const ScannerErrorCode unterminatedStringLiteral =
       const ScannerErrorCode(
         'UNTERMINATED_STRING_LITERAL',
         "Unterminated string literal.",

pkg/analysis_server/lib/src/lsp/mapping.dart

@@ -52,21 +52,19 @@ final completionFilterTextSplitPattern = RegExp(r'=>|[\(]');
 final completionSetterTypePattern = RegExp(r'^\((\S+)\s+\S+\)$');
 
 final diagnosticTagsForErrorCode = <String, List<lsp.DiagnosticTag>>{
-  _diagnosticCode(WarningCode.DEAD_CODE): [lsp.DiagnosticTag.Unnecessary],
-  _diagnosticCode(HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE): [
+  _diagnosticCode(WarningCode.deadCode): [lsp.DiagnosticTag.Unnecessary],
+  _diagnosticCode(HintCode.deprecatedMemberUseFromSamePackage): [
     lsp.DiagnosticTag.Deprecated,
   ],
-  _diagnosticCode(
-    HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE,
-  ): [lsp.DiagnosticTag.Deprecated],
-  _diagnosticCode(HintCode.DEPRECATED_MEMBER_USE): [
+  _diagnosticCode(HintCode.deprecatedMemberUseFromSamePackageWithMessage): [
     lsp.DiagnosticTag.Deprecated,
   ],
+  _diagnosticCode(HintCode.deprecatedMemberUse): [lsp.DiagnosticTag.Deprecated],
   'deprecated_member_use_from_same_package': [lsp.DiagnosticTag.Deprecated],
   'deprecated_member_use_from_same_package_with_message': [
     lsp.DiagnosticTag.Deprecated,
   ],
-  _diagnosticCode(HintCode.DEPRECATED_MEMBER_USE_WITH_MESSAGE): [
+  _diagnosticCode(HintCode.deprecatedMemberUseWithMessage): [
     lsp.DiagnosticTag.Deprecated,
   ],
 };

pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

@@ -313,7 +313,7 @@ class StatementCompletionProcessor {
           : null;
     }
 
-    var expr = diagnosticMatching(ScannerErrorCode.UNTERMINATED_STRING_LITERAL);
+    var expr = diagnosticMatching(ScannerErrorCode.unterminatedStringLiteral);
     if (expr != null) {
       var source = utils.getNodeText(expr);
       var content = source;
@@ -339,18 +339,15 @@ class StatementCompletionProcessor {
         delimiter = content.substring(0, 1);
         loc = expr.offset + source.length;
       }
-      _removeError(ScannerErrorCode.UNTERMINATED_STRING_LITERAL);
+      _removeError(ScannerErrorCode.unterminatedStringLiteral);
       _addInsertEdit(loc, delimiter);
     }
     expr =
         diagnosticMatching(
-          ParserErrorCode.EXPECTED_TOKEN,
+          ParserErrorCode.expectedToken,
           partialMatch: "']'",
         ) ??
-        diagnosticMatching(
-          ScannerErrorCode.EXPECTED_TOKEN,
-          partialMatch: "']'",
-        );
+        diagnosticMatching(ScannerErrorCode.expectedToken, partialMatch: "']'");
     if (expr != null) {
       expr = expr.thisOrAncestorOfType<ListLiteral>();
       if (expr is ListLiteral) {
@@ -363,8 +360,8 @@ class StatementCompletionProcessor {
           } else {
             _addInsertEdit(loc, ']');
           }
-          _removeError(ParserErrorCode.EXPECTED_TOKEN, partialMatch: "']'");
-          _removeError(ScannerErrorCode.EXPECTED_TOKEN, partialMatch: "']'");
+          _removeError(ParserErrorCode.expectedToken, partialMatch: "']'");
+          _removeError(ScannerErrorCode.expectedToken, partialMatch: "']'");
         }
       }
     }
@@ -436,7 +433,7 @@ class StatementCompletionProcessor {
     var delta = 0;
     if (diagnostics.isNotEmpty) {
       var error = _findDiagnostic(
-        ParserErrorCode.EXPECTED_TOKEN,
+        ParserErrorCode.expectedToken,
         partialMatch: "';'",
       );
       if (error != null) {
@@ -752,9 +749,7 @@ class StatementCompletionProcessor {
     var needsParen = false;
     int computeExitPos(FormalParameterList parameters) {
       if (needsParen = parameters.rightParenthesis.isSynthetic) {
-        var error = _findDiagnostic(
-          ParserErrorCode.MISSING_CLOSING_PARENTHESIS,
-        );
+        var error = _findDiagnostic(ParserErrorCode.missingClosingParenthesis);
         if (error != null) {
           return error.offset - 1;
         }
@@ -794,7 +789,7 @@ class StatementCompletionProcessor {
       return false;
     }
     var error = _findDiagnostic(
-      ParserErrorCode.EXPECTED_TOKEN,
+      ParserErrorCode.expectedToken,
       partialMatch: "';'",
     );
     if (error != null) {
@@ -928,8 +923,8 @@ class StatementCompletionProcessor {
 
   bool _complete_methodCall(AstNode node) {
     var parenError =
-        _findDiagnostic(ParserErrorCode.EXPECTED_TOKEN, partialMatch: "')'") ??
-        _findDiagnostic(ScannerErrorCode.EXPECTED_TOKEN, partialMatch: "')'");
+        _findDiagnostic(ParserErrorCode.expectedToken, partialMatch: "')'") ??
+        _findDiagnostic(ScannerErrorCode.expectedToken, partialMatch: "')'");
     if (parenError == null) {
       return false;
     }
@@ -947,7 +942,7 @@ class StatementCompletionProcessor {
     var loc = min(selectionOffset, argList.end);
     _addInsertEdit(loc, ')');
     var semicolonError = _findDiagnostic(
-      ParserErrorCode.EXPECTED_TOKEN,
+      ParserErrorCode.expectedToken,
       partialMatch: "';'",
     );
     if (semicolonError != null) {
@@ -982,7 +977,7 @@ class StatementCompletionProcessor {
       return false;
     }
     var error = _findDiagnostic(
-      ParserErrorCode.EXPECTED_TOKEN,
+      ParserErrorCode.expectedToken,
       partialMatch: "';'",
     );
     if (error != null) {
@@ -1075,7 +1070,7 @@ class StatementCompletionProcessor {
         if (onKeyword != null && exceptionType != null) {
           if (exceptionType.length == 0 ||
               _findDiagnostic(
-                    CompileTimeErrorCode.NON_TYPE_IN_CATCH_CLAUSE,
+                    CompileTimeErrorCode.nonTypeInCatchClause,
                     partialMatch: "name 'catch",
                   ) !=
                   null) {