Find options file when it is not in the folder of the containing root.

Fixes #56552

Change-Id: I1cf8ec10203a2b1bb11eafd16938ceb4f965c03c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390082
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: keertip

pkg/analyzer/lib/src/dart/analysis/context_locator.dart

@@ -348,6 +348,19 @@ class ContextLocatorImpl implements ContextLocator {
       );
       var root = ContextRootImpl(resourceProvider, folder, workspace);
       root.packagesFile = rootPackagesFile;
+      // Check for analysis options file in the parent directories, from
+      // root folder to the containing root folder. Pick the one closest
+      // to the root.
+      if (localOptionsFile == null) {
+        var parentFolder = root.root.parent;
+        while (parentFolder != containingRoot.root) {
+          localOptionsFile = parentFolder.existingAnalysisOptionsYamlFile;
+          if (localOptionsFile != null) {
+            break;
+          }
+          parentFolder = parentFolder.parent;
+        }
+      }
       root.optionsFile = localOptionsFile ?? containingRoot.optionsFile;
       root.included.add(folder);
       containingRoot.excluded.add(folder);

pkg/analyzer/test/src/dart/analysis/analysis_context_collection_test.dart

@@ -297,13 +297,16 @@ name: test
     );
 
     newFile('$testPackageLibPath/a.dart', '');
-    newFile('$testPackageLibPath/b.g.dart', '');
-    newAnalysisOptionsYamlFile(testPackageRootPath, r'''
+    newAnalysisOptionsYamlFile(testPackageLibPath, r'''
 analyzer:
   exclude:
     - "**/*.g.dart"
 ''');
 
+    var nestedNoYamlPath = '$testPackageLibPath/nestedNoYaml';
+    newFile('$nestedNoYamlPath/a.dart', '');
+    newFile('$nestedNoYamlPath/b.g.dart', '');
+
     var nestedPath = '$testPackageLibPath/nested';
     newFile('$nestedPath/lib/c.dart', '');
     newFile('$nestedPath/lib/d.g.dart', '');
@@ -320,24 +323,28 @@ name: nested
 contexts
   /home/test
     packagesFile: /home/test/.dart_tool/package_config.json
-    optionsFile: /home/test/analysis_options.yaml
     workspace: workspace_0
     analyzedFiles
       /home/test/lib/a.dart
         uri: package:test/a.dart
         analysisOptions_0
         workspacePackage_0_0
+      /home/test/lib/nestedNoYaml/a.dart
+        uri: package:test/nestedNoYaml/a.dart
+        analysisOptions_0
+        workspacePackage_0_0
   /home/test/lib/nested
     packagesFile: /home/test/lib/nested/.dart_tool/package_config.json
-    optionsFile: /home/test/analysis_options.yaml
+    optionsFile: /home/test/lib/analysis_options.yaml
     workspace: workspace_1
     analyzedFiles
       /home/test/lib/nested/lib/c.dart
         uri: package:nested/c.dart
-        analysisOptions_0
+        analysisOptions_1
         workspacePackage_1_0
 analysisOptions
-  analysisOptions_0: /home/test/analysis_options.yaml
+  analysisOptions_0: /home/test/lib/analysis_options.yaml
+  analysisOptions_1: /home/test/lib/analysis_options.yaml
 workspaces
   workspace_0: PackageConfigWorkspace
     root: /home/test