DAS plugins: Support priority files

Change-Id: I0c0106bc573250a6d4a4d2d11dbb96c4178dde93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395681
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/lib/src/plugin_server.dart

@@ -62,6 +62,9 @@ class PluginServer {
 
   String? _sdkPath;
 
+  /// Paths of priority files.
+  Set<String> _priorityPaths = {};
+
   final List<Plugin> _plugins;
 
   final _registry = PluginRegistryImpl();
@@ -82,6 +85,16 @@ class PluginServer {
     }
   }
 
+  /// Handles an 'analysis.setPriorityFiles' request.
+  ///
+  /// Throws a [RequestFailure] if the request could not be handled.
+  Future<protocol.AnalysisSetPriorityFilesResult>
+      handleAnalysisSetPriorityFiles(
+          protocol.AnalysisSetPriorityFilesParams parameters) async {
+    _priorityPaths = parameters.files.toSet();
+    return protocol.AnalysisSetPriorityFilesResult();
+  }
+
   /// Handles an 'edit.getFixes' request.
   ///
   /// Throws a [RequestFailure] if the request could not be handled.
@@ -185,23 +198,43 @@ class PluginServer {
     });
   }
 
+  Future<void> _analyzeFile({
+    required AnalysisContext analysisContext,
+    required String path,
+  }) async {
+    var file = _resourceProvider.getFile(path);
+    var analysisOptions = analysisContext.getAnalysisOptionsForFile(file);
+    var lints = await _computeLints(
+      analysisContext,
+      path,
+      analysisOptions: analysisOptions as AnalysisOptionsImpl,
+    );
+    _channel.sendNotification(
+        protocol.AnalysisErrorsParams(path, lints).toNotification());
+  }
+
   /// Analyzes the files at the given [paths].
   Future<void> _analyzeFiles({
     required AnalysisContext analysisContext,
     required List<String> paths,
   }) async {
-    // TODO(srawlins): Implement "priority files" and analyze them first.
-    // TODO(srawlins): Analyze libraries instead of files, for efficiency.
-    for (var path in paths.toSet()) {
-      var file = _resourceProvider.getFile(path);
-      var analysisOptions = analysisContext.getAnalysisOptionsForFile(file);
-      var lints = await _computeLints(
-        analysisContext,
-        path,
-        analysisOptions: analysisOptions as AnalysisOptionsImpl,
+    var pathSet = paths.toSet();
+
+    // First analyze priority files.
+    for (var path in _priorityPaths) {
+      pathSet.remove(path);
+      await _analyzeFile(
+        analysisContext: analysisContext,
+        path: path,
+      );
+    }
+
+    // Then analyze the remaining files.
+    for (var path in pathSet) {
+      await _analyzeFile(
+        analysisContext: analysisContext,
+        path: path,
       );
-      _channel.sendNotification(
-          protocol.AnalysisErrorsParams(path, lints).toNotification());
     }
   }
 
@@ -294,12 +327,21 @@ class PluginServer {
     return errorsAndProtocolErrors.map((e) => e.protocolError).toList();
   }
 
-  /// Invokes [fn] for all analysis contexts.
+  /// Invokes [fn] first for priority analysis contexts, then for the rest.
   Future<void> _forAnalysisContexts(
     AnalysisContextCollection contextCollection,
     Future<void> Function(AnalysisContext analysisContext) fn,
   ) async {
+    var nonPriorityAnalysisContexts = <AnalysisContext>[];
     for (var analysisContext in contextCollection.contexts) {
+      if (_isPriorityAnalysisContext(analysisContext)) {
+        await fn(analysisContext);
+      } else {
+        nonPriorityAnalysisContexts.add(analysisContext);
+      }
+    }
+
+    for (var analysisContext in nonPriorityAnalysisContexts) {
       await fn(analysisContext);
     }
   }
@@ -495,6 +537,9 @@ class PluginServer {
     );
   }
 
+  bool _isPriorityAnalysisContext(AnalysisContext analysisContext) =>
+      _priorityPaths.any(analysisContext.contextRoot.isAnalyzed);
+
   static protocol.Location _locationFor(
       CompilationUnit unit, String path, AnalysisError error) {
     var lineInfo = unit.lineInfo;