[analysis_server] Fix some typos in readme/spec

Change-Id: Ifb14293a886eedd0ee868ac43ef18b6224967ac8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427740
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: DanTup

pkg/analysis_server/doc/api.html

@@ -181,7 +181,7 @@ <h3>Communication Structure</h3>
   is the 'clientRequestTime' field, which is a number indicating
   the time at which the client made the request (milliseconds
   since epoch). Providing clientRequestTime helps us track
-  how responsive analysis server is to client requests
+  how responsive the analysis server is to client requests
   and better address any issues that occur.
 </p>
 <p>
@@ -247,7 +247,7 @@ <h3>Enumerations</h3>
 <h3>Changelog</h3>
 <h4>1.40.0</h4>
 <ul>
-  <li>Added a an optional <tt>version</tt> field to <tt>AddContentOverlay</tt> and <tt>ChangeContentOverlay</tt> to allow clients/servers to have a way to identify specific versions of documents.</li>
+  <li>Added an optional <tt>version</tt> field to <tt>AddContentOverlay</tt> and <tt>ChangeContentOverlay</tt> to allow clients/servers to have a way to identify specific versions of documents.</li>
 </ul>
 <h4>1.39.0</h4>
 <ul>
@@ -957,7 +957,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
   }
 }</pre></div>
     <p>
-      Return the hover information associate with the given
+      Return the hover information associated with the given
       location. If some or all of the hover information is not
       available at the time this request is processed the
       information will be omitted from the response.
@@ -1183,14 +1183,14 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
       analysis roots is automatically updated, but the set of
       requested analysis roots is unchanged. This means that if
       the client sets an analysis root before the root becomes
-      visible to server in the filesystem, there is no error; once
-      the server sees the root in the filesystem it will start
-      analyzing it. Similarly, server will stop analyzing files
+      visible to the server in the filesystem, there is no error;
+      once the server sees the root in the filesystem it will start
+      analyzing it. Similarly, the server will stop analyzing files
       that are removed from the file system but they will remain
       in the set of requested roots.
     </p>
     <p>
-      If an included path represents a file, then server will look
+      If an included path represents a file, then the server will look
       in the directory containing the file for a pubspec.yaml
       file. If none is found, then the parents of the directory
       will be searched until such a file is found or the root of
@@ -1364,7 +1364,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>subscriptions: Map&lt;<a href="#typ
       previously updated but not included in this update remain
       unchanged. This effectively represents an overlay of the
       filesystem. The files whose content is overridden are
-      therefore seen by server as being files with the given
+      therefore seen by the server as being files with the given
       content, even if the files do not exist on the filesystem or
       if the file path represents the path to a directory on the
       filesystem.
@@ -1449,7 +1449,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
         <p>
           Closing labels relevant to the file. Each item
           represents a useful label associated with some range
-          with may be useful to display to the user within the editor
+          which may be useful to display to the user within the editor
           at the end of the range to indicate what construct is closed
           at that location. Closing labels include constructor/method
           calls and List arguments that span multiple lines.
@@ -1604,7 +1604,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
       </dd><dt class="field"><b>members: List&lt;<a href="#type_ImplementedMember">ImplementedMember</a>&gt;</b></dt><dd>
 
         <p>
-          The member defined in the file that are implemented or overridden.
+          The members defined in the file that are implemented or overridden.
         </p>
       </dd></dl></dd><dt class="notification"><a name="notification_analysis.invalidate">analysis.invalidate</a></dt><dd><div class="box"><pre>notification: {
   "event": "analysis.invalidate"
@@ -1968,8 +1968,8 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
         <p>
           The <tt>completion</tt> from the selected
           <tt>CompletionSuggestion</tt>.  It could be a name of a class, or a
-          name of a constructor in form "typeName.constructorName()", or an
-          enumeration constant in form "enumName.constantName", etc.
+          name of a constructor in the form "typeName.constructorName()", or an
+          enumeration constant in the form "enumName.constantName", etc.
         </p>
       </dd><dt class="field"><b>libraryUri: String</b></dt><dd>
 
@@ -2722,7 +2722,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
       </dd></dl><h4>returns:</h4><dl><dt class="field"><b>edit: <a href="#type_SourceFileEdit">SourceFileEdit</a></b></dt><dd>
 
         <p>
-          The file edit that is to be applied to the given file to effect
+          The file edit that is to be applied to the given file to affect
           the sorting.
         </p>
       </dd></dl></dd><dt class="request"><a name="request_edit.organizeDirectives">edit.organizeDirectives</a></dt><dd><div class="box"><pre>request: {
@@ -2765,7 +2765,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>file: <a href="#type_FilePath">File
       </dd></dl><h4>returns:</h4><dl><dt class="field"><b>edit: <a href="#type_SourceFileEdit">SourceFileEdit</a></b></dt><dd>
 
         <p>
-          The file edit that is to be applied to the given file to effect
+          The file edit that is to be applied to the given file to affect
           the organizing.
         </p>
       </dd></dl></dd></dl>
@@ -2919,7 +2919,7 @@ <h4>parameters:</h4><dl><dt class="field"><b>code: String</b></dt><dd>
       </dd></dl><h4>returns:</h4><dl><dt class="field"><b>suggestions: List&lt;<a href="#type_CompletionSuggestion">CompletionSuggestion</a>&gt;<span style="color:#999999"> (optional)</span></b></dt><dd>
 
         <p>
-          The completion suggestions. In contrast to usual completion request,
+          The completion suggestions. In contrast to usual completion requests,
           suggestions for private elements also will be provided.
         </p>
         <p>
@@ -3290,7 +3290,7 @@ <h2 class="domain"><a name="types">Types</a></h2>
       </dd><dt class="field"><b>version: int<span style="color:#999999"> (optional)</span></b></dt><dd>
 
         <p>An optional version number for the document. Version numbers allow the server to tag edits with the version of the document they apply to which can avoid applying edits to documents that have already been updated since the edits were computed.</p>
-        <p>If version numbers are supplied with AddContentOverlay and ChangeContentOverlay, they must be increasing (not not necessarily consecutive) numbers.</p>
+        <p>If version numbers are supplied with AddContentOverlay and ChangeContentOverlay, they must be increasing (but not necessarily consecutive) numbers.</p>
       </dd></dl></dd><dt class="typeDefinition"><a name="type_AnalysisError">AnalysisError: object</a></dt><dd>
     <p>
       An indication of an error, warning, or hint that was produced by the
@@ -3523,7 +3523,7 @@ <h2 class="domain"><a name="types">Types</a></h2>
       </dd><dt class="field"><b>version: int<span style="color:#999999"> (optional)</span></b></dt><dd>
 
         <p>An optional version number for the document. Version numbers allow the server to tag edits with the version of the document they apply to which can avoid applying edits to documents that have already been updated since the edits were computed.</p>
-        <p>If version numbers are supplied with AddContentOverlay and ChangeContentOverlay, they must be increasing (not not necessarily consecutive) numbers.</p>
+        <p>If version numbers are supplied with AddContentOverlay and ChangeContentOverlay, they must be increasing (but not necessarily consecutive) numbers.</p>
       </dd></dl></dd><dt class="typeDefinition"><a name="type_ClosingLabel">ClosingLabel: object</a></dt><dd>
     <p>
       A label that is associated with a range of code that may be useful to

pkg/analysis_server/lib/protocol/protocol_generated.dart

@@ -126,7 +126,7 @@ class AnalysisClosingLabelsParams implements HasToJson {
   String file;
 
   /// Closing labels relevant to the file. Each item represents a useful label
-  /// associated with some range with may be useful to display to the user
+  /// associated with some range which may be useful to display to the user
   /// within the editor at the end of the range to indicate what construct is
   /// closed at that location. Closing labels include constructor/method calls
   /// and List arguments that span multiple lines. Note that the ranges that
@@ -2262,7 +2262,7 @@ class AnalysisImplementedParams implements HasToJson {
   /// The classes defined in the file that are implemented or extended.
   List<ImplementedClass> classes;
 
-  /// The member defined in the file that are implemented or overridden.
+  /// The members defined in the file that are implemented or overridden.
   List<ImplementedMember> members;
 
   AnalysisImplementedParams(this.file, this.classes, this.members);
@@ -5205,8 +5205,8 @@ class CompletionGetSuggestionDetails2Params implements RequestParams {
   int offset;
 
   /// The `completion` from the selected `CompletionSuggestion`. It could be a
-  /// name of a class, or a name of a constructor in form
-  /// "typeName.constructorName()", or an enumeration constant in form
+  /// name of a class, or a name of a constructor in the form
+  /// "typeName.constructorName()", or an enumeration constant in the form
   /// "enumName.constantName", etc.
   String completion;
 
@@ -9288,7 +9288,7 @@ class EditOrganizeDirectivesParams implements RequestParams {
 ///
 /// Clients may not extend, implement or mix-in this class.
 class EditOrganizeDirectivesResult implements ResponseResult {
-  /// The file edit that is to be applied to the given file to effect the
+  /// The file edit that is to be applied to the given file to affect the
   /// organizing.
   SourceFileEdit edit;
 
@@ -9460,7 +9460,7 @@ class EditSortMembersParams implements RequestParams {
 ///
 /// Clients may not extend, implement or mix-in this class.
 class EditSortMembersResult implements ResponseResult {
-  /// The file edit that is to be applied to the given file to effect the
+  /// The file edit that is to be applied to the given file to affect the
   /// sorting.
   SourceFileEdit edit;
 
@@ -10430,7 +10430,7 @@ class ExecutionGetSuggestionsParams implements RequestParams {
 ///
 /// Clients may not extend, implement or mix-in this class.
 class ExecutionGetSuggestionsResult implements ResponseResult {
-  /// The completion suggestions. In contrast to usual completion request,
+  /// The completion suggestions. In contrast to usual completion requests,
   /// suggestions for private elements also will be provided.
   ///
   /// If there are sub-expressions that can have different runtime types, and

pkg/analysis_server/test/integration/support/integration_test_methods.dart

@@ -392,7 +392,7 @@ abstract class IntegrationTest {
     );
   }
 
-  /// Return the hover information associate with the given location. If some
+  /// Return the hover information associated with the given location. If some
   /// or all of the hover information is not available at the time this request
   /// is processed the information will be omitted from the response.
   ///
@@ -712,12 +712,12 @@ abstract class IntegrationTest {
   /// filesystem. When the filesystem changes, the actual set of analysis roots
   /// is automatically updated, but the set of requested analysis roots is
   /// unchanged. This means that if the client sets an analysis root before the
-  /// root becomes visible to server in the filesystem, there is no error; once
-  /// the server sees the root in the filesystem it will start analyzing it.
-  /// Similarly, server will stop analyzing files that are removed from the
-  /// file system but they will remain in the set of requested roots.
+  /// root becomes visible to the server in the filesystem, there is no error;
+  /// once the server sees the root in the filesystem it will start analyzing
+  /// it. Similarly, the server will stop analyzing files that are removed from
+  /// the file system but they will remain in the set of requested roots.
   ///
-  /// If an included path represents a file, then server will look in the
+  /// If an included path represents a file, then the server will look in the
   /// directory containing the file for a pubspec.yaml file. If none is found,
   /// then the parents of the directory will be searched until such a file is
   /// found or the root of the file system is reached. If such a file is found,
@@ -860,9 +860,9 @@ abstract class IntegrationTest {
   /// Update the content of one or more files. Files that were previously
   /// updated but not included in this update remain unchanged. This
   /// effectively represents an overlay of the filesystem. The files whose
-  /// content is overridden are therefore seen by server as being files with
-  /// the given content, even if the files do not exist on the filesystem or if
-  /// the file path represents the path to a directory on the filesystem.
+  /// content is overridden are therefore seen by the server as being files
+  /// with the given content, even if the files do not exist on the filesystem
+  /// or if the file path represents the path to a directory on the filesystem.
   ///
   /// Parameters
   ///
@@ -946,7 +946,7 @@ abstract class IntegrationTest {
   /// labels: List<ClosingLabel>
   ///
   ///   Closing labels relevant to the file. Each item represents a useful
-  ///   label associated with some range with may be useful to display to the
+  ///   label associated with some range which may be useful to display to the
   ///   user within the editor at the end of the range to indicate what
   ///   construct is closed at that location. Closing labels include
   ///   constructor/method calls and List arguments that span multiple lines.
@@ -1076,7 +1076,7 @@ abstract class IntegrationTest {
   ///
   /// members: List<ImplementedMember>
   ///
-  ///   The member defined in the file that are implemented or overridden.
+  ///   The members defined in the file that are implemented or overridden.
   late final Stream<AnalysisImplementedParams> onAnalysisImplemented =
       _onAnalysisImplemented.stream.asBroadcastStream();
 
@@ -1376,8 +1376,8 @@ abstract class IntegrationTest {
   /// completion: String
   ///
   ///   The `completion` from the selected `CompletionSuggestion`. It could be
-  ///   a name of a class, or a name of a constructor in form
-  ///   "typeName.constructorName()", or an enumeration constant in form
+  ///   a name of a class, or a name of a constructor in the form
+  ///   "typeName.constructorName()", or an enumeration constant in the form
   ///   "enumName.constantName", etc.
   ///
   /// libraryUri: String
@@ -2376,7 +2376,7 @@ abstract class IntegrationTest {
   ///
   /// edit: SourceFileEdit
   ///
-  ///   The file edit that is to be applied to the given file to effect the
+  ///   The file edit that is to be applied to the given file to affect the
   ///   sorting.
   Future<EditSortMembersResult> sendEditSortMembers(String file) async {
     var params = EditSortMembersParams(
@@ -2414,7 +2414,7 @@ abstract class IntegrationTest {
   ///
   /// edit: SourceFileEdit
   ///
-  ///   The file edit that is to be applied to the given file to effect the
+  ///   The file edit that is to be applied to the given file to affect the
   ///   organizing.
   Future<EditOrganizeDirectivesResult> sendEditOrganizeDirectives(
     String file,
@@ -2540,7 +2540,7 @@ abstract class IntegrationTest {
   ///
   /// suggestions: List<CompletionSuggestion> (optional)
   ///
-  ///   The completion suggestions. In contrast to usual completion request,
+  ///   The completion suggestions. In contrast to usual completion requests,
   ///   suggestions for private elements also will be provided.
   ///
   ///   If there are sub-expressions that can have different runtime types, and

pkg/analysis_server/tool/lsp_spec/README.md

@@ -158,7 +158,7 @@ The following custom fields/methods/notifications are also provided by the Dart
 
 ### Message.clientRequestTime Field
 
-The server accepts an optional `int?` on all incoming messages named `clientRequestTime` (alongside `id`, `method`, `params`) containing a timestamp (milliseconds since epoch) of when the client made that request. Providing clientRequestTime helps track how responsive analysis server is to client requests and better address any issues that occur.
+The server accepts an optional `int?` on all incoming messages named `clientRequestTime` (alongside `id`, `method`, `params`) containing a timestamp (milliseconds since epoch) of when the client made that request. Providing `clientRequestTime` helps track how responsive the analysis server is to client requests and better address any issues that occur.
 
 ### dart/diagnosticServer Method