[cfe] Remove unused properties from BodyBuilderContext

Change-Id: I75f6a3cdf63b32555ae96f181f99bfaec1de5e56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391403
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/base/scope.dart

@@ -764,10 +764,7 @@ mixin ErroneousMemberBuilderMixin implements SourceMemberBuilder {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
+  BodyBuilderContext createBodyBuilderContext() {
     throw new UnsupportedError(
         '$runtimeType.bodyBuilderContextForAnnotations}');
   }

pkg/front_end/lib/src/builder/formal_parameter_builder.dart

@@ -276,11 +276,8 @@ class FormalParameterBuilder extends BuilderImpl
         final DeclarationBuilder declarationBuilder =
             parent.declarationBuilder!;
         LookupScope scope = declarationBuilder.scope;
-        BodyBuilderContext bodyBuilderContext = new ParameterBodyBuilderContext(
-            this,
-            inOutlineBuildingPhase: true,
-            inMetadata: false,
-            inConstFields: false);
+        BodyBuilderContext bodyBuilderContext =
+            new ParameterBodyBuilderContext(this);
         BodyBuilder bodyBuilder = libraryBuilder.loader
             .createBodyBuilderForOutlineExpression(
                 libraryBuilder, bodyBuilderContext, scope, fileUri);

pkg/front_end/lib/src/fragment/constructor.dart

@@ -99,14 +99,8 @@ class _ConstructorBodyBuildingContext implements FunctionBodyBuildingContext {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override

pkg/front_end/lib/src/fragment/factory.dart

@@ -83,14 +83,8 @@ class _FactoryBodyBuildingContext implements FunctionBodyBuildingContext {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override

pkg/front_end/lib/src/fragment/function.dart

@@ -18,10 +18,7 @@ abstract class FunctionBodyBuildingContext {
   // TODO(johnniwinther): Avoid the need for this.
   bool get shouldBuild;
 
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields});
+  BodyBuilderContext createBodyBuilderContext();
 
   LookupScope get typeParameterScope;
 

pkg/front_end/lib/src/fragment/getter.dart

@@ -86,14 +86,8 @@ class _GetterBodyBuildingContext implements FunctionBodyBuildingContext {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override

pkg/front_end/lib/src/fragment/method.dart

@@ -88,14 +88,8 @@ class _MethodBodyBuildingContext implements FunctionBodyBuildingContext {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override

pkg/front_end/lib/src/fragment/primary_constructor.dart

@@ -91,14 +91,8 @@ class _PrimaryConstructorBodyBuildingContext
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override

pkg/front_end/lib/src/fragment/setter.dart

@@ -86,14 +86,8 @@ class _SetterBodyBuildingContext implements FunctionBodyBuildingContext {
   }
 
   @override
-  BodyBuilderContext createBodyBuilderContext(
-      {required bool inOutlineBuildingPhase,
-      required bool inMetadata,
-      required bool inConstFields}) {
-    return _fragment.builder.createBodyBuilderContext(
-        inOutlineBuildingPhase: inOutlineBuildingPhase,
-        inMetadata: inMetadata,
-        inConstFields: inConstFields);
+  BodyBuilderContext createBodyBuilderContext() {
+    return _fragment.builder.createBodyBuilderContext();
   }
 
   @override