[cfe] Use LookupResult for constructor lookup

This adds `LookupResult.isInvalidLookup` to the handle invalid lookup
results and uses this to avoid a lot of cascading error messages.

This is a step towards removing ProblemBuilder, AmbiguousBuilder and
reliance on `NamedBuilder.isDuplicate` in lookups.

Change-Id: Ia9d558ce55b45567607282295dd1e54e6187f9c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441880
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -18043,42 +18043,6 @@ const MessageCode messageUnnamedObjectPatternField = const MessageCode(
       r"""Try adding a pattern name or ':' before the pattern.""",
 );
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Template<Message Function(String name, String name2)>
-    templateUnresolvedPrefixInTypeAnnotation =
-    const Template<Message Function(String name, String name2)>(
-  "UnresolvedPrefixInTypeAnnotation",
-  problemMessageTemplate:
-      r"""'#name.#name2' can't be used as a type because '#name' isn't defined.""",
-  withArguments: _withArgumentsUnresolvedPrefixInTypeAnnotation,
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Message Function(String name, String name2)>
-    codeUnresolvedPrefixInTypeAnnotation =
-    const Code<Message Function(String name, String name2)>(
-  "UnresolvedPrefixInTypeAnnotation",
-  analyzerCodes: <String>["NOT_A_TYPE"],
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-Message _withArgumentsUnresolvedPrefixInTypeAnnotation(
-    String name, String name2) {
-  if (name.isEmpty) throw 'No name provided';
-  name = demangleMixinApplicationName(name);
-  if (name2.isEmpty) throw 'No name provided';
-  name2 = demangleMixinApplicationName(name2);
-  return new Message(
-    codeUnresolvedPrefixInTypeAnnotation,
-    problemMessage:
-        """'${name}.${name2}' can't be used as a type because '${name}' isn't defined.""",
-    arguments: {
-      'name': name,
-      'name2': name2,
-    },
-  );
-}
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Code<Null> codeUnsoundSwitchExpressionError =
     messageUnsoundSwitchExpressionError;

pkg/front_end/lib/src/base/identifiers.dart

@@ -78,6 +78,7 @@ class SimpleIdentifier extends IdentifierImpl {
     return new QualifiedNameGenerator(qualifier, token);
   }
 
+  // Coverage-ignore(suite): Not run.
   QualifiedNameBuilder withBuilderQualifier(Builder qualifier) {
     return new QualifiedNameBuilder(qualifier, token);
   }
@@ -187,6 +188,7 @@ class QualifiedNameGenerator extends QualifiedName {
   String toString() => "qualified-name-generator($qualifier, $name)";
 }
 
+// Coverage-ignore(suite): Not run.
 class QualifiedNameBuilder extends QualifiedName {
   final Builder qualifier;
 
@@ -195,7 +197,6 @@ class QualifiedNameBuilder extends QualifiedName {
   Token get suffix => token;
 
   @override
-  // Coverage-ignore(suite): Not run.
   int get firstOffset => qualifier.fileOffset;
 
   @override

pkg/front_end/lib/src/base/incremental_compiler.dart

@@ -1712,17 +1712,15 @@ class IncrementalCompiler implements IncrementalKernelGenerator {
           extensionName = beforeDot;
           if (builder is ExtensionBuilder) {
             extension = builder.extension;
-            Builder? subBuilder =
-                builder.lookupLocalMember(afterDot, setter: false);
+            Builder? subBuilder = builder.lookupLocalMember(afterDot)?.getable;
             if (subBuilder is MemberBuilder) {
               if (subBuilder.isExtensionInstanceMember) {
                 isStatic = false;
               }
             }
           } else if (builder is ExtensionTypeDeclarationBuilder) {
             extensionType = builder.extensionTypeDeclaration;
-            Builder? subBuilder =
-                builder.lookupLocalMember(afterDot, setter: false);
+            Builder? subBuilder = builder.lookupLocalMember(afterDot)?.getable;
             if (subBuilder is MemberBuilder) {
               if (subBuilder.isExtensionTypeInstanceMember) {
                 List<VariableDeclaration>? positionals =

pkg/front_end/lib/src/base/lookup_result.dart

@@ -2,7 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:kernel/ast.dart';
+
 import '../builder/builder.dart';
+import '../builder/declaration_builders.dart';
+import '../builder/member_builder.dart';
+import '../codes/cfe_codes.dart';
+import 'compiler_context.dart';
 import 'scope.dart';
 
 abstract class LookupResult {
@@ -12,6 +18,50 @@ abstract class LookupResult {
   /// The [NamedBuilder] used for writing to this entity, if any.
   NamedBuilder? get setable;
 
+  /// Returns `true` if the result is invalid.
+  ///
+  /// For instance because of duplicate declaration or because of an invalid
+  /// scope origin.
+  bool get isInvalidLookup;
+
+  static LocatedMessage createDuplicateMessage(LookupResult lookupResult,
+      {DeclarationBuilder? enclosingDeclaration,
+      required String name,
+      required Uri fileUri,
+      required int fileOffset,
+      required int length}) {
+    if (name.isEmpty) {
+      if (enclosingDeclaration != null) {
+        name = enclosingDeclaration.name;
+      } else {
+        name = 'new';
+      }
+      length = noLength;
+    }
+    Message message = templateDuplicatedDeclarationUse.withArguments(name);
+    return message.withLocation(fileUri, fileOffset, length);
+  }
+
+  static InvalidExpression createDuplicateExpression(LookupResult lookupResult,
+      {required CompilerContext context,
+      DeclarationBuilder? enclosingDeclaration,
+      required String name,
+      required Uri fileUri,
+      required int fileOffset,
+      required int length}) {
+    String text = context
+        .format(
+            createDuplicateMessage(lookupResult,
+                enclosingDeclaration: enclosingDeclaration,
+                name: name,
+                fileUri: fileUri,
+                fileOffset: fileOffset,
+                length: length),
+            Severity.error)
+        .plain;
+    return new InvalidExpression(text)..fileOffset = fileOffset;
+  }
+
   /// Creates a [LookupResult] for [getable] and [setable] which filters
   /// instance members if [staticOnly] is `true`, and creates an
   /// [AmbiguousBuilder] for duplicates using [fileUri] and [fileOffset].
@@ -26,6 +76,7 @@ abstract class LookupResult {
     bool changed = false;
     if (getable != null) {
       if (getable.next != null) {
+        // Coverage-ignore-block(suite): Not run.
         getable = new AmbiguousBuilder(name, getable, fileOffset, fileUri);
         changed = true;
       }
@@ -36,6 +87,7 @@ abstract class LookupResult {
     }
     if (setable != null) {
       if (setable.next != null) {
+        // Coverage-ignore-block(suite): Not run.
         setable = new AmbiguousBuilder(name, setable, fileOffset, fileUri);
         changed = true;
       }
@@ -91,6 +143,7 @@ abstract class LookupResult {
         return new GetableSetableResult(getable, setable!);
       }
     } else {
+      // Coverage-ignore-block(suite): Not run.
       if (getable != null && setable != null) {
         return new GetableSetableResult(getable, setable);
       } else if (getable != null) {
@@ -110,12 +163,12 @@ abstract class LookupResult {
     if (existing != null) {
       if (setter) {
         assert(existing.getable != null,
-            "No existing getable for $name: $existing.");
+            "No existing getable for $name: $existing, trying to add $member.");
         content[name] = new GetableSetableResult(existing.getable!, member);
         return;
       } else {
         assert(existing.setable != null,
-            "No existing setable for $name: $existing.");
+            "No existing setable for $name: $existing, trying to add $member.");
         content[name] = new GetableSetableResult(member, existing.setable!);
         return;
       }
@@ -130,7 +183,68 @@ abstract class LookupResult {
   }
 }
 
-class GetableResult implements LookupResult {
+abstract class InvalidLookupResult implements LookupResult {
+  factory InvalidLookupResult(LocatedMessage message) =
+      _InvalidLookupResultImpl;
+
+  LocatedMessage get message;
+}
+
+// Coverage-ignore(suite): Not run.
+class _InvalidLookupResultImpl implements InvalidLookupResult {
+  @override
+  final LocatedMessage message;
+
+  _InvalidLookupResultImpl(this.message);
+
+  @override
+  bool get isInvalidLookup => true;
+
+  @override
+  NamedBuilder? get getable => null;
+
+  @override
+  NamedBuilder? get setable => null;
+}
+
+abstract class MemberLookupResult implements LookupResult {
+  /// The [MemberBuilder] used for reading this entity, if any.
+  @override
+  MemberBuilder? get getable;
+
+  /// The [MemberBuilder] used for writing to this entity, if any.
+  @override
+  MemberBuilder? get setable;
+
+  /// Return `true` if this [MemberBuilder]s of this lookup result are accessed
+  /// statically.
+  bool get isStatic;
+}
+
+class InvalidMemberLookupResult
+    implements InvalidLookupResult, MemberLookupResult {
+  @override
+  final LocatedMessage message;
+
+  InvalidMemberLookupResult(this.message);
+
+  @override
+  bool get isInvalidLookup => true;
+
+  @override
+  // Coverage-ignore(suite): Not run.
+  MemberBuilder? get getable => null;
+
+  @override
+  // Coverage-ignore(suite): Not run.
+  MemberBuilder? get setable => null;
+
+  @override
+  // Coverage-ignore(suite): Not run.
+  bool get isStatic => true;
+}
+
+class GetableResult with LookupResultMixin implements LookupResult {
   @override
   final NamedBuilder getable;
 
@@ -140,7 +254,8 @@ class GetableResult implements LookupResult {
   NamedBuilder? get setable => null;
 }
 
-class SetableResult implements LookupResult {
+// Coverage-ignore(suite): Not run.
+class SetableResult with LookupResultMixin implements LookupResult {
   @override
   final NamedBuilder setable;
 
@@ -150,7 +265,7 @@ class SetableResult implements LookupResult {
   NamedBuilder? get getable => null;
 }
 
-class GetableSetableResult implements LookupResult {
+class GetableSetableResult with LookupResultMixin implements LookupResult {
   @override
   final NamedBuilder getable;
 
@@ -159,3 +274,32 @@ class GetableSetableResult implements LookupResult {
 
   GetableSetableResult(this.getable, this.setable);
 }
+
+mixin LookupResultMixin implements LookupResult {
+  @override
+  bool get isInvalidLookup =>
+      (getable?.isDuplicate ?? false) || (setable?.isDuplicate ?? false);
+}
+
+class DuplicateMemberLookupResult implements MemberLookupResult {
+  final List<MemberBuilder> declarations;
+
+  DuplicateMemberLookupResult(this.declarations);
+
+  @override
+  MemberBuilder? get getable => null;
+
+  @override
+  bool get isInvalidLookup => true;
+
+  @override
+  MemberBuilder? get setable => null;
+
+  /// Return `true` if this [MemberBuilder]s of this lookup result are accessed
+  /// statically.
+  ///
+  /// Since this lookup can contain both static and non-static members, we
+  /// return `true` so that it will not be filtered in static member lookup.
+  @override
+  bool get isStatic => true;
+}