[cfe] Support arguments in macro applications

Change-Id: I87281598b18443778bdfe8444b455cd80da5155a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240544
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/fasta/kernel/macro/annotation_parser.dart

@@ -2,8 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:_fe_analyzer_shared/src/macros/executor.dart' as macro;
 import 'package:_fe_analyzer_shared/src/messages/codes.dart';
 import 'package:_fe_analyzer_shared/src/parser/parser.dart';
+import 'package:_fe_analyzer_shared/src/parser/quote.dart';
 import 'package:_fe_analyzer_shared/src/scanner/error_token.dart';
 import 'package:_fe_analyzer_shared/src/scanner/token.dart';
 
@@ -15,7 +17,6 @@ import '../../builder/prefix_builder.dart';
 import '../../scope.dart';
 import '../../source/diet_parser.dart';
 import '../../source/source_library_builder.dart';
-
 import 'macro.dart';
 
 List<MacroApplication>? prebuildAnnotations(
@@ -78,7 +79,35 @@ class _NoArgumentsNode implements _Node {
 }
 
 class _ArgumentsNode implements _Node {
-  _ArgumentsNode();
+  final List<Object?> positionalArguments;
+  final Map<String, Object?> namedArguments;
+
+  _ArgumentsNode(this.positionalArguments, this.namedArguments);
+}
+
+class _PrimitiveValueNode implements _Node {
+  final Object? value;
+
+  _PrimitiveValueNode(this.value);
+}
+
+class _TokenNode implements _Node {
+  final Token token;
+
+  _TokenNode(this.token);
+}
+
+class _NamedArgumentIdentifierNode implements _Node {
+  final String name;
+
+  _NamedArgumentIdentifierNode(this.name);
+}
+
+class _NamedArgumentNode implements _Node {
+  final String name;
+  final Object? value;
+
+  _NamedArgumentNode(this.name, this.value);
 }
 
 class _MacroListener implements Listener {
@@ -154,8 +183,11 @@ class _MacroListener implements Listener {
       if (macroClass != null &&
           constructorName != null &&
           argumentsNode is _ArgumentsNode) {
-        push(new _MacroApplicationNode(
-            new MacroApplication(macroClass, constructorName)));
+        push(new _MacroApplicationNode(new MacroApplication(
+            macroClass,
+            constructorName,
+            new macro.Arguments(argumentsNode.positionalArguments,
+                argumentsNode.namedArguments))));
         return;
       }
     }
@@ -211,6 +243,9 @@ class _MacroListener implements Listener {
           pushUnsupported();
         }
         break;
+      case IdentifierContext.namedArgumentReference:
+        push(new _NamedArgumentIdentifierNode(token.lexeme));
+        break;
       default:
         pushUnsupported();
         break;
@@ -224,11 +259,27 @@ class _MacroListener implements Listener {
 
   @override
   void endArguments(int count, Token beginToken, Token endToken) {
-    if (count == 0) {
-      push(new _ArgumentsNode());
-    } else {
-      // TODO(johnniwinther): Handle arguments.
+    if (unrecognized) {
+      pushUnsupported();
+      return;
+    }
+    List<Object?> positionalArguments = [];
+    Map<String, Object?> namedArguments = {};
+    for (int i = 0; i < count; i++) {
+      _Node node = pop();
+      if (node is _PrimitiveValueNode) {
+        positionalArguments.add(node.value);
+      } else if (node is _NamedArgumentNode &&
+          !namedArguments.containsKey(node.name)) {
+        namedArguments[node.name] = node.value;
+      } else {
+        _unsupported();
+      }
+    }
+    if (unrecognized) {
       pushUnsupported();
+    } else {
+      push(new _ArgumentsNode(positionalArguments, namedArguments));
     }
   }
 
@@ -248,6 +299,99 @@ class _MacroListener implements Listener {
     // context.
   }
 
+  @override
+  void handleNamedArgument(Token colon) {
+    if (unrecognized) {
+      pushUnsupported();
+    } else {
+      _Node value = pop();
+      _Node name = pop();
+      if (name is _NamedArgumentIdentifierNode &&
+          value is _PrimitiveValueNode) {
+        push(new _NamedArgumentNode(name.name, value.value));
+      } else {
+        pushUnsupported();
+      }
+    }
+  }
+
+  @override
+  void handleLiteralNull(Token token) {
+    push(new _PrimitiveValueNode(null));
+  }
+
+  @override
+  void handleLiteralBool(Token token) {
+    push(new _PrimitiveValueNode(token.lexeme == 'true'));
+  }
+
+  @override
+  void handleLiteralDouble(Token token) {
+    push(new _PrimitiveValueNode(double.parse(token.lexeme)));
+  }
+
+  @override
+  void handleLiteralInt(Token token) {
+    push(new _PrimitiveValueNode(int.parse(token.lexeme)));
+  }
+
+  @override
+  void beginLiteralString(Token token) {
+    push(new _TokenNode(token));
+  }
+
+  @override
+  void endLiteralString(int interpolationCount, Token endToken) {
+    if (unrecognized) {
+      pushUnsupported();
+      return;
+    }
+    if (interpolationCount == 0) {
+      _Node node = pop();
+      if (node is _TokenNode) {
+        String text = unescapeString(node.token.lexeme, node.token, this);
+        if (unrecognized) {
+          pushUnsupported();
+        } else {
+          push(new _PrimitiveValueNode(text));
+        }
+      } else {
+        pushUnsupported();
+      }
+    } else {
+      // TODO(johnniwinther): Should we support this?
+      pushUnsupported();
+    }
+  }
+
+  @override
+  void handleStringPart(Token token) {
+    // TODO(johnniwinther): Should we support this?
+    _unhandled();
+  }
+
+  @override
+  void handleStringJuxtaposition(Token startToken, int literalCount) {
+    if (unrecognized) {
+      pushUnsupported();
+    } else {
+      List<String> values = [];
+      for (int i = 0; i < literalCount; i++) {
+        _Node node = pop();
+        if (node is _PrimitiveValueNode && node.value is String) {
+          values.add(node.value as String);
+        } else {
+          _unsupported();
+        }
+      }
+      if (unrecognized) {
+        pushUnsupported();
+      } else {
+        push(new _PrimitiveValueNode(values.reversed.join()));
+      }
+    }
+  }
+
   //////////////////////////////////////////////////////////////////////////////
   // Stub implementation
   //////////////////////////////////////////////////////////////////////////////
@@ -552,11 +696,6 @@ class _MacroListener implements Listener {
     _unexpected();
   }
 
-  @override
-  void beginLiteralString(Token token) {
-    _unhandled();
-  }
-
   @override
   void beginLiteralSymbol(Token token) {
     _unhandled();
@@ -1125,11 +1264,6 @@ class _MacroListener implements Listener {
     _unexpected();
   }
 
-  @override
-  void endLiteralString(int interpolationCount, Token endToken) {
-    _unhandled();
-  }
-
   @override
   void endLiteralSymbol(Token hashToken, int identifierCount) {
     _unhandled();
@@ -1636,21 +1770,6 @@ class _MacroListener implements Listener {
     _unsupported();
   }
 
-  @override
-  void handleLiteralBool(Token token) {
-    _unhandled();
-  }
-
-  @override
-  void handleLiteralDouble(Token token) {
-    _unhandled();
-  }
-
-  @override
-  void handleLiteralInt(Token token) {
-    _unhandled();
-  }
-
   @override
   void handleLiteralList(
       int count, Token leftBracket, Token? constKeyword, Token rightBracket) {
@@ -1662,11 +1781,6 @@ class _MacroListener implements Listener {
     _unhandled();
   }
 
-  @override
-  void handleLiteralNull(Token token) {
-    _unhandled();
-  }
-
   @override
   void handleLiteralSetOrMap(int count, Token leftBrace, Token? constKeyword,
       Token rightBrace, bool hasSetEntry) {
@@ -1683,11 +1797,6 @@ class _MacroListener implements Listener {
     _unexpected();
   }
 
-  @override
-  void handleNamedArgument(Token colon) {
-    _unhandled();
-  }
-
   @override
   void handleNamedMixinApplicationWithClause(Token withKeyword) {
     _unexpected();
@@ -1839,16 +1948,6 @@ class _MacroListener implements Listener {
     _unsupported();
   }
 
-  @override
-  void handleStringJuxtaposition(Token startToken, int literalCount) {
-    _unhandled();
-  }
-
-  @override
-  void handleStringPart(Token token) {
-    _unhandled();
-  }
-
   @override
   void handleSuperExpression(Token token, IdentifierContext context) {
     _unsupported();

pkg/front_end/lib/src/fasta/kernel/macro/macro.dart

@@ -65,10 +65,11 @@ class MacroDeclarationData {
 class MacroApplication {
   final ClassBuilder classBuilder;
   final String constructorName;
+  final macro.Arguments arguments;
 
   // TODO(johnniwinther): Add support for arguments.
 
-  MacroApplication(this.classBuilder, this.constructorName);
+  MacroApplication(this.classBuilder, this.constructorName, this.arguments);
 
   late macro.MacroInstanceIdentifier instanceIdentifier;
 
@@ -152,8 +153,7 @@ class MacroApplications {
                       libraryUri,
                       macroClassName,
                       application.constructorName,
-                      // TODO(johnniwinther): Support macro arguments.
-                      new macro.Arguments([], {}));
+                      application.arguments);
               benchmarker?.endSubdivide();
             } catch (e) {
               throw "Error instantiating macro `${application}`: $e";

pkg/front_end/test/macros/declaration/data/pkgs/macro/lib/macro.dart

@@ -25,3 +25,10 @@ macro class Macro3<T> implements Macro {
 class NonMacro {
   const NonMacro();
 }
+
+macro class Macro4 implements Macro {
+  final field;
+  final named;
+
+  const Macro4(this.field, {this.named});
+}

pkg/front_end/test/macros/declaration/data/tests/all_precompiled.dart

@@ -10,6 +10,6 @@
 
 import 'package:precompiled_macro/precompiled_macro.dart';
 
-/*member: main:appliedMacros=[PrecompiledMacro.new]*/
+/*member: main:appliedMacros=[PrecompiledMacro.new()]*/
 @PrecompiledMacro()
 void main() {}