Skip to content

Commit f5b5e3f

Browse files
devoncarewCommit Queue
authored andcommitted
Revert "[deps] remove dart-lang/intl from DEPS"
This reverts commit 5719dea. Reason for revert: golem benchmarks use intl Original change's description: > [deps] remove dart-lang/intl from DEPS > > Change-Id: Id0ddbfecfd9097da0aca067775bf319a615f9b91 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409543 > Commit-Queue: Devon Carew <[email protected]> > Reviewed-by: Morgan :) <[email protected]> Change-Id: I5551364bd7ce8930c20708a3a52688033067bb3c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409761 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Stephen Adams <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
1 parent 810af11 commit f5b5e3f

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

DEPS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ vars = {
136136
"flute_rev": "e4ea0459a7debae5e9592c85141707b01fac86c9",
137137
"glob_rev": "043796be996190473b397fa2fecfa34bb91376fb",
138138
"http_rev": "b7cdf6136926589210662bbdd71000e7abab7271",
139+
"intl_rev": "5d65e3808ce40e6282e40881492607df4e35669f",
139140
"leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # manually rolled
140141
"markdown_rev": "62f78c64d963ba6f73bd70ed65630dc934a264e6",
141142
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
@@ -352,6 +353,8 @@ deps = {
352353

353354
Var("dart_root") + "/third_party/pkg/http":
354355
Var("dart_git") + "http.git" + "@" + Var("http_rev"),
356+
Var("dart_root") + "/third_party/pkg/intl":
357+
Var("dart_git") + "intl.git" + "@" + Var("intl_rev"),
355358
Var("dart_root") + "/third_party/pkg/leak_tracker":
356359
Var("dart_git") + "leak_tracker.git" + "@" + Var("leak_tracker_rev"),
357360
Var("dart_root") + "/third_party/pkg/markdown":

pkg/bisect_dart/lib/src/bisection_config.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import 'dart:io';
66

77
import 'package:cli_config/cli_config.dart';
8+
import 'package:intl/intl.dart';
89

910
class BisectionConfig {
1011
/// A way to identify this bisection.
@@ -63,7 +64,7 @@ class BisectionConfig {
6364
factory BisectionConfig.fromConfig(Config config) {
6465
final testCommands = config.stringList(_testCommandsKey);
6566
final name = config.optionalString(_nameKey) ??
66-
'${yyyyMMdd(DateTime.now())}_'
67+
'${DateFormat('yyyyMMdd').format(DateTime.now())}_'
6768
'${testCommands.last.split(' ').last.split('/').last}';
6869
final sdkPath = config.optionalPath(_sdkPathKey, mustExist: true) ??
6970
Directory.current.uri;
@@ -160,10 +161,3 @@ $descriptions
160161
extension on String {
161162
RegExp toPattern() => RegExp(RegExp.escape(this));
162163
}
163-
164-
String yyyyMMdd(DateTime date) {
165-
// DateFormat('yyyyMMdd').format(date)
166-
return zeroPad(date.year, 4) + zeroPad(date.month, 2) + zeroPad(date.day, 2);
167-
}
168-
169-
String zeroPad(int number, int width) => number.toString().padLeft(width, '0');

pkg/bisect_dart/pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ environment:
77

88
dependencies:
99
cli_config: any
10+
intl: any
1011
logging: any
1112

1213
dev_dependencies:

0 commit comments

Comments
 (0)