[analyzer] Remove deprecated class BaseDeprecatedMemberUseVerifier.

This class was left in
https://dart-review.googlesource.com/c/sdk/+/450263 as a temporary
measure since it was used in internal Google sources. Now that those
internal sources have been migrated to use `MemberUseVerifier`
instead, it is no longer needed.

Removing it also allows the class `_TransitionalMemberUseReporter` to
be removed, as well as the `element` parameter of
`MemberUseReporter.report`.

Change-Id: I6a6a69644965549c879e4d25f75e0db7c97af090
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450362
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart

@@ -5,7 +5,6 @@
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/listener.dart';
-import 'package:analyzer/src/dart/ast/ast.dart';
 import 'package:analyzer/src/dart/error/hint_codes.dart';
 import 'package:analyzer/src/error/element_usage_detector.dart';
 
@@ -29,59 +28,6 @@ String? normalizeDeprecationMessage(String message) {
   }
 }
 
-/// Legacy class used in a custom google3 lint for detecting certain deprecated
-/// elements.
-///
-// TODO(paulberry): rewrite the google3 lint using `ElementUsageDetector` and
-// then remove this class.
-@Deprecated('Use ElementUsageDetector instead')
-abstract class BaseDeprecatedMemberUseVerifier {
-  late final ElementUsageDetector<String> _elementUsageDetector =
-      ElementUsageDetector(
-        workspacePackage: null,
-        elementUsageSet: const DeprecatedElementUsageSet(),
-        elementUsageReporter:
-            _TransitionalElementUseReporter._TransitionalElementUsageReporter(
-              this,
-            ),
-      );
-
-  void constructorName(ConstructorName node) {
-    _elementUsageDetector.constructorName(node);
-  }
-
-  void functionExpressionInvocation(FunctionExpressionInvocation node) {
-    _elementUsageDetector.functionExpressionInvocation(node);
-  }
-
-  void instanceCreationExpression(InstanceCreationExpression node) {
-    _elementUsageDetector.instanceCreationExpression(node);
-  }
-
-  void methodInvocation(MethodInvocation node) {
-    _elementUsageDetector.methodInvocation(node);
-  }
-
-  void namedType(NamedType node) {
-    _elementUsageDetector.namedType(node);
-  }
-
-  void redirectingConstructorInvocation(RedirectingConstructorInvocation node) {
-    _elementUsageDetector.redirectingConstructorInvocation(node);
-  }
-
-  void reportError(
-    SyntacticEntity errorEntity,
-    Element element,
-    String displayName,
-    String? message,
-  );
-
-  void simpleIdentifier(SimpleIdentifier node) {
-    _elementUsageDetector.simpleIdentifier(node);
-  }
-}
-
 /// Instance of [ElementUsageReporter] for reporting uses of deprecated
 /// elements.
 class DeprecatedElementUsageReporter implements ElementUsageReporter<String> {
@@ -97,7 +43,6 @@ class DeprecatedElementUsageReporter implements ElementUsageReporter<String> {
     String displayName,
     String tagInfo, {
     required bool isInSamePackage,
-    required Element element,
   }) {
     if (normalizeDeprecationMessage(tagInfo) case var message?) {
       _diagnosticReporter.atEntity(
@@ -151,27 +96,3 @@ class DeprecatedElementUsageSet implements ElementUsageSet<String> {
     return null;
   }
 }
-
-/// Auxiliary class used by [BaseDeprecatedMemberUseVerifier].
-///
-// TODO(paulberry): remove this class when removing
-// `BaseDeprecatedMemberUseVerifier`.
-@Deprecated('Will be removed along with BaseDeprecatedMemberUseVerifier')
-class _TransitionalElementUseReporter implements ElementUsageReporter<String> {
-  final BaseDeprecatedMemberUseVerifier _verifier;
-
-  _TransitionalElementUseReporter._TransitionalElementUsageReporter(
-    this._verifier,
-  );
-
-  @override
-  void report(
-    SyntacticEntity usageSite,
-    String displayName,
-    String? tagInfo, {
-    required bool isInSamePackage,
-    required Element element,
-  }) {
-    _verifier.reportError(usageSite, element, displayName, tagInfo);
-  }
-}

pkg/analyzer/lib/src/error/element_usage_detector.dart

@@ -118,7 +118,6 @@ class ElementUsageDetector<TagInfo extends Object> {
       displayName,
       tagInfo,
       isInSamePackage: _isLibraryInWorkspacePackage(element.library),
-      element: element,
     );
   }
 
@@ -322,15 +321,12 @@ abstract class ElementUsageReporter<TagInfo extends Object> {
   /// [displayName] is the name of the element that was used. [tagInfo] is the
   /// tag information returned by [ElementUsageSet.getTagInfo].
   /// [isInSamePackage] indicates whether the element and its usage are in
-  /// the same package. [element] is the element whose usage was detected.
+  /// the same package.
   void report(
     SyntacticEntity usageSite,
     String displayName,
     TagInfo tagInfo, {
     required bool isInSamePackage,
-    // Note: `element` exists as a temporary measure for g3 migration.
-    // TODO(paulberry): remove this parameter when it's no longer needed.
-    required Element element,
   });
 }
 

pkg/linter/lib/src/rules/deprecated_member_use_from_same_package.dart

@@ -63,7 +63,6 @@ class _DeprecatedElementUsageReporter extends ElementUsageReporter<String> {
     String displayName,
     String tagInfo, {
     required bool isInSamePackage,
-    required Element element,
   }) {
     if (!isInSamePackage) {
       // In this case, `DEPRECATED_MEMBER_USE` is reported by the analyzer.