[analyzer] Use type names from messages.yaml when documenting diagnostic params.

Changes the code generator for analyzer diagnostic messages so that
when generating documentation for diagnostic message parameters, it
uses the shared type names (those used in `messages.yaml`) rather than
the analyzer-specific ones.

In practice the only difference right now is that `Type` will be used
instead of `DartType`.

This paves the way for future CLs which will unify some of the
analyzer and front_end logic for generating code from the
`messages.yaml` files. Once that code is unified, there will be
diagnostic messages with parameter types that the analyzer doesn't yet
support. This change ensures that it will still be able to generate
documentation for those messages.

Change-Id: I6a6a696471f530aa1f8ddb6f8f73beba6a0c70b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448229
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/dart/error/ffi_code.g.dart

@@ -349,7 +349,7 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
       );
 
   /// Parameters:
-  /// DartType p0: the type that is missing a native type annotation
+  /// Type p0: the type that is missing a native type annotation
   /// String p1: the superclass which is extended by this field's class
   static const FfiTemplate<
     LocatableDiagnostic Function({required DartType p0, required String p1})
@@ -420,8 +420,8 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
   );
 
   /// Parameters:
-  /// DartType p0: the type that should be a subtype
-  /// DartType p1: the supertype that the subtype is compared to
+  /// Type p0: the type that should be a subtype
+  /// Type p1: the supertype that the subtype is compared to
   /// String p2: the name of the function whose invocation depends on this
   ///            relationship
   static const FfiTemplate<
@@ -441,7 +441,7 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
   );
 
   /// Parameters:
-  /// DartType p0: the return type that should be 'void'.
+  /// Type p0: the return type that should be 'void'.
   static const FfiTemplate<LocatableDiagnostic Function({required DartType p0})>
   mustReturnVoid = FfiTemplate(
     'MUST_RETURN_VOID',
@@ -454,7 +454,7 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
   );
 
   /// Parameters:
-  /// DartType p0: The invalid type.
+  /// Type p0: The invalid type.
   static const FfiTemplate<LocatableDiagnostic Function({required DartType p0})>
   nativeFieldInvalidType = FfiTemplate(
     'NATIVE_FIELD_INVALID_TYPE',
@@ -527,7 +527,7 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
   );
 
   /// Parameters:
-  /// DartType p0: the type that should be a valid dart:ffi native type.
+  /// Type p0: the type that should be a valid dart:ffi native type.
   static const FfiTemplate<LocatableDiagnostic Function({required DartType p0})>
   nonNativeFunctionTypeArgumentToPointer = FfiTemplate(
     'NON_NATIVE_FUNCTION_TYPE_ARGUMENT_TO_POINTER',
@@ -553,7 +553,7 @@ class FfiCode extends DiagnosticCodeWithExpectedTypes {
 
   /// Parameters:
   /// String p0: the name of the field
-  /// DartType p1: the type of the field
+  /// Type p1: the type of the field
   static const FfiTemplate<
     LocatableDiagnostic Function({required String p0, required DartType p1})
   >