[analysis_server] Remove unused empty arrays from generated Java code

These aren't used by the IntelliJ plugins, outside of one usage that can  be removed.

Change-Id: I7827481a9e1d4d4e513e8e659ccc03c2bd3d9eae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397141
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: parlough

pkg/analysis_server/tool/spec/codegen_java_types.dart

@@ -311,14 +311,6 @@ class CodegenJavaType extends CodegenJavaVisitor {
       //
       // fields
       //
-      //
-      // public static final "EMPTY_ARRAY" field
-      //
-      publicField(javaName('EMPTY_ARRAY'), () {
-        writeln(
-          'public static final $className[] EMPTY_ARRAY = new $className[0];',
-        );
-      });
 
       //
       // public static final "EMPTY_LIST" field

pkg/analysis_server/tool/spec/generated/java/types/AddContentOverlay.java

@@ -32,8 +32,6 @@
 @SuppressWarnings("unused")
 public class AddContentOverlay {
 
-  public static final AddContentOverlay[] EMPTY_ARRAY = new AddContentOverlay[0];
-
   public static final List<AddContentOverlay> EMPTY_LIST = List.of();
 
   private final String type;

pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java

@@ -28,8 +28,6 @@
 @SuppressWarnings("unused")
 public class AnalysisError {
 
-  public static final AnalysisError[] EMPTY_ARRAY = new AnalysisError[0];
-
   public static final List<AnalysisError> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/AnalysisErrorFixes.java

@@ -28,8 +28,6 @@
 @SuppressWarnings("unused")
 public class AnalysisErrorFixes {
 
-  public static final AnalysisErrorFixes[] EMPTY_ARRAY = new AnalysisErrorFixes[0];
-
   public static final List<AnalysisErrorFixes> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/AnalysisOptions.java

@@ -31,8 +31,6 @@
 @SuppressWarnings("unused")
 public class AnalysisOptions {
 
-  public static final AnalysisOptions[] EMPTY_ARRAY = new AnalysisOptions[0];
-
   public static final List<AnalysisOptions> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/AnalysisStatus.java

@@ -28,8 +28,6 @@
 @SuppressWarnings("unused")
 public class AnalysisStatus {
 
-  public static final AnalysisStatus[] EMPTY_ARRAY = new AnalysisStatus[0];
-
   public static final List<AnalysisStatus> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/BulkFix.java

@@ -28,8 +28,6 @@
 @SuppressWarnings("unused")
 public class BulkFix {
 
-  public static final BulkFix[] EMPTY_ARRAY = new BulkFix[0];
-
   public static final List<BulkFix> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/BulkFixDetail.java

@@ -28,8 +28,6 @@
 @SuppressWarnings("unused")
 public class BulkFixDetail {
 
-  public static final BulkFixDetail[] EMPTY_ARRAY = new BulkFixDetail[0];
-
   public static final List<BulkFixDetail> EMPTY_LIST = List.of();
 
   /**

pkg/analysis_server/tool/spec/generated/java/types/ChangeContentOverlay.java

@@ -38,8 +38,6 @@
 @SuppressWarnings("unused")
 public class ChangeContentOverlay {
 
-  public static final ChangeContentOverlay[] EMPTY_ARRAY = new ChangeContentOverlay[0];
-
   public static final List<ChangeContentOverlay> EMPTY_LIST = List.of();
 
   private final String type;

pkg/analysis_server/tool/spec/generated/java/types/ClosingLabel.java

@@ -31,8 +31,6 @@
 @SuppressWarnings("unused")
 public class ClosingLabel {
 
-  public static final ClosingLabel[] EMPTY_ARRAY = new ClosingLabel[0];
-
   public static final List<ClosingLabel> EMPTY_LIST = List.of();
 
   /**