[element model] migrate prefer_is_not_empty

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Iabb9ddb952f5a111b9df290705bad5f0b26c9c75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390627
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -127,6 +127,7 @@ lib/src/rules/prefer_if_null_operators.dart
 lib/src/rules/prefer_inlined_adds.dart
 lib/src/rules/prefer_interpolation_to_compose_strings.dart
 lib/src/rules/prefer_is_empty.dart
+lib/src/rules/prefer_is_not_empty.dart
 lib/src/rules/prefer_is_not_operator.dart
 lib/src/rules/prefer_iterable_whereType.dart
 lib/src/rules/prefer_mixin.dart

pkg/linter/lib/src/ast.dart

@@ -9,7 +9,9 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/visitor.dart';
+import 'package:analyzer/dart/element/visitor2.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/lint/linter.dart'; // ignore: implementation_imports
 import 'package:analyzer/src/workspace/workspace.dart'; // ignore: implementation_imports
@@ -32,6 +34,18 @@ List<Element> getChildren(Element parent, [String? name]) {
   return children;
 }
 
+/// Returns direct children of [parent].
+List<Element2> getChildren2(Element2 parent, [String? name]) {
+  var children = <Element2>[];
+  visitChildren2(parent, (Element2 element) {
+    if (name == null || element.displayName == name) {
+      children.add(element);
+    }
+    return false;
+  });
+  return children;
+}
+
 /// Return the compilation unit of a node
 CompilationUnit? getCompilationUnit(AstNode node) =>
     node.thisOrAncestorOfType<CompilationUnit>();
@@ -307,6 +321,12 @@ void visitChildren(Element element, ElementProcessor processor) {
   element.visitChildren(_ElementVisitorAdapter(processor));
 }
 
+/// Uses [processor] to visit all of the children of [element].
+/// If [processor] returns `true`, then children of a child are visited too.
+void visitChildren2(Element2 element, ElementProcessor2 processor) {
+  element.visitChildren2(_ElementVisitorAdapter2(processor));
+}
+
 bool _checkForSimpleGetter(MethodDeclaration getter, Expression? expression) {
   if (expression is SimpleIdentifier) {
     var staticElement = expression.staticElement;
@@ -418,6 +438,10 @@ bool _hasFieldOrMethod(ClassMember element, String name) =>
 /// If `true` is returned, children of [element] will be visited.
 typedef ElementProcessor = bool Function(Element element);
 
+/// An [Element] processor function type.
+/// If `true` is returned, children of [element] will be visited.
+typedef ElementProcessor2 = bool Function(Element2 element);
+
 /// A [GeneralizingElementVisitor] adapter for [ElementProcessor].
 class _ElementVisitorAdapter extends GeneralizingElementVisitor<void> {
   final ElementProcessor processor;
@@ -433,6 +457,21 @@ class _ElementVisitorAdapter extends GeneralizingElementVisitor<void> {
   }
 }
 
+/// A [GeneralizingElementVisitor] adapter for [ElementProcessor].
+class _ElementVisitorAdapter2 extends GeneralizingElementVisitor2<void> {
+  final ElementProcessor2 processor;
+
+  _ElementVisitorAdapter2(this.processor);
+
+  @override
+  void visitElement(Element2 element) {
+    var visitChildren = processor(element);
+    if (visitChildren) {
+      element.visitChildren2(this);
+    }
+  }
+}
+
 extension AstNodeExtension on AstNode {
   bool get isToStringInvocationWithArguments {
     var self = this;

pkg/linter/lib/src/rules/prefer_is_not_empty.dart

@@ -57,15 +57,15 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     // Element identifier should be "isEmpty".
-    var propertyElement = isEmptyIdentifier.staticElement;
+    var propertyElement = isEmptyIdentifier.element;
     if (propertyElement == null || 'isEmpty' != propertyElement.name) {
       return;
     }
 
     // Element should also support "isNotEmpty".
-    var propertyTarget = propertyElement.enclosingElement3;
+    var propertyTarget = propertyElement.enclosingElement2;
     if (propertyTarget == null ||
-        getChildren(propertyTarget, 'isNotEmpty').isEmpty) {
+        getChildren2(propertyTarget, 'isNotEmpty').isEmpty) {
       return;
     }