[DAS] Fixes rename FieldFormalParameter outside library

Fixes: #60182
Change-Id: Ic833f07f2158bedcd196e06a7feebc761109fdef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413380
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart

@@ -110,7 +110,7 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {
               for (var parameter in constructor.formalParameters) {
                 if (parameter is FieldFormalParameterElement2 &&
                     parameter.field2 == renameElement) {
-                  await workspace.searchEngine
+                  await searchEngine
                       .searchReferences(parameter)
                       .then(processor.addReferenceEdits);
                 }

pkg/analysis_server/test/services/refactoring/legacy/rename_class_member_test.dart

@@ -1239,6 +1239,101 @@ class A<NewName> {
   A(this.field);
   NewName method(NewName p) => field;
 }
+''');
+  }
+
+  Future<void> test_subclass_namedSuper_otherLibrary() async {
+    await indexTestUnit('''
+class Base {
+  final int foo;
+
+  Base({required this.foo});
+}
+''');
+    await indexUnit('$testPackageLibPath/sub1.dart', r'''
+import 'test.dart';
+
+class Sub1 extends Base {
+  Sub1({required super.foo});
+}
+''');
+    await indexUnit('$testPackageLibPath/sub2.dart', r'''
+import 'test.dart';
+
+class Sub2 extends Base {
+  @override
+  int get foo => 0;
+
+  Sub2({required super.foo});
+}
+''');
+    createRenameRefactoringAtString('foo;');
+    // check status
+    refactoring.newName = 'bar';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+    refactoringChange = await refactoring.createChange();
+    assertFileChangeResult('$testPackageLibPath/sub2.dart', '''
+import 'test.dart';
+
+class Sub2 extends Base {
+  @override
+  int get bar => 0;
+
+  Sub2({required super.bar});
+}
+''');
+    assertFileChangeResult('$testPackageLibPath/sub1.dart', '''
+import 'test.dart';
+
+class Sub1 extends Base {
+  Sub1({required super.bar});
+}
+''');
+  }
+
+  Future<void> test_subclass_namedSuper_sameLibrary() async {
+    await indexTestUnit('''
+class Base {
+  final int foo;
+
+  Base({required this.foo});
+}
+
+class Sub1 extends Base {
+  Sub1({required super.foo});
+}
+
+class Sub2 extends Base {
+  @override
+  int get foo => 0;
+
+  Sub2({required super.foo});
+}
+''');
+    createRenameRefactoringAtString('foo;');
+    // check status
+    refactoring.newName = 'bar';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+    refactoringChange = await refactoring.createChange();
+    assertTestChangeResult('''
+class Base {
+  final int bar;
+
+  Base({required this.bar});
+}
+
+class Sub1 extends Base {
+  Sub1({required super.bar});
+}
+
+class Sub2 extends Base {
+  @override
+  int get bar => 0;
+
+  Sub2({required super.bar});
+}
 ''');
   }
 }

pkg/analyzer/lib/src/dart/analysis/search.dart

@@ -587,8 +587,12 @@ class Search {
       {List<FileState>? filesToCheck}) async {
     // Prepare the element name.
     String name = element.displayName;
-    if (element is ConstructorElement2) {
-      name = element.enclosingElement2.displayName;
+    var externalElement = element;
+    if (externalElement case FormalParameterElement(:var enclosingElement2?)) {
+      externalElement = enclosingElement2;
+    }
+    if (externalElement is ConstructorElement2) {
+      name = externalElement.enclosingElement2.displayName;
     }
 
     var elementPath = element.firstFragment.libraryFragment!.source.fullName;

pkg/analyzer/test/src/dart/analysis/search_test.dart

@@ -1311,6 +1311,30 @@ enum E {
 ''');
   }
 
+  test_searchReferences_constructorField_outsideFile() async {
+    // Create an external file with a class that has a constructor field.
+    newFile('$testPackageLibPath/other.dart', r'''
+import 'test.dart';
+
+class B extends A {
+  B({super.x});
+}
+''');
+    // Resolve test code that imports the external file and references the field.
+    await resolveTestCode(r'''
+class A {
+  int? x;
+  A({this.x});
+}
+''');
+    // Look up field 'x' and assert that its reference is correctly found.
+    var field = findElement2.fieldFormalParameter('x');
+    await assertElementReferencesText(field, r'''
+package:test/other.dart::<fragment>::@class::B::@constructor::new::@parameter::x
+  52 4:12 |x| REFERENCE qualified
+''');
+  }
+
   test_searchReferences_ExtensionElement() async {
     await resolveTestCode('''
 extension E on int {