[messages] Stop generating lint_codes.g.dart.

All the code that remained in this file was hand-authored and inserted
into the generated file using triple-quoted strings in the code
generator.

Moving the code into a handwritten file will make it easier to
maintain in the future.

Change-Id: I6a6a696404276223981416db38785a50a2cbde09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464625
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer_utilities/lib/analyzer_messages.dart

@@ -93,8 +93,6 @@ transform set.
   ),
 ];
 
-const String generatedLintCodesPath = 'linter/lib/src/lint_codes.g.dart';
-
 /// Base diagnostic classes used for lint messages.
 const linterBaseClasses = DiagnosticBaseClasses(
   requiresTypeArgument: false,

pkg/linter/lib/src/lint_codes.dart

@@ -4,4 +4,51 @@
 
 import 'analyzer.dart';
 
-part 'lint_codes.g.dart';
+class LinterLintCode extends LintCodeWithExpectedTypes {
+  const LinterLintCode({
+    required super.name,
+    required super.problemMessage,
+    required super.uniqueName,
+    super.expectedTypes,
+    super.correctionMessage,
+    super.hasPublishedDocs,
+  });
+
+  @override
+  String get url {
+    if (hasPublishedDocs) {
+      return 'https://dart.dev/diagnostics/$name';
+    }
+    return 'https://dart.dev/lints/$name';
+  }
+}
+
+final class LinterLintTemplate<T extends Function> extends LinterLintCode
+    implements DiagnosticWithArguments<T> {
+  @override
+  final T withArguments;
+
+  /// Initialize a newly created error code to have the given [name].
+  const LinterLintTemplate({
+    required super.name,
+    required super.problemMessage,
+    required this.withArguments,
+    required super.expectedTypes,
+    required super.uniqueName,
+    super.correctionMessage,
+    super.hasPublishedDocs = false,
+  });
+}
+
+final class LinterLintWithoutArguments extends LinterLintCode
+    with DiagnosticWithoutArguments {
+  /// Initialize a newly created error code to have the given [name].
+  const LinterLintWithoutArguments({
+    required super.name,
+    required super.problemMessage,
+    required super.expectedTypes,
+    required super.uniqueName,
+    super.correctionMessage,
+    super.hasPublishedDocs = false,
+  });
+}

pkg/linter/lib/src/lint_codes.g.dart

@@ -20,16 +20,5 @@ void main() {
             "Run 'dart run pkg/linter/tool/generate_lints.dart' to update.",
       );
     });
-
-    test('ensure lint codes are up to date', () async {
-      expect(
-        await generatedCodesFile.check(pkg_root.packageRoot),
-        isTrue,
-        reason:
-            "The generated lint codes at 'lib/src/lint_codes.g.dart' need "
-            'to be regenerated. '
-            "Run 'dart run pkg/linter/tool/generate_lints.dart' to update.",
-      );
-    });
   });
 }

pkg/linter/test/verify_generated_files_test.dart

@@ -7,105 +7,18 @@
 library;
 
 import 'package:analyzer_testing/package_root.dart' as pkg_root;
-import 'package:analyzer_utilities/analyzer_messages.dart';
 import 'package:analyzer_utilities/tools.dart';
 
 import 'messages_info.dart';
 
 void main() async {
   await GeneratedContent.generateAll(pkg_root.packageRoot, [
     generatedNamesFile,
-    generatedCodesFile,
   ]);
 }
 
 const String generatedNamesPath = 'linter/lib/src/lint_names.g.dart';
 
-GeneratedFile get generatedCodesFile =>
-    GeneratedFile(generatedLintCodesPath, (pkgRoot) async {
-      var out = StringBuffer('''
-// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-// THIS FILE IS GENERATED. DO NOT EDIT.
-//
-// Instead modify 'pkg/linter/messages.yaml' and run
-// 'dart run pkg/linter/tool/generate_lints.dart' to update.
-
-// Generated comments don't quite align with flutter style.
-// ignore_for_file: flutter_style_todos
-
-// Generator currently outputs double quotes for simplicity.
-// ignore_for_file: prefer_single_quotes
-
-// Generated `withArguments` methods always use block bodies for simplicity.
-// ignore_for_file: prefer_expression_function_bodies
-
-part of 'lint_codes.dart';
-
-class LinterLintCode extends LintCodeWithExpectedTypes {
-''');
-      var memberAccumulator = MemberAccumulator();
-
-      memberAccumulator.constructors[''] = '''
-  const LinterLintCode({
-    required super.name,
-    required super.problemMessage,
-    required super.uniqueName,
-    super.expectedTypes,
-    super.correctionMessage,
-    super.hasPublishedDocs,
-  });
-''';
-
-      memberAccumulator.accessors['url'] = '''
-  @override
-  String get url {
-    if (hasPublishedDocs) {
-      return 'https://dart.dev/diagnostics/\$name';
-    }
-    return 'https://dart.dev/lints/\$name';
-  }
-''';
-      memberAccumulator.writeTo(out);
-      out.writeln('}');
-
-      out.write('''
-
-final class LinterLintTemplate<T extends Function> extends LinterLintCode
-    implements DiagnosticWithArguments<T> {
-  @override
-  final T withArguments;
-
-  /// Initialize a newly created error code to have the given [name].
-  const LinterLintTemplate({
-    required super.name,
-    required super.problemMessage,
-    required this.withArguments,
-    required super.expectedTypes,
-    required super.uniqueName,
-    super.correctionMessage,
-    super.hasPublishedDocs = false,
-  });
-}
-
-final class LinterLintWithoutArguments extends LinterLintCode
-    with DiagnosticWithoutArguments {
-  /// Initialize a newly created error code to have the given [name].
-  const LinterLintWithoutArguments({
-    required super.name,
-    required super.problemMessage,
-    required super.expectedTypes,
-    required super.uniqueName,
-    super.correctionMessage,
-    super.hasPublishedDocs = false,
-  });
-}
-''');
-      return out.toString();
-    });
-
 GeneratedFile get generatedNamesFile =>
     GeneratedFile(generatedNamesPath, (pkgRoot) async {
       var out = StringBuffer('''