Skip to content

Commit fa4d761

Browse files
srujzsCommit Queue
authored andcommitted
[ddc] Align error message with VM when reload is rejected
https://github.com/flutter/flutter/blob/f3d0f5a2ca422b1d8cbfc1c4d67ae288ce22ee47/packages/flutter_tools/lib/src/run_hot.dart#L1669 The above is emitted when a reload is rejected at runtime in the VM. Since we reject errors at compile-time, we should align the error messages. Change-Id: I6687d3efaf87d1dce1c7d21591039cbb5a447ff1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413543 Commit-Queue: Johnni Winther <[email protected]> Reviewed-by: Johnni Winther <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Auto-Submit: Srujan Gaddam <[email protected]>
1 parent 33286f9 commit fa4d761

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/dev_compiler/lib/src/command/command.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ Future<CompilerResult> _compile(List<String> args,
369369
if (rejectionReasons.isNotEmpty) {
370370
throw StateError(
371371
'Hot reload rejected due to:\n${rejectionReasons.join('\n')}\n'
372-
'Use hot restart instead.');
372+
'Try performing a hot restart instead.');
373373
}
374374
}
375375
var sink = File(reloadDeltaKernel).openWrite();

pkg/frontend_server/lib/src/javascript_bundle.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class IncrementalJavaScriptBundler {
9898
if (errors.isNotEmpty) {
9999
throw new Exception(errors.join('/n') +
100100
'\nHot reload rejected due to unsupported changes. '
101-
'Use hot restart instead.');
101+
'Try performing a hot restart instead.');
102102
}
103103
}
104104
_currentComponent = partialComponent;

0 commit comments

Comments
 (0)