[analysis_server] Support LSP executeCommand over DTD to support code actions

There are a few things in this CL that were difficult to separate testing of (because they're all part of the same feature):

1. sets `requiresTrustedCaller=false` on the `executeCommand` handler so that commands can be called over DTD. It adds the same flag to the command handlers themselves, so a command can control whether it can be called over DTD or not (right now we allow everything except `logAction` and `sendWorkspaceEdit` which are both commands used internally and not appropriate for DTD clients to call).

2. Removes the allow-list on DTD methods, allowing all LSP shared methods to be available over DTD

3. Extends the integration test classes to support reverse-requests so we can verify the edits being sent back to the editor when calling the code actions commands over DTD

4. It also fixes a few bugs where we read the callers capabilities instead of the editors capabilities (which until now would always be the same in those places, but with this change are not).

Change-Id: I6d271ddad6dc1b00a98b10b735763a368c91af7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428784
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/handler/legacy/lsp_over_legacy_handler.dart

@@ -69,6 +69,7 @@ class LspOverLegacyHandler extends LegacyHandler {
       performance: performance,
       clientCapabilities: server.editorClientCapabilities,
       timeSinceRequest: request.timeSinceRequest,
+      isTrustedCaller: true,
     );
 
     ErrorOr<Object?> result;

pkg/analysis_server/lib/src/lsp/handlers/commands/apply_code_action.dart

@@ -33,6 +33,9 @@ class ApplyCodeActionCommandHandler
   @override
   bool get recordsOwnAnalytics => true;
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/fix_all.dart

@@ -22,6 +22,9 @@ class FixAllCommandHandler extends SimpleEditCommandHandler<LspAnalysisServer> {
   @override
   String get commandName => 'Fix All';
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/fix_all_in_workspace.dart

@@ -24,6 +24,9 @@ abstract class AbstractFixAllInWorkspaceCommandHandler
   /// user can choose which changes to apply.
   bool get requireConfirmation;
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/log_action.dart

@@ -15,6 +15,10 @@ class LogActionCommandHandler
   @override
   bool get recordsOwnAnalytics => true;
 
+  @override
+  // We only currently expect this to be called by the editor.
+  bool get requiresTrustedCaller => true;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/organize_imports.dart

@@ -16,6 +16,9 @@ class OrganizeImportsCommandHandler extends SimpleEditCommandHandler {
   @override
   String get commandName => 'Organize Imports';
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/perform_refactor.dart

@@ -28,6 +28,9 @@ class PerformRefactorCommandHandler extends AbstractRefactorCommandHandler {
   @override
   bool get recordsOwnAnalytics => true;
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   FutureOr<ErrorOr<void>> execute(
     String path,
@@ -40,6 +43,12 @@ class PerformRefactorCommandHandler extends AbstractRefactorCommandHandler {
     ProgressReporter reporter,
     int? docVersion,
   ) async {
+    var editorCapabilities = server.editorClientCapabilities;
+    if (editorCapabilities == null) {
+      // This should not happen unless a client misbehaves.
+      return serverNotInitializedError;
+    }
+
     var actionName = 'dart.refactor.${kind.toLowerCase()}';
     server.analyticsManager.executedCommand(actionName);
 
@@ -102,7 +111,7 @@ class PerformRefactorCommandHandler extends AbstractRefactorCommandHandler {
             return fileModifiedError;
           }
 
-          var edit = createWorkspaceEdit(server, clientCapabilities, change);
+          var edit = createWorkspaceEdit(server, editorCapabilities, change);
           return await sendWorkspaceEditToClient(edit);
         } finally {
           manager.end(cancelableToken);

pkg/analysis_server/lib/src/lsp/handlers/commands/refactor_command_handler.dart

@@ -27,6 +27,9 @@ class RefactorCommandHandler extends SimpleEditCommandHandler<AnalysisServer> {
 
   RefactorCommandHandler(super.server, this.commandName, this.generator);
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/send_workspace_edit.dart

@@ -22,6 +22,11 @@ class SendWorkspaceEditCommandHandler extends SimpleEditCommandHandler {
   @override
   String get commandName => 'Send Workspace Edit';
 
+  @override
+  // This command is used internally to work around some limitations in LSP
+  // and is not expected to ever be called by a DTD client.
+  bool get requiresTrustedCaller => true;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,

pkg/analysis_server/lib/src/lsp/handlers/commands/sort_members.dart

@@ -17,6 +17,9 @@ class SortMembersCommandHandler extends SimpleEditCommandHandler {
   @override
   String get commandName => 'Sort Members';
 
+  @override
+  bool get requiresTrustedCaller => false;
+
   @override
   Future<ErrorOr<void>> handle(
     MessageInfo message,