analyzer: Remove deprecated ErrorCode, ErrorSeverity, ErrorType

Change-Id: I914d0906ea417e186139c765b8d42a735dd263d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455461
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/_fe_analyzer_shared/lib/src/base/errors.dart

@@ -35,23 +35,6 @@ String formatList(String pattern, List<Object?>? arguments) {
   });
 }
 
-/// A diagnostic code associated with an `AnalysisError`.
-///
-/// Generally, messages should follow the [Guide for Writing
-/// Diagnostics](https://github.com/dart-lang/sdk/blob/main/pkg/front_end/lib/src/base/diagnostics.md).
-@AnalyzerPublicApi(message: 'exported by package:analyzer/error/error.dart')
-@Deprecated("Use 'DiagnosticCode' instead.")
-typedef ErrorCode = DiagnosticCode;
-
-/// The severity of a [DiagnosticCode].
-@AnalyzerPublicApi(message: 'exported by package:analyzer/error/error.dart')
-@Deprecated("Use 'DiagnosticSeverity' instead.")
-typedef ErrorSeverity = DiagnosticSeverity;
-
-@AnalyzerPublicApi(message: 'exported by package:analyzer/error/error.dart')
-@Deprecated("Use 'DiagnosticType' instead.")
-typedef ErrorType = DiagnosticType;
-
 /// A diagnostic, as defined by the [Diagnostic Design Guidelines][guidelines]:
 ///
 /// > An indication of a specific problem at a specific location within the

pkg/analyzer/CHANGELOG.md

@@ -14,6 +14,9 @@
 * Remove deprecated `PartDirective.configurations`.
 * Remove deprecated `TypeDefiningElement`.
 * Remove deprecated `TypeAliasElement.aliasedElement`.
+* Remove deprecated `ErrorCode`.
+* Remove deprecated `ErrorSeverity`.
+* Remove deprecated `ErrorType`.
 
 ## 8.4.0
 * Add the `experimental_member_use` warning, which warns about any reference to

pkg/analyzer/api.txt

@@ -4573,9 +4573,6 @@ package:analyzer/error/error.dart:
     url (getter: String?)
     == (method: bool Function(Object))
   AnalysisError (type alias for Diagnostic, deprecated)
-  ErrorCode (type alias for DiagnosticCode, deprecated)
-  ErrorSeverity (type alias for DiagnosticSeverity, deprecated)
-  ErrorType (type alias for DiagnosticType, deprecated)
 package:analyzer/error/listener.dart:
   AnalysisErrorListener (class extends Object implements DiagnosticOrErrorListener, deprecated):
     new (constructor: AnalysisErrorListener Function())

pkg/analyzer/lib/error/error.dart

@@ -11,19 +11,7 @@ import 'package:_fe_analyzer_shared/src/base/errors.dart';
 import 'package:analyzer/src/diagnostic/diagnostic_code_values.dart';
 
 export 'package:_fe_analyzer_shared/src/base/errors.dart'
-    show
-        DiagnosticCode,
-        DiagnosticSeverity,
-        DiagnosticType,
-        // Continue exporting the deprecated element until it is removed.
-        // ignore: deprecated_member_use
-        ErrorCode,
-        // Continue exporting the deprecated element until it is removed.
-        // ignore: deprecated_member_use
-        ErrorSeverity,
-        // Continue exporting the deprecated element until it is removed.
-        // ignore: deprecated_member_use
-        ErrorType;
+    show DiagnosticCode, DiagnosticSeverity, DiagnosticType;
 export 'package:analyzer/src/dart/error/lint_codes.dart' show LintCode;
 export 'package:analyzer/src/diagnostic/diagnostic_code_values.dart'
     show diagnosticCodeValues, errorCodeValues;