[analyzer/linter] Clean up after renaming error codes to camelCase.

Now that the analyzer and linter error codes have been renamed to
camelCase (see https://dart-review.googlesource.com/c/sdk/+/444921),
the script `rename_error_constants.dart` is no longer needed. Also,
the temporary logic in `messages/generate.dart` and
`generate_lints.dart` that allowed for generating either camelCase or
SCREAMING_CAPS error codes can now be hardcoded to always generate
camelCase error codes.

Change-Id: I6a6a6964ec8eef09cac643c959a967ab405f3343
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445122
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: stereotype441

pkg/analyzer/pubspec.yaml

@@ -31,7 +31,6 @@ dependencies:
 # See also https://dart.dev/tools/pub/dependencies.
 dev_dependencies:
   analysis_server_client: any
-  analyzer_plugin: any
   analyzer_testing: any
   analyzer_utilities: any
   args: any

pkg/analyzer/tool/messages/generate.dart

@@ -35,14 +35,6 @@ Future<void> main() async {
     ..printSummary();
 }
 
-/// Whether the error constants that should be generated should use camel-case
-/// names.
-///
-/// This is a temporary flag to allow the codebase to be transitioned to using
-/// camel-case error constants. TODO(paulberry): once the transition is
-/// complete, remove this constant.
-const _useLowerCamelCaseNames = true;
-
 /// A list of all targets generated by this code generator.
 final List<GeneratedContent> allTargets = _analyzerGeneratedFiles();
 
@@ -164,8 +156,7 @@ library;
             out.writeln('${errorCodeInfo.aliasFor};');
           } else {
             generatedCodes.add((errorClass.name, errorName));
-            var constantName =
-                _useLowerCamelCaseNames ? errorName.toCamelCase() : errorName;
+            var constantName = errorName.toCamelCase();
             out.writeln('  static const ${errorClass.name} $constantName =');
             out.writeln(
               errorCodeInfo.toAnalyzerCode(
@@ -175,8 +166,7 @@ library;
               ),
             );
 
-            if (_useLowerCamelCaseNames &&
-                errorClass.deprecatedSnakeCaseNames.contains(errorName)) {
+            if (errorClass.deprecatedSnakeCaseNames.contains(errorName)) {
               out.writeln();
               out.writeln('  @Deprecated("Please use $constantName")');
               out.writeln(
@@ -224,10 +214,8 @@ library;
   void _generateFastaAnalyzerErrorCodeList() {
     out.writeln('final fastaAnalyzerErrorCodes = <DiagnosticCode?>[');
     for (var entry in cfeToAnalyzerErrorCodeTables.indexToInfo) {
-      var name = cfeToAnalyzerErrorCodeTables.infoToAnalyzerCode[entry];
-      if (_useLowerCamelCaseNames) {
-        name = name?.toCamelCase();
-      }
+      var name =
+          cfeToAnalyzerErrorCodeTables.infoToAnalyzerCode[entry]?.toCamelCase();
       out.writeln('${name == null ? 'null' : 'ParserErrorCode.$name'},');
     }
     out.writeln('];');
@@ -285,9 +273,7 @@ import 'package:analyzer/src/pubspec/pubspec_warning_code.dart';
     );
     out.writeln('const List<DiagnosticCode> diagnosticCodeValues = [');
     for (var (className, errorName) in generatedCodes) {
-      if (_useLowerCamelCaseNames) {
-        errorName = errorName.toCamelCase();
-      }
+      errorName = errorName.toCamelCase();
       out.writeln('  $className.$errorName,');
     }
     out.writeln('];');

pkg/analyzer/tool/messages/rename_error_constants.dart

@@ -35,14 +35,6 @@ const linterLintCodeInfo = ErrorClassInfo(
   type: 'LINT',
 );
 
-/// Whether the error constants that should be generated should use camel-case
-/// names.
-///
-/// This is a temporary flag to allow the codebase to be transitioned to using
-/// camel-case error constants. TODO(paulberry): once the transition is
-/// complete, remove this constant.
-const _useLowerCamelCaseNames = true;
-
 GeneratedFile get generatedCodesFile =>
     GeneratedFile(generatedCodesPath, (pkgRoot) async {
       var out = StringBuffer('''
@@ -78,8 +70,7 @@ class LinterLintCode extends LintCode {
         if (codeInfo.deprecatedMessage case var deprecatedMessage?) {
           out.writeln('  @Deprecated("$deprecatedMessage")');
         }
-        var constantName =
-            _useLowerCamelCaseNames ? errorName.toCamelCase() : errorName;
+        var constantName = errorName.toCamelCase();
         out.writeln('  static const LintCode $constantName =');
         out.writeln(
           codeInfo.toAnalyzerCode(
@@ -92,8 +83,7 @@ class LinterLintCode extends LintCode {
         out.writeln();
       }
 
-      var removedLintName =
-          _useLowerCamelCaseNames ? 'removedLint' : 'removed_lint';
+      var removedLintName = 'removedLint';
       out.writeln('''
   /// A lint code that removed lints can specify as their `lintCode`.
   ///