DAS: reformat source code with tall-style

Change-Id: I42b4a44fd6a2197e499e8623274b3cd1a4b5556f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394003
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/benchmark/benchmarks.dart

@@ -70,8 +70,12 @@ abstract class Benchmark {
   /// One of 'memory', 'cpu', or 'group'.
   final String kind;
 
-  Benchmark(this.id, this.description,
-      {this.enabled = true, required this.kind});
+  Benchmark(
+    this.id,
+    this.description, {
+    this.enabled = true,
+    required this.kind,
+  });
 
   int get maxIterations => 0;
 
@@ -87,8 +91,12 @@ abstract class Benchmark {
     bool verbose = false,
   });
 
-  Map<String, Object?> toJson() =>
-      {'id': id, 'description': description, 'enabled': enabled, 'kind': kind};
+  Map<String, Object?> toJson() => {
+    'id': id,
+    'description': description,
+    'enabled': enabled,
+    'kind': kind,
+  };
 
   @override
   String toString() => '$id: $description';
@@ -132,10 +140,7 @@ class CompoundBenchMarkResult extends BenchMarkResult {
     }
 
     var combined = CompoundBenchMarkResult(name);
-    var keys = {
-      ...results.keys,
-      ...other.results.keys,
-    }.toList();
+    var keys = {...results.keys, ...other.results.keys}.toList();
 
     for (var key in keys) {
       combined.add(key, combine(results[key], other.results[key]));
@@ -167,8 +172,11 @@ class ListCommand extends Command<void> {
   final List<Benchmark> benchmarks;
 
   ListCommand(this.benchmarks) {
-    argParser.addFlag('machine',
-        negatable: false, help: 'Emit the list of benchmarks as json.');
+    argParser.addFlag(
+      'machine',
+      negatable: false,
+      help: 'Emit the list of benchmarks as json.',
+    );
   }
 
   @override
@@ -184,7 +192,7 @@ class ListCommand extends Command<void> {
   void run() {
     if (argResults!['machine'] as bool) {
       var map = <String, Object?>{
-        'benchmarks': benchmarks.map((b) => b.toJson()).toList()
+        'benchmarks': benchmarks.map((b) => b.toJson()).toList(),
       };
       print(JsonEncoder.withIndent('  ').convert(map));
     } else {
@@ -199,20 +207,32 @@ class RunCommand extends Command<void> {
   final List<Benchmark> benchmarks;
 
   RunCommand(this.benchmarks) {
-    argParser.addOption('dart-sdk',
-        help: 'The absolute normalized path of the Dart SDK.');
-    argParser.addOption('flutter-repository',
-        help: 'The absolute normalized path of the Flutter repository.');
-    argParser.addFlag('quick',
-        negatable: false,
-        help: 'Run a quick version of the benchmark. This is not useful for '
-            'gathering accurate times,\nbut can be used to validate that the '
-            'benchmark works.');
-    argParser.addOption('repeat',
-        defaultsTo: '4', help: 'The number of times to repeat the benchmark.');
-    argParser.addFlag('verbose',
-        negatable: false,
-        help: 'Print all communication to and from the analysis server.');
+    argParser.addOption(
+      'dart-sdk',
+      help: 'The absolute normalized path of the Dart SDK.',
+    );
+    argParser.addOption(
+      'flutter-repository',
+      help: 'The absolute normalized path of the Flutter repository.',
+    );
+    argParser.addFlag(
+      'quick',
+      negatable: false,
+      help:
+          'Run a quick version of the benchmark. This is not useful for '
+          'gathering accurate times,\nbut can be used to validate that the '
+          'benchmark works.',
+    );
+    argParser.addOption(
+      'repeat',
+      defaultsTo: '4',
+      help: 'The number of times to repeat the benchmark.',
+    );
+    argParser.addFlag(
+      'verbose',
+      negatable: false,
+      help: 'Print all communication to and from the analysis server.',
+    );
   }
 
   @override
@@ -242,11 +262,13 @@ class RunCommand extends Command<void> {
     var quick = args['quick'] as bool;
     var verbose = args['verbose'] as bool;
 
-    var benchmark =
-        benchmarks.firstWhere((b) => b.id == benchmarkId, orElse: () {
-      print("Benchmark '$benchmarkId' not found.");
-      exit(1);
-    });
+    var benchmark = benchmarks.firstWhere(
+      (b) => b.id == benchmarkId,
+      orElse: () {
+        print("Benchmark '$benchmarkId' not found.");
+        exit(1);
+      },
+    );
 
     dartSdkPath ??= path.dirname(path.dirname(Platform.resolvedExecutable));
 
@@ -261,8 +283,10 @@ class RunCommand extends Command<void> {
           exit(1);
         }
       } else {
-        print('The option --flutter-repository is required to '
-            "run '$benchmarkId'.");
+        print(
+          'The option --flutter-repository is required to '
+          "run '$benchmarkId'.",
+        );
         exit(1);
       }
     }
@@ -296,7 +320,7 @@ class RunCommand extends Command<void> {
       print('Finished in ${time.elapsed.inSeconds} seconds.\n');
       var m = <String, dynamic>{
         'benchmark': benchmarkId,
-        'result': result!.toJson()
+        'result': result!.toJson(),
       };
       print(json.encode(m));
 

pkg/analysis_server/benchmark/integration/driver.dart

@@ -61,7 +61,9 @@ class Driver extends IntegrationTest {
   /// If the server acknowledges the command with an error response, the future
   /// will be completed with an error.
   Future<Map<String, Object?>?> send(
-      String method, Map<String, dynamic> params) {
+    String method,
+    Map<String, dynamic> params,
+  ) {
     return server.send(method, params);
   }
 
@@ -81,14 +83,14 @@ class Driver extends IntegrationTest {
     return server
         .start(dartSdkPath: dartSdkPath, diagnosticPort: diagnosticPort)
         .then((params) {
-      server.listenToOutput(dispatchNotification);
-      server.exitCode.then((_) {
-        logger.log(Level.FINE, 'server stopped');
-        running = false;
-        _resultsReady();
-      });
-      return serverConnected.future;
-    });
+          server.listenToOutput(dispatchNotification);
+          server.exitCode.then((_) {
+            logger.log(Level.FINE, 'server stopped');
+            running = false;
+            _resultsReady();
+          });
+          return serverConnected.future;
+        });
   }
 
   /// Shutdown the analysis server if it is running.
@@ -98,9 +100,12 @@ class Driver extends IntegrationTest {
       // Give the server a short time to comply with the shutdown request; if it
       // doesn't exit, then forcibly terminate it.
       unawaited(sendServerShutdown());
-      await server.exitCode.timeout(timeout, onTimeout: () {
-        return server.kill('server failed to exit');
-      });
+      await server.exitCode.timeout(
+        timeout,
+        onTimeout: () {
+          return server.kill('server failed to exit');
+        },
+      );
     }
     _resultsReady();
   }
@@ -206,7 +211,11 @@ class Results {
       }
     }
     _printTotals(
-        keyLen, totalCount, totalErrorCount, totalUnexpectedResultCount);
+      keyLen,
+      totalCount,
+      totalErrorCount,
+      totalUnexpectedResultCount,
+    );
     print('');
     _printGroupHeader('Notifications', keyLen);
     for (var entry in sortedEntries) {
@@ -225,8 +234,12 @@ class Results {
   }
 
   /// Record the elapsed time for the given operation.
-  void record(String tag, Duration elapsed,
-      {bool notification = false, bool success = true}) {
+  void record(
+    String tag,
+    Duration elapsed, {
+    bool notification = false,
+    bool success = true,
+  }) {
     var measurement = measurements[tag];
     if (measurement == null) {
       measurement = Measurement(tag, notification);
@@ -256,8 +269,12 @@ class Results {
     print(buffer.toString());
   }
 
-  static void _printTotals(int keyLength, int totalCount, int totalErrorCount,
-      int totalUnexpectedResultCount) {
+  static void _printTotals(
+    int keyLength,
+    int totalCount,
+    int totalErrorCount,
+    int totalUnexpectedResultCount,
+  ) {
     var buffer = StringBuffer();
     buffer.writePadRight('Totals', keyLength);
     buffer.writePadLeft(totalCount.toString(), 6);

pkg/analysis_server/benchmark/integration/input_converter.dart

@@ -94,8 +94,10 @@ abstract class CommonInputConverter extends Converter<String, Operation?> {
       // Track overlays in parallel with the analysis server
       // so that when an overlay is removed, the file can be updated on disk
       var request = Request.fromJson(json)!;
-      var params = AnalysisUpdateContentParams.fromRequest(request,
-          clientUriConverter: null);
+      var params = AnalysisUpdateContentParams.fromRequest(
+        request,
+        clientUriConverter: null,
+      );
       params.files.forEach((String filePath, change) {
         if (change is AddContentOverlay) {
           var content = change.content;
@@ -148,8 +150,11 @@ abstract class CommonInputConverter extends Converter<String, Operation?> {
 
   /// Return an operation for the recorded/expected response.
   Operation convertResponse(Map<String, dynamic> json) {
-    return ResponseOperation(this, asMap(requestMap.remove(json['id'])),
-        asMap(translateSrcPaths(json)));
+    return ResponseOperation(
+      this,
+      asMap(requestMap.remove(json['id'])),
+      asMap(translateSrcPaths(json)),
+    );
   }
 
   void logOverlayContent() {
@@ -182,7 +187,9 @@ abstract class CommonInputConverter extends Converter<String, Operation?> {
   /// or `null` if the response has already been received
   /// and the completer completed.
   Future<void>? processExpectedResponse(
-      String id, Completer<Object?> completer) {
+    String id,
+    Completer<Object?> completer,
+  ) {
     if (responseMap.containsKey(id)) {
       logger.log(Level.INFO, 'processing cached response $id');
       completer.complete(responseMap.remove(id));

pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart

@@ -43,7 +43,9 @@ class InstrumentationInputConverter extends CommonInputConverter {
       }
     } catch (e, s) {
       throw AnalysisException(
-          'Failed to parse line\n$line', CaughtException(e, s));
+        'Failed to parse line\n$line',
+        CaughtException(e, s),
+      );
     }
     // int timeStamp = int.parse(fields[0], onError: (_) => -1);
     var opCode = fields[1];
@@ -71,7 +73,9 @@ class InstrumentationInputConverter extends CommonInputConverter {
     }
     if (codesSeen.add(opCode)) {
       logger.log(
-          Level.WARNING, 'Ignored instrumentation op code: $opCode\n  $line');
+        Level.WARNING,
+        'Ignored instrumentation op code: $opCode\n  $line',
+      );
     }
     return null;
   }
@@ -81,7 +85,9 @@ class InstrumentationInputConverter extends CommonInputConverter {
       return asMap(json.decode(text));
     } catch (e, s) {
       throw AnalysisException(
-          'Failed to decode JSON: $text\n$line', CaughtException(e, s));
+        'Failed to decode JSON: $text\n$line',
+        CaughtException(e, s),
+      );
     }
   }
 

pkg/analysis_server/benchmark/integration/local_runner.dart

@@ -26,8 +26,9 @@ void main(List<String> args) {
   /*
    * Create a new temp directory
    */
-  var tmpDir =
-      Directory(join(Directory.systemTemp.path, 'analysis_server_perf_target'));
+  var tmpDir = Directory(
+    join(Directory.systemTemp.path, 'analysis_server_perf_target'),
+  );
   if (!tmpDir.path.contains('tmp')) throw 'invalid tmp directory\n  $tmpDir';
   print('Extracting target analysis environment into\n  ${tmpDir.path}');
   if (tmpDir.existsSync()) tmpDir.deleteSync(recursive: true);
@@ -36,13 +37,19 @@ void main(List<String> args) {
    * Setup the initial target source in the temp directory
    */
   var tarFilePath = join(tmpDir.path, 'targetSrc.tar');
-  var result = Process.runSync('git', ['archive', branch, '-o', tarFilePath],
-      workingDirectory: gitDir.path);
+  var result = Process.runSync('git', [
+    'archive',
+    branch,
+    '-o',
+    tarFilePath,
+  ], workingDirectory: gitDir.path);
   if (result.exitCode != 0) throw 'failed to obtain target source: $result';
   var tmpSrcDirPath = join(tmpDir.path, 'targetSrc');
   Directory(tmpSrcDirPath).createSync();
-  result = Process.runSync('tar', ['-xf', tarFilePath],
-      workingDirectory: tmpSrcDirPath);
+  result = Process.runSync('tar', [
+    '-xf',
+    tarFilePath,
+  ], workingDirectory: tmpSrcDirPath);
   if (result.exitCode != 0) throw 'failed to extract target source: $result';
   /*
    * Symlink the out or xcodebuild directory
@@ -54,16 +61,16 @@ void main(List<String> args) {
   if (!Directory(join(gitDir.path, outDirName)).existsSync()) {
     throw 'failed to find out or xcodebuild directory';
   }
-  result = Process.runSync('ln',
-      ['-s', join(gitDir.path, outDirName), join(tmpSrcDirPath, outDirName)]);
+  result = Process.runSync('ln', [
+    '-s',
+    join(gitDir.path, outDirName),
+    join(tmpSrcDirPath, outDirName),
+  ]);
   if (result.exitCode != 0) throw 'failed to link out or xcodebuild: $result';
   /*
    * Collect arguments
    */
-  var perfArgs = [
-    '-i${inputFile.path}',
-    '-t$tmpSrcDirPath',
-  ];
+  var perfArgs = ['-i${inputFile.path}', '-t$tmpSrcDirPath'];
   for (var index = 3; index < args.length; ++index) {
     perfArgs.add(args[index].replaceAll('@tmpSrcDir@', tmpSrcDirPath));
   }

pkg/analysis_server/benchmark/integration/log_file_input_converter.dart

@@ -44,7 +44,9 @@ class LogFileInputConverter extends CommonInputConverter {
       return null;
     } catch (e, s) {
       throw AnalysisException(
-          'Failed to parse line\n  $line', CaughtException(e, s));
+        'Failed to parse line\n  $line',
+        CaughtException(e, s),
+      );
     }
   }