[vm] Also attempt a stack walk for crashes in the generated safepoint state.

TEST=ci
Change-Id: I87e8ca974b915d25b8a3e84c331af9e6345f0e5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440320
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

runtime/tests/vm/dart/symbolized_dart_crash_test.dart

@@ -0,0 +1,36 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "dart:io";
+import "dart:ffi";
+
+import "package:expect/expect.dart";
+
+@pragma("vm:never-inline")
+@pragma("vm:entry-point") /* block mangling */
+dartFunctionName() {
+  Pointer<Uint8>.fromAddress(0).value = 0;
+}
+
+@pragma("vm:never-inline")
+@pragma("vm:entry-point") /* block mangling */
+main(List<String> arguments) {
+  if (arguments.contains("--testee")) {
+    dartFunctionName();
+    return;
+  }
+
+  var result = Process.runSync(Platform.resolvedExecutable, [
+    ...Platform.executableArguments,
+    Platform.script.toFilePath(),
+    "--testee",
+  ]);
+  print(result.exitCode);
+  print(result.stdout);
+  print(result.stderr);
+
+  Expect.contains("===== CRASH =====", result.stderr);
+  Expect.contains("dartFunctionName", result.stderr);
+  Expect.contains("main", result.stderr);
+}

runtime/vm/profiler.cc

@@ -568,6 +568,9 @@ void Profiler::DumpStackTrace(uword sp, uword fp, uword pc, bool for_crash) {
       StackFrame::DumpCurrentTrace();
     } else if (thread->execution_state() == Thread::kThreadInVM) {
       StackFrame::DumpCurrentTrace();
+    } else if (thread->execution_state() == Thread::kThreadInGenerated) {
+      // No exit frame, walk from the crash's registers.
+      StackFrame::DumpCurrentTrace(sp, fp, pc);
     }
   }
 

runtime/vm/stack_frame.cc

@@ -194,8 +194,10 @@ const char* StackFrame::ToCString() const {
       code.IsNull()
           ? "Cannot find code object"
           : code.QualifiedName(NameFormattingParams(Object::kInternalName));
-  return zone->PrintToString("  pc 0x%" Pp " fp 0x%" Pp " sp 0x%" Pp " %s",
-                             pc(), fp(), sp(), name);
+  uword offset = code.IsNull() ? 0 : pc() - code.PayloadStart();
+  return zone->PrintToString("  pc 0x%" Pp " fp 0x%" Pp " sp 0x%" Pp
+                             " %s+0x%" Px,
+                             pc(), fp(), sp(), name, offset);
 }
 
 void ExitFrame::VisitObjectPointers(ObjectPointerVisitor* visitor) {
@@ -570,6 +572,17 @@ void StackFrame::DumpCurrentTrace() {
   }
 }
 
+void StackFrame::DumpCurrentTrace(uword sp, uword fp, uword pc) {
+  StackFrameIterator frames(fp, sp, pc, ValidationPolicy::kDontValidateFrames,
+                            Thread::Current(),
+                            StackFrameIterator::kNoCrossThreadIteration);
+  StackFrame* frame = frames.NextFrame();
+  while (frame != nullptr) {
+    OS::PrintErr("%s\n", frame->ToCString());
+    frame = frames.NextFrame();
+  }
+}
+
 void StackFrameIterator::SetupLastExitFrameData() {
   ASSERT(thread_ != nullptr);
   uword exit_marker = thread_->top_exit_frame_info();

runtime/vm/stack_frame.h

@@ -130,6 +130,7 @@ class StackFrame : public ValueObject {
   TokenPosition GetTokenPos() const;
 
   static void DumpCurrentTrace();
+  static void DumpCurrentTrace(uword sp, uword fp, uword pc);
 
   uword GetCallerSp() const {
     return fp() +