[DAS] Adds working rename when shadowing global variable is assigned

[email protected]

Bug: #59954
Change-Id: I39417d9e712a40b6992fbad86180c257e782e04a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414200
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart

@@ -361,10 +361,23 @@ class _LocalElementsCollector extends GeneralizingAstVisitor<void> {
   @override
   void visitSimpleIdentifier(SimpleIdentifier node) {
     var element = node.element;
-    if (element is GetterElement && element.name3 == name) {
-      if (element.variable3 case TopLevelVariableElement2 variable) {
-        elements.add(variable);
-      }
+    if (node.parent case AssignmentExpression(
+      :var writeElement2,
+      :var leftHandSide,
+    ) when node == leftHandSide) {
+      element = writeElement2;
+    }
+    if (element is! PropertyAccessorElement2) {
+      return;
+    }
+    if (element.name3 != name) {
+      return;
+    }
+    if (element is! GetterElement && element is! SetterElement) {
+      return;
+    }
+    if (element.variable3 case TopLevelVariableElement2 variable) {
+      elements.add(variable);
     }
     super.visitSimpleIdentifier(node);
   }

pkg/analysis_server/test/services/refactoring/legacy/rename_class_member_test.dart

@@ -1432,7 +1432,7 @@ class A {
 ''');
   }
 
-  Future<void> test_shadowingTopLevelVariable_addsThis() async {
+  Future<void> test_shadowingTopLevelVariableGetter_addsThis() async {
     await indexTestUnit('''
 int? value = 0;
 
@@ -1464,6 +1464,38 @@ class A {
 ''');
   }
 
+  Future<void> test_shadowingTopLevelVariableSetter_addsThis() async {
+    await indexTestUnit('''
+int? value = 0;
+
+class A {
+  final int? _value;
+
+  const A(this._value);
+
+  void m() {
+    value = _value ?? 0;
+  }
+}
+''');
+    createRenameRefactoringAtString('_value;');
+    // check status
+    refactoring.newName = 'value';
+    await assertSuccessfulRefactoring('''
+int? value = 0;
+
+class A {
+  final int? value;
+
+  const A(this.value);
+
+  void m() {
+    value = this.value ?? 0;
+  }
+}
+''');
+  }
+
   Future<void> test_subclass_namedSuper_otherLibrary() async {
     await indexTestUnit('''
 class Base {