[vm/shared] Introduce IsolateGroup.runSync()

Allow dart code execution on mutator thread, do not require an isolate.

It moves some states that was kept on an isolate to thread or isolate group.

Bug: #54530
Bug: #56841

TEST=run_isolate_group_run_test

CoreLibraryReviewExempt: only internal library is being updated
Change-Id: I99df09e23954755387ea6230bfd166493d78e989
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418503
Reviewed-by: Slava Egorov <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Author: aam

pkg/dart_internal/lib/isolate_group.dart

@@ -0,0 +1,6 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// ignore: export_internal_library
+export 'dart:_internal' show IsolateGroup;

runtime/lib/concurrent.cc

@@ -110,4 +110,45 @@ DEFINE_FFI_NATIVE_ENTRY(ConditionVariable_NotifyAll,
   condvar->NotifyAll();
 }
 
+DEFINE_FFI_NATIVE_ENTRY(IsolateGroup_runSync,
+                        Dart_Handle,
+                        (Dart_Handle closure)) {
+  Thread* current_thread = Thread::Current();
+  ASSERT(current_thread->execution_state() == Thread::kThreadInNative);
+  Isolate* saved_isolate = current_thread->isolate();
+  current_thread->ExitSafepointFromNative();
+  current_thread->set_execution_state(Thread::kThreadInVM);
+  Thread::ExitIsolate(/*isolate_shutdown=*/false);
+
+  Thread::EnterIsolateGroupAsMutator(current_thread->isolate_group(),
+                                     /*bypass_safepoint=*/false);
+
+  auto mutator_thread = Thread::Current();
+
+  ApiState* state = mutator_thread->isolate_group()->api_state();
+  ASSERT(state != nullptr);
+  mutator_thread->EnterApiScope();
+  ASSERT(mutator_thread->execution_state() == Thread::kThreadInVM);
+
+  Dart_PersistentHandle persistent_result;
+  {
+    TransitionVMToNative transition(mutator_thread);
+    Dart_Handle result = Dart_InvokeClosure(closure, 0, nullptr);
+    persistent_result = Dart_NewPersistentHandle(result);
+  }
+
+  mutator_thread->ExitApiScope();
+
+  Thread::ExitIsolateGroupAsMutator(/*bypass_safepoint=*/false);
+  Thread::EnterIsolate(saved_isolate);
+
+  Thread* T = Thread::Current();
+  T->EnterSafepointToNative();
+  T->set_execution_state(Thread::kThreadInNative);
+
+  Dart_Handle local_handle = Dart_HandleFromPersistent(persistent_result);
+  Dart_DeletePersistentHandle(persistent_result);
+  return local_handle;
+}
+
 }  // namespace dart

runtime/lib/isolate.cc

@@ -117,7 +117,7 @@ DEFINE_NATIVE_ENTRY(SendPort_sendInternal_, 0, 2) {
 #if defined(DEBUG)
   if (same_group) {
     ASSERT(PortMap::IsReceiverInThisIsolateGroupOrClosed(destination_port_id,
-                                                         isolate->group()));
+                                                         group));
   }
 #endif
 

runtime/vm/bootstrap_natives.h

@@ -375,6 +375,7 @@ namespace dart {
   V(ConditionVariable_NotifyAll, void, (Dart_Handle))                          \
   V(ConditionVariable_Wait, void, (Dart_Handle, Dart_Handle))                  \
   V(FinalizerEntry_SetExternalSize, void, (Dart_Handle, intptr_t))             \
+  V(IsolateGroup_runSync, Dart_Handle, (Dart_Handle))                          \
   V(Mutex_Initialize, void, (Dart_Handle))                                     \
   V(Mutex_RunLocked, Dart_Handle, (Dart_Handle, Dart_Handle))                  \
   V(Pointer_asTypedListFinalizerAllocateData, void*, ())                       \

runtime/vm/compiler/backend/il.cc

@@ -7320,19 +7320,6 @@ void NativeCallInstr::SetupNative() {
   Thread* thread = Thread::Current();
   Zone* zone = thread->zone();
 
-  // Currently we perform unoptimized compilations only on mutator threads. If
-  // the compiler has to resolve a native to a function pointer it calls out to
-  // the embedder to do so.
-  //
-  // Unfortunately that embedder API was designed by giving it a handle to a
-  // string. So the embedder will have to call back into the VM to convert it to
-  // a C string - which requires an active isolate.
-  //
-  // => To allow this `dart-->jit-compiler-->embedder-->dart api` we set the
-  //    active isolate again.
-  //
-  ActiveIsolateScope active_isolate(thread);
-
   const Class& cls = Class::Handle(zone, function().Owner());
   const Library& library = Library::Handle(zone, cls.library());
 

runtime/vm/compiler/runtime_api.h

@@ -1296,6 +1296,10 @@ class Thread : public AllStatic {
 
   static word suspend_state_handle_exception_entry_point_offset();
 
+#if !defined(PRODUCT)
+  static word single_step_offset();
+#endif  // !defined(PRODUCT)
+
   static word OffsetFromThread(const dart::Object& object);
   static intptr_t OffsetFromThread(const dart::RuntimeEntry* runtime_entry);
 };
@@ -1344,7 +1348,6 @@ class Isolate : public AllStatic {
   static word user_tag_offset();
   static word finalizers_offset();
 #if !defined(PRODUCT)
-  static word single_step_offset();
   static word has_resumption_breakpoints_offset();
 #endif  // !defined(PRODUCT)
 };

runtime/vm/compiler/runtime_offsets_extracted.h

@@ -174,7 +174,6 @@
   FIELD(IsolateGroup, object_store_offset)                                     \
   FIELD(IsolateGroup, class_table_offset)                                      \
   FIELD(IsolateGroup, cached_class_table_table_offset)                         \
-  NOT_IN_PRODUCT(FIELD(Isolate, single_step_offset))                           \
   FIELD(Isolate, user_tag_offset)                                              \
   FIELD(LinkedHashBase, data_offset)                                           \
   FIELD(ImmutableLinkedHashBase, data_offset)                                  \
@@ -319,6 +318,7 @@
   FIELD(Thread, saved_shadow_call_stack_offset)                                \
   FIELD(Thread, safepoint_state_offset)                                        \
   FIELD(Thread, shared_field_table_values_offset)                              \
+  NOT_IN_PRODUCT(FIELD(Thread, single_step_offset))                            \
   FIELD(Thread, slow_type_test_stub_offset)                                    \
   FIELD(Thread, slow_type_test_entry_point_offset)                             \
   FIELD(Thread, stack_limit_offset)                                            \

runtime/vm/compiler/runtime_offsets_list.h

@@ -2328,8 +2328,7 @@ void StubCodeCompiler::GenerateNArgsCheckInlineCacheStub(
   Label stepping, done_stepping;
   if (optimized == kUnoptimized) {
     __ Comment("Check single stepping");
-    __ LoadIsolate(R8);
-    __ ldrb(R8, Address(R8, target::Isolate::single_step_offset()));
+    __ ldrb(R8, Address(THR, target::Thread::single_step_offset()));
     __ CompareImmediate(R8, 0);
     __ b(&stepping, NE);
     __ Bind(&done_stepping);
@@ -2681,8 +2680,7 @@ void StubCodeCompiler::GenerateZeroArgsUnoptimizedStaticCallStub() {
 #if !defined(PRODUCT)
   // Check single stepping.
   Label stepping, done_stepping;
-  __ LoadIsolate(R8);
-  __ ldrb(R8, Address(R8, target::Isolate::single_step_offset()));
+  __ ldrb(R8, Address(THR, target::Thread::single_step_offset()));
   __ CompareImmediate(R8, 0);
   __ b(&stepping, NE);
   __ Bind(&done_stepping);
@@ -2899,8 +2897,7 @@ void StubCodeCompiler::GenerateDebugStepCheckStub() {
 #else
   // Check single stepping.
   Label stepping, done_stepping;
-  __ LoadIsolate(R1);
-  __ ldrb(R1, Address(R1, target::Isolate::single_step_offset()));
+  __ ldrb(R1, Address(THR, target::Thread::single_step_offset()));
   __ CompareImmediate(R1, 0);
   __ b(&stepping, NE);
   __ Bind(&done_stepping);
@@ -3220,8 +3217,7 @@ void StubCodeCompiler::GenerateUnoptimizedIdenticalWithNumberCheckStub() {
 #if !defined(PRODUCT)
   // Check single stepping.
   Label stepping, done_stepping;
-  __ LoadIsolate(R1);
-  __ ldrb(R1, Address(R1, target::Isolate::single_step_offset()));
+  __ ldrb(R1, Address(THR, target::Thread::single_step_offset()));
   __ CompareImmediate(R1, 0);
   __ b(&stepping, NE);
   __ Bind(&done_stepping);

runtime/vm/compiler/stub_code_compiler_arm.cc

@@ -2723,8 +2723,7 @@ void StubCodeCompiler::GenerateNArgsCheckInlineCacheStub(
   Label stepping, done_stepping;
   if (optimized == kUnoptimized) {
     __ Comment("Check single stepping");
-    __ LoadIsolate(R6);
-    __ LoadFromOffset(R6, R6, target::Isolate::single_step_offset(),
+    __ LoadFromOffset(R6, THR, target::Thread::single_step_offset(),
                       kUnsignedByte);
     __ CompareRegisters(R6, ZR);
     __ b(&stepping, NE);
@@ -3095,8 +3094,7 @@ void StubCodeCompiler::GenerateZeroArgsUnoptimizedStaticCallStub() {
   // Check single stepping.
 #if !defined(PRODUCT)
   Label stepping, done_stepping;
-  __ LoadIsolate(R6);
-  __ LoadFromOffset(R6, R6, target::Isolate::single_step_offset(),
+  __ LoadFromOffset(R6, THR, target::Thread::single_step_offset(),
                     kUnsignedByte);
   __ CompareImmediate(R6, 0);
   __ b(&stepping, NE);
@@ -3337,8 +3335,7 @@ void StubCodeCompiler::GenerateDebugStepCheckStub() {
 #else
   // Check single stepping.
   Label stepping, done_stepping;
-  __ LoadIsolate(R1);
-  __ LoadFromOffset(R1, R1, target::Isolate::single_step_offset(),
+  __ LoadFromOffset(R1, THR, target::Thread::single_step_offset(),
                     kUnsignedByte);
   __ CompareImmediate(R1, 0);
   __ b(&stepping, NE);
@@ -3597,8 +3594,7 @@ void StubCodeCompiler::GenerateUnoptimizedIdenticalWithNumberCheckStub() {
 #if !defined(PRODUCT)
   // Check single stepping.
   Label stepping, done_stepping;
-  __ LoadIsolate(R1);
-  __ LoadFromOffset(R1, R1, target::Isolate::single_step_offset(),
+  __ LoadFromOffset(R1, THR, target::Thread::single_step_offset(),
                     kUnsignedByte);
   __ CompareImmediate(R1, 0);
   __ b(&stepping, NE);