Skip to content

Commit fe0552d

Browse files
lrhnCommit Queue
authored andcommitted
Retire digit-separators experiment in SDK 3.7.
Change-Id: I6a37665fa76059f665b52844e4a9784dca6224b0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400381 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Lasse Nielsen <[email protected]>
1 parent 601e854 commit fe0552d

File tree

8 files changed

+4
-9
lines changed

8 files changed

+4
-9
lines changed

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ enum ExperimentalFlag {
5555
digitSeparators(
5656
name: 'digit-separators',
5757
isEnabledByDefault: true,
58-
isExpired: false,
58+
isExpired: true,
5959
experimentEnabledVersion: const Version(3, 6),
6060
experimentReleasedVersion: const Version(3, 6)),
6161

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ class IsExpired {
710710
static const bool control_flow_collections = true;
711711

712712
/// Expiration status of the experiment "digit-separators"
713-
static const bool digit_separators = false;
713+
static const bool digit_separators = true;
714714

715715
/// Expiration status of the experiment "enhanced-enums"
716716
static const bool enhanced_enums = true;

pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class ExperimentalFlag {
110110
static const ExperimentalFlag digitSeparators = const ExperimentalFlag(
111111
name: 'digit-separators',
112112
isEnabledByDefault: true,
113-
isExpired: false,
113+
isExpired: true,
114114
enabledVersion: const Version(3, 6),
115115
experimentEnabledVersion: const Version(3, 6),
116116
experimentReleasedVersion: const Version(3, 6));

pkg/front_end/messages.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1782,7 +1782,6 @@ UnexpectedSeparatorInNumber:
17821782
problemMessage: "Digit separators ('_') in a number literal can only be placed between two digits."
17831783
correctionMessage: "Try removing the '_'."
17841784
analyzerCode: UNEXPECTED_SEPARATOR_IN_NUMBER
1785-
experiments: digit-separators
17861785
expression:
17871786
- '123_'
17881787
- '1.23_'
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
--enable-experiment=digit-separators

tests/language/number/separators_error_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=digit-separators
6-
75
import "package:expect/expect.dart";
86

97
main() {

tests/language/number/separators_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=digit-separators
6-
75
import "package:expect/expect.dart";
86
import 'package:expect/variations.dart' as v;
97

tools/experimental_features.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ features:
195195
print('feature enabled');
196196
}
197197
help: "Number literals with digit separators."
198+
expired: true
198199

199200
inference-update-3: # See https://github.com/dart-lang/language/issues/1618
200201
enabledIn: '3.4.0'

0 commit comments

Comments
 (0)