lint rules: Move _some_ tests for unnecessary_parenthesis

There are a lot, so I'm migrating them piecemeal.

Change-Id: I54a2a92fdb8687ca4a87a05f36a8977665251062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389591
Auto-Submit: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: srawlins

pkg/linter/test/rules/unnecessary_parenthesis_test.dart

@@ -213,6 +213,55 @@ class C {
 ''');
   }
 
+  test_constructorTearoffInside() async {
+    await assertDiagnostics(r'''
+class C {}
+void f() {
+  (C.new)();
+}
+''', [
+      lint(24, 7),
+    ]);
+  }
+
+  test_constructorTearoffInside_instantiatedThenCalled() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (List.filled)<int>(3, 0);
+}
+''');
+  }
+
+  test_constructorTearoffInstantiatedInside() async {
+    await assertDiagnostics(r'''
+void f() {
+  (List<int>.filled)(3, 0);
+}
+''', [
+      lint(13, 18),
+    ]);
+  }
+
+  test_constructorTearoffInstantiatedInside_assignment() async {
+    await assertDiagnostics(r'''
+var x = (List<int>.filled);
+''', [
+      lint(8, 18),
+    ]);
+  }
+
+  test_constructorTearoffReferenceInside() async {
+    await assertDiagnostics(r'''
+class C {}
+void f() {
+  var cNew = C.new;
+  (cNew)();
+}
+''', [
+      lint(44, 6),
+    ]);
+  }
+
   test_equalityInside_constructorFieldInitializer() async {
     await assertNoDiagnostics(r'''
 class C {
@@ -261,6 +310,67 @@ class C {
 ''');
   }
 
+  test_functionExpressionInside_assignment() async {
+    await assertDiagnostics(r'''
+var f = (() => null);
+''', [
+      lint(8, 12),
+    ]);
+  }
+
+  test_functionExpressionInside_binaryExpression() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (() => '') + 1;
+}
+extension on Function {
+  operator +(int x) {}
+}
+''');
+  }
+
+  test_functionExpressionInside_indexExpression() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (() => '')[0];
+}
+extension on Function {
+  int operator [](int i) => 0;
+}
+''');
+  }
+
+  test_functionExpressionInside_targetOfAssignment() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (() => '').g = 1;
+}
+
+extension on Function {
+  set g(int value) {}
+}
+''');
+  }
+
+  test_functionExpressionInside_targetOfMethodInvocation() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (() {}).g();
+}
+extension on Function {
+  void g() {}
+}
+''');
+  }
+
+  test_functionExpressionInside_targetOfPropertyAccess() async {
+    await assertNoDiagnostics(r'''
+void f() {
+  (() => '').hashCode;
+}
+''');
+  }
+
   test_listLiteral() async {
     await assertDiagnostics(r'''
 final items = [1, (DateTime.now())];
@@ -306,6 +416,14 @@ void f(int i) {
 ''');
   }
 
+  test_postfixExpressionInside_targetOfPropertyAccess() async {
+    await assertNoDiagnostics(r'''
+void f(int p) {
+  (p++).hashCode;
+}
+''');
+  }
+
   test_prefixExpressionInside_targetOfMethodInvocation() async {
     await assertNoDiagnostics(r'''
 void f(bool b) {
@@ -358,7 +476,7 @@ void g((int,) i) {}
     ]);
   }
 
-  test_singleElementRecordWithNoTrailingComma_assignment() async {
+  test_singleElementRecordWithNoTrailingCommaInside_assignment() async {
     await assertDiagnostics(r'''
 void f() {
   (int,) r = (3);
@@ -495,22 +613,6 @@ extension on String? {
 void f() {
   (List<int>).toString();
 }
-''');
-  }
-
-  test_unaryExpressionInside_targetOfMethodInvocation() async {
-    await assertNoDiagnostics(r'''
-void f(int p) {
-  (p++).toString();
-}
-''');
-  }
-
-  test_unaryExpressionInside_targetOfPropertyAccess() async {
-    await assertNoDiagnostics(r'''
-void f(int p) {
-  (p++).hashCode;
-}
 ''');
   }
 }

pkg/linter/test_data/rules/unnecessary_parenthesis.dart

@@ -4,43 +4,6 @@
 
 import 'dart:async';
 
-/// https://github.com/dart-lang/linter/issues/2944
-void foo() {
-  final items = [];
-  (() => [].add('something')).compose(() {}); // OK
-  (() => '').hashCode; // OK
-  (() => '').f = 1; // OK
-  (() => '') + 1; // OK
-  (() => '')[0]; // OK
-}
-
-extension A on void Function() {
-  void Function() compose(void Function() other) => () {
-        this();
-        other();
-      };
-
-  set f(int f) {}
-  operator +(int x) {}
-  int operator [](int i) => 0;
-}
-
-var func = (() => null); // LINT
-
-class D {
-  D.d([int? x, int? y]);
-}
-
-/// https://github.com/dart-lang/linter/issues/2907
-void constructorTearOffs() {
-  var makeD = D.d;
-  (makeD)(1); // LINT
-  (D.d)(1); // LINT
-  (List<int>.filled)(3, 0); // LINT
-  (List.filled)<int>(3, 0); // OK
-  var tearoff = (List<int>.filled); // LINT
-}
-
 var a, b, c, d;
 
 main() async {