[dart2js/ddc] Support '.' in @js renames in extension type and extension members

Fixes #61411

This was previously disallowed for static members in pkg:js
classes, but an error was never added for dart:js_interop types.
We could add an error, but this is useful for both static and
non-static members so users don't have to introduce new top-levels
or types just to access a nested member. This also makes it
consistent with dart2wasm.

Updates some front_end expectations tests as well to test
more syntax and renamed members.

Change-Id: I690d53d64fedc5869e1bdd9f7cfd86d256d7f75b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447482
Commit-Queue: Srujan Gaddam <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>

Author: srujzs

pkg/_js_interop_checks/lib/js_interop_checks.dart

@@ -436,10 +436,11 @@ class JsInteropChecks extends RecursiveVisitor {
         _checkNoNamedParameters(node.function);
       }
 
-      // JS static methods cannot use a JS name with dots.
+      // `package:js` JS static methods cannot use a JS name with dots.
       if (node.isStatic &&
           node.enclosingClass != null &&
-          getJSName(node).contains('.')) {
+          getJSName(node).contains('.') &&
+          !hasDartJSInteropAnnotation(node.enclosingClass!)) {
         report(codeJsInteropInvalidStaticClassMemberName);
       }
 

pkg/_js_interop_checks/lib/src/transformations/js_util_optimizer.dart

@@ -766,6 +766,8 @@ series
 services
 setups
 severe
+sf
+sg
 sharp
 sheets
 shipped
@@ -783,6 +785,7 @@ slashes
 sleep
 slight
 sliver
+sm
 smoke
 snull
 somehow

pkg/front_end/test/spell_checking_list_tests.txt

@@ -8,21 +8,47 @@ library static_interop;
 import 'dart:js_interop';
 
 @JS()
-@staticInterop
-class A {}
-
-@JS()
-extension type B._(A a) {
-  external B(A a);
+extension type B._(JSObject a) implements JSObject {
+  // Constructors.
+  external B(JSObject a);
 
   external B.named(int i);
 
-  external A field;
+  external factory B.factory(JSObject a);
+
+  external factory B.namedParams({JSObject a});
+
+  // Non-static fields.
+  external JSObject field;
+
+  external final JSObject finalField;
+
+  @JS('renamedF')
+  external JSObject renamedField;
+
+  @JS('renamedF1.F2')
+  external JSObject renamedField2;
+
+  @JS('renamedF1.F2.F3')
+  external JSObject renamedField3;
+
+  // Non-static methods.
+  external JSObject method();
+
+  @JS('renamedM')
+  external JSObject renamedMethod();
+
+  @JS('renamedM1.M2')
+  external JSObject renamedMethod2();
 
-  external A method();
+  @JS('renamedM1.M2.M3')
+  external JSObject renamedMethod3();
 
   external T genericMethod<T extends B>(T t);
 
+  external B methodWithOptionalArgument([B? b]);
+
+  // Non-static getters and setters.
   external B get getter;
 
   external void set setter(B b);
@@ -31,12 +57,51 @@ extension type B._(A a) {
 
   external void set property(B b);
 
-  external static A staticField;
+  @JS('renamedG')
+  external B get renamedGetter;
+
+  @JS('renamedG1.G2')
+  external B get renamedGetter2;
+
+  @JS('renamedG1.G2.G3')
+  external B get renamedGetter3;
+
+  @JS('renamedS')
+  external void set renamedSetter(B b);
+
+  @JS('renamedS1.S2')
+  external void set renamedSetter2(B b);
+
+  @JS('renamedS1.S2.S3')
+  external void set renamedSetter3(B b);
+
+  // Static fields.
+  external static JSObject staticField;
+
+  @JS('renamedSF')
+  external static JSObject renamedStaticField;
+
+  @JS('renamedSF1.SF2')
+  external static JSObject renamedStaticField2;
 
-  external static A staticMethod();
+  @JS('renamedSF1.SF2.SF3')
+  external static JSObject renamedStaticField3;
+
+  // Static methods.
+  external static JSObject staticMethod();
+
+  @JS('renamedSM')
+  external static JSObject renamedStaticMethod();
+
+  @JS('renamedSM1.SM2')
+  external static JSObject renamedStaticMethod2();
+
+  @JS('renamedSM1.SM2.SM3')
+  external static JSObject renamedStaticMethod3();
 
   external static T staticGenericMethod<T extends B>(T t);
 
+  // Static getters and setters.
   external static B get staticGetter;
 
   external static void set staticSetter(B b);
@@ -45,26 +110,81 @@ extension type B._(A a) {
 
   external static void set staticProperty(B b);
 
-  external B methodWithOptionalArgument([B? b]);
+  @JS('renamedSG')
+  external static B get renamedStaticGetter;
+
+  @JS('renamedSG1.SG2')
+  external static B get renamedStaticGetter2;
+
+  @JS('renamedSG1.SG2.SG3')
+  external static B get renamedStaticGetter3;
+
+  @JS('renamedSS')
+  external static void set renamedStaticSetter(B b);
+
+  @JS('renamedSS1.SS2')
+  external static void set renamedStaticSetter2(B b);
+
+  @JS('renamedSS1.SS2.SS3')
+  external static void set renamedStaticSetter3(B b);
 }
 
-void method(A a) {
+void method(JSObject a) {
   B b1 = new B(a);
   B b2 = new B.named(0);
+  B b3 = B.factory(b2);
+  B b4 = B.namedParams(a: a);
+
   a = b1.field;
   b1.field = a;
+  a = b1.finalField;
+  a = b1.renamedField;
+  a = b1.renamedField2;
+  a = b1.renamedField3;
+  b1.renamedField = a;
+  b1.renamedField2 = a;
+  b1.renamedField3 = a;
+
   a = b1.method();
+  a = b1.renamedMethod();
+  a = b1.renamedMethod2();
+  a = b1.renamedMethod3();
   b2 = b2.genericMethod(b2);
+  b2 = b1.methodWithOptionalArgument(b2);
+  b1 = b2.methodWithOptionalArgument();
+
   b1 = b2.getter;
   b1.setter = b2;
   b1.property = b2.property;
+  b1 = b2.renamedGetter;
+  b1 = b2.renamedGetter2;
+  b1 = b2.renamedGetter3;
+  b1.renamedSetter = b2;
+  b1.renamedSetter2 = b2;
+  b1.renamedSetter3 = b2;
+
   a = B.staticField;
   B.staticField = a;
+  a = B.renamedStaticField;
+  a = B.renamedStaticField2;
+  a = B.renamedStaticField3;
+  B.renamedStaticField = a;
+  B.renamedStaticField2 = a;
+  B.renamedStaticField3 = a;
+
   a = B.staticMethod();
+  B.renamedStaticMethod();
+  B.renamedStaticMethod2();
+  B.renamedStaticMethod3();
   b2 = B.staticGenericMethod(b2);
+
   b1 = B.staticGetter;
   B.staticSetter = b2;
   B.staticProperty = B.staticProperty;
-  b2 = b1.methodWithOptionalArgument(b2);
-  b1 = b2.methodWithOptionalArgument();
+  b1 = B.renamedStaticGetter;
+  b1 = B.renamedStaticGetter2;
+  b1 = B.renamedStaticGetter3;
+  B.renamedStaticSetter = b2;
+  B.renamedStaticSetter2 = b2;
+  B.renamedStaticSetter3 = b2;
 }