Elements. Pass only 'firstFragment' to TypeParameterElementImpl constructor.

If we pass fragments at all currently, we can extract data from it.

Change-Id: I09ad768dcf0971d0c69efc0966019e1f86b23efa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445107
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -9877,17 +9877,14 @@ class TypeParameterElementImpl extends ElementImpl
   @override
   final String? name;
 
-  TypeParameterElementImpl({required this.firstFragment, required this.name}) {
-    TypeParameterFragmentImpl? fragment = firstFragment;
-    while (fragment != null) {
-      fragment.element = this;
-      fragment = fragment.nextFragment;
-    }
+  TypeParameterElementImpl({required this.firstFragment})
+    : name = firstFragment.name {
+    firstFragment.element = this;
   }
 
   factory TypeParameterElementImpl.synthetic({required String name}) {
     var fragment = TypeParameterFragmentImpl.synthetic(name: name);
-    return TypeParameterElementImpl(firstFragment: fragment, name: name);
+    return TypeParameterElementImpl(firstFragment: fragment);
   }
 
   @override
@@ -10078,10 +10075,7 @@ class TypeParameterFragmentImpl extends FragmentImpl
     }
     // As a side-effect of creating the element, all of the fragments in the
     // chain will have their `_element` set to the newly created element.
-    return TypeParameterElementImpl(
-      firstFragment: firstFragment,
-      name: firstFragment.name,
-    );
+    return TypeParameterElementImpl(firstFragment: firstFragment);
   }
 
   set element(TypeParameterElementImpl element) {

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -1896,7 +1896,6 @@ class ResolutionReader {
       var typeParameterFragment = TypeParameterFragmentImpl(name: fragmentName);
       var typeParameterElement = TypeParameterElementImpl(
         firstFragment: typeParameterFragment,
-        name: typeParameterFragment.name,
       );
       _localElements.add(typeParameterElement);
       // TODO(scheglov): why not element?

pkg/analyzer/lib/src/test_utilities/test_library_builder.dart

@@ -226,7 +226,7 @@ class _LibraryBuilder {
 
     for (var name in spec.typeParameters) {
       var tpElement = _createTypeParameterElement(name);
-      scope.addTypeParameter(name, tpElement);
+      scope.addTypeParameter(tpElement);
       fragment.typeParameters.add(tpElement.firstFragment);
     }
 
@@ -260,7 +260,7 @@ class _LibraryBuilder {
     fragment.typeParameters =
         spec.typeParameters.map((name) {
           var tpElement = _createTypeParameterElement(name);
-          scope.addTypeParameter(name, tpElement);
+          scope.addTypeParameter(tpElement);
           return tpElement.firstFragment;
         }).toList();
 
@@ -279,7 +279,7 @@ class _LibraryBuilder {
 
   TypeParameterElementImpl _createTypeParameterElement(String name) {
     var fragment = TypeParameterFragmentImpl(name: name);
-    return TypeParameterElementImpl(firstFragment: fragment, name: name);
+    return TypeParameterElementImpl(firstFragment: fragment);
   }
 
   void _populateClasses(LibrarySpec libSpec) {
@@ -291,7 +291,7 @@ class _LibraryBuilder {
       fragment.typeParameters =
           classSpec.typeParameters.map((name) {
             var tpElement = _createTypeParameterElement(name);
-            scope.addTypeParameter(name, tpElement);
+            scope.addTypeParameter(tpElement);
             return tpElement.firstFragment;
           }).toList();
 
@@ -406,11 +406,8 @@ class _PreFunctionType implements _PreType {
     var typeParameters =
         this.typeParameters.map((pre) {
           var fragment = TypeParameterFragmentImpl(name: pre.name);
-          var element = TypeParameterElementImpl(
-            firstFragment: fragment,
-            name: pre.name,
-          );
-          functionScope.addTypeParameter(pre.name, element);
+          var element = TypeParameterElementImpl(firstFragment: fragment);
+          functionScope.addTypeParameter(element);
           return element;
         }).toList();
 
@@ -510,8 +507,8 @@ class _Scope {
   _Scope.root(this._interfaces) : parent = null;
 
   /// Adds a type parameter to the current scope.
-  void addTypeParameter(String name, TypeParameterElementImpl element) {
-    _typeParameters[name] = element;
+  void addTypeParameter(TypeParameterElementImpl element) {
+    _typeParameters[element.name!] = element;
   }
 
   /// Looks up an interface by name.

pkg/analyzer/lib/src/utilities/extensions/element.dart

@@ -414,7 +414,7 @@ extension TypeParameterElement2Extension on TypeParameterElement {
   TypeParameterElementImpl freshCopy() {
     var fragment = TypeParameterFragmentImpl(name: name);
     fragment.bound = bound;
-    return TypeParameterElementImpl(firstFragment: fragment, name: name);
+    return TypeParameterElementImpl(firstFragment: fragment);
   }
 }
 

pkg/analyzer/test/generated/elements_types_mixin.dart

@@ -666,7 +666,7 @@ mixin ElementsTypesMixin {
     var fragment = TypeParameterFragmentImpl(name: name);
     fragment.bound = bound;
 
-    var element = TypeParameterElementImpl(firstFragment: fragment, name: name);
+    var element = TypeParameterElementImpl(firstFragment: fragment);
     element.variance = variance;
     return element;
   }