Skip to content

Remove _incrementalModules in DDC compiler and its use in TypeTable #56961

@srujzs

Description

@srujzs

Historically, we kept around a TypeTable to keep track of types that were used in an expression but never actually imported. This was needed for expression evaluation as it allowed us to import the class. Now that we use the RTI, we no longer need this functionality.

_incrementalModules was used to keep track of these dependencies, but may no longer be needed.

There are guards that check for it e.g.

if (!_incrementalMode || _incrementalModules.containsKey(module)) {
that can likely just be safely removed. There may be other refactoring opportunities once this is removed e.g. only calling _emitImports if in incremental mode: .

cc @nshahan

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.web-dev-compiler

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions