-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.web-dev-compiler
Description
Currently, our custom formatter in DDC formats libraries only within the context of a module. Specifically, given a module, we recognize it as a special object using getModuleName:
| name: name, value: Library(name, value!), hideName: true)); |
Library object to format each library within that module: | if (dart.isJsInterop(object) && dart.getModuleName(object) == null) { |
With the new module format, this becomes even more important as we no longer have modules, only libraries. Once we add this capability to detect libraries, _useNativeJSFormatter should be updated. Similarly, debugger_test.dart should be updated to directly pass libraries instead of wrapping them in Librarys. See https://dart-review.googlesource.com/c/sdk/+/389589.
Metadata
Metadata
Assignees
Labels
area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.web-dev-compiler