-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.devexp-serverIssues related to some aspect of the analysis serverIssues related to some aspect of the analysis serverfeature-null-aware-elementsImplementation of the Null-aware elements featureImplementation of the Null-aware elements featuretype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Description
This issue tracks all the analysis server work items for the wildcard variables feature. Referenced from: https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/doc/process/new_language_feature.md
- Call Hierarchy
- Tests needed.
- No crashes.
- Verify that the invocations inside of the null-aware collection elements are handled.
- Done: https://dart-review.googlesource.com/c/sdk/+/393321
- Updated test cases in files:
pkg/analysis_server/test/lsp/call_hierarchy_test.dartpkg/analysis_server/test/src/computer/call_hierarchy_computer_test.dart
- Tests needed.
- Closing Labels
- Test needed.
- No crashes.
- Done: https://dart-review.googlesource.com/c/sdk/+/396600
- Updated test cases in files:
pkg/analysis_server/test/src/computer/closing_labels_computer_test.dart
- Test needed.
- Code Completion
- Tests needed.
- Add different use cases for the different locations of the null-aware elements.
- Implementation needed
- We almost certainly will need to add an implementation for the new node.
- Done: https://dart-review.googlesource.com/c/sdk/+/392902
- Updated implementation in files:
pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
- Updated test cases in files:
pkg/analysis_server/test/services/completion/dart/location/null_aware_element_test.dartpkg/analysis_server/test/services/completion/dart/location/test_all.dart(to includenull_aware_element_test.dart)
- Tests needed.
- Code Folding
- Tests needed.
- No crashes.
- Check that closures inside the expressions, inside of the null-aware elements, are properly folded. It has to be multiline.
- Done: https://dart-review.googlesource.com/c/sdk/+/396860
- Updated test cases in files:
pkg/analysis_server/test/src/computer/folding_computer_test.dart
- Tests needed.
- Document Symbols
- Needs clarification.
- Document Colors
- Tests needed.
- Test color swatches and see if the result indicates the correct colour. Pick an existing test and wrap it into a null-aware element.
- Done: https://dart-review.googlesource.com/c/sdk/+/397902, https://dart-review.googlesource.com/c/sdk/+/397904.
- Updated test cases in files:
pkg/analysis_server/test/src/computer/color_computer_test.dart
- Tests needed.
- Hovers
- Tests needed.
- Write a test that ensures that an identifier inside of a null-aware element has a hover for it.
- Done: https://dart-review.googlesource.com/c/sdk/+/398061
- Updated test cases in files:
pkg/analysis_server/test/analysis/get_hover_test.dart
- Tests needed.
-
Implemented/Override Markers- Not affected.
- Inlay Hints
- Tests needed.
- Write a test that shows that the inlay hints are shown inside of a closure inside of a null-aware element.
- Done: https://dart-review.googlesource.com/c/sdk/+/398860
- Updated test cases in files:
pkg/analysis_server/test/lsp/inlay_hint_test.dart
- Write a test that shows that the inlay hints are shown inside of a closure inside of a null-aware element.
- Tests needed.
- Navigation - legacy
- Tests needed.
- Done: https://dart-review.googlesource.com/c/sdk/+/398880, https://dart-review.googlesource.com/c/sdk/+/398882
- Updated test cases in files:
pkg/analysis_server/test/analysis/get_navigation_test.dartpkg/analysis_server/test/analysis/notification_navigation_test.dart
- Tests needed.
- Navigation - LSP Go to Definition
- Test needed.
- No crashes.
- Add an identifier inside of a null-aware element and check that the navigation works.
- Done: https://dart-review.googlesource.com/c/sdk/+/399080
- Updated test cases in files:
pkg/analysis_server/test/lsp/definition_test.dartpkg/analysis_server/test/lsp/super_test.dart
- Test needed.
- Navigation - LSP Go to Type Definition
- Test needed
- No crashes.
- Done: https://dart-review.googlesource.com/c/sdk/+/399080
- Updated test cases in files:
pkg/analysis_server/test/lsp/definition_test.dartpkg/analysis_server/test/lsp/super_test.dart
- Test needed
- Navigation - Go to Super
- Test needed
- No crashes.
- Done: https://dart-review.googlesource.com/c/sdk/+/399080
- Updated test cases in files:
pkg/analysis_server/test/lsp/definition_test.dartpkg/analysis_server/test/lsp/super_test.dart
- Test needed
- Occurrences - legacy
- Tests needed.
- No crashes.
- Make sure that something inside of the null-aware element is highlighted when needed. Test both ways: when the clicked word is outside, and when it’s inside.
- Done: https://dart-review.googlesource.com/c/sdk/+/411243
- Updated test cases in files:
pkg/analysis_server/test/integration/analysis/occurrences_test.dart
- Tests needed.
- Occurrences - LSP Document Highlights
- Tests needed.
- No crashes.
- Make sure that something inside of the null-aware element is highlighted when needed. Test both ways: when the clicked word is outside, and when it’s inside.
- Tests needed.
-
Organize Imports- Not affected.
-
Outline- Not affected.
- Flutter Outline
- Tests needed.
- No crashes.
- Test for the case of a null-aware element in a collection in the widget tree.
- Done: https://dart-review.googlesource.com/c/sdk/+/411020
- Updated test cases in files:
pkg/analysis_server/test/src/flutter/flutter_outline_computer_test.dart
- Tests needed.
- Refactorings
- Refactorings - legacy
- Refactorings - rename refactoring
- Refactorings - self describing
- Quick Assists
- Quick Fixes
- Evaluate how likely it is for a refactoring to be affected, and write the corresponding tests,
- Add reasonable fixes for the existing diagnostics.
- Added tests:
- add_trailing_comma
- https://dart-review.googlesource.com/c/sdk/+/405380
pkg/analysis_server/test/src/services/correction/fix/add_trailing_comma_test.dart
- add_trailing_comma
- Search
- Search - Find References
- Search - Implementations - LSP
- Search - Member Declarations
- Search - Member References
- Search - Top-level Declarations
- Tests needed.
- Test searching for local variables.
- Selection Range
- Tests needed.
- Test that the boundaries of the null-aware elements can be crossed during expansion.
- Tests needed.
-
Syntax Highlighting-
Semantic Highlights -
LSP Semantic Tokens - Not affected.
-
-
Signature Help- Not affected.
-
Snippets- Not affected.
-
Sort Members- Not affected.
-
Type Hierarchy - legacy- Not affected.
-
Type Hierarchy - LSP- Not affected.
- Workspace Symbols
- Tests needed.
- Add tests for local variables.
- Tests needed.
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work onarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.devexp-serverIssues related to some aspect of the analysis serverIssues related to some aspect of the analysis serverfeature-null-aware-elementsImplementation of the Null-aware elements featureImplementation of the Null-aware elements featuretype-enhancementA request for a change that isn't a bugA request for a change that isn't a bug