Missing quick fix for `omit_obvious_property_types` in Dart Analysis view in IntelliJ

[denniskaselow]

This line triggers the omit_obvious_property_types lint:

final String foo = '';

When using right click in the Analysis View in IntelliJ, there is no quick fix shown:

Pressing Alt+Enter directly on the type annotation where the lint occurs shows a quick fix:

If it's declared as a local variable (omit_obvious_local_variable_types), the quick fix is shown in the Analysis View:

Additionally Alt+Enter has the yellow light bulb for quick fixes:

One obvious difference between both lints is that one hasFix, while the other needsEvaluation (if this matters):

sdk/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

Lines 2199 to 2202 in 5b6e686

	LintCode.omit_obvious_local_variable_types:
	status: hasFix
	LintCode.omit_obvious_property_types:
	status: needsEvaluation

Dart version: Dart SDK version: 3.7.0-81.0.dev (dev) (Tue Oct 29 17:06:42 2024 -0700) on "windows_x64"

[dart-github-bot]

Summary: The omit_obvious_property_types lint does not have a quick fix available in the IntelliJ Analysis View, even though the lint is triggered. The quick fix is available when using Alt+Enter directly on the type annotation or when the lint is applied to a local variable.

[eernstg]

Thanks! https://dart-review.googlesource.com/c/sdk/+/393280.

[bwilkerson]

The status in [error_fix_status.yaml](https://github.com/dart-lang/sdk/blob/5b6e6865b03f808d9e1e74e4638c997650294839/pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml#L2199-L2202) doesn't actually control anything. It's there only as away for us to track which diagnostics could have a fix that don't.

It is, however, required to match reality by having a test that compares it to the table used to produce fixes for diagnostics. It was the absence of a mapping in this table that prevented the fix from being displayed.

Thanks @eernstg for the CL to add the mapping to the table (and fix the status file to be consistent).

[denniskaselow]

fixed in c9391d7