Failures on Message scheduler test

[jyameo]

There are new test failures on [Message scheduler] Implement handling one message at a time..

The tests

pkg/analysis_server/test/integration/server/message_scheduler_test RuntimeError (expected Pass)
pkg/analysis_server/test/lsp/code_actions_refactor_test RuntimeError (expected Pass)

are failing on configurations

analyzer-unittest-asserts-release-win

LOGS: https://dart-ci.appspot.com/log/any/analyzer-unittest-asserts-release-win/29285/pkg/analysis_server/test/integration/server/message_scheduler_test

[dart-github-bot]

Summary: Message scheduler tests (message_scheduler_test and code_actions_refactor_test) fail on Windows release builds. The failures are runtime errors.

[keertip]

@DanTup, the ExtractMethodRefactorCodeActionsTest | test_contentModified fails due to timeout on the windows bot. I don't have a windows machine and am unable to reproduce it locally. Do you have a windows machine? If so, could you check and see if you can reproduce it? Thanks.

[DanTup]

Yep, I can reproduce it - will take a look.

[keertip]

Thanks! The LspServerMessageSchedulerTest | test_documentChange also fails due to timeout. Likely the same issue.

[DanTup]

The issue is using .path on file:/// URIs. On Mac/Linux, this works out the same (eg. file:///foo/bar -> /foo/bar) but on Windows it's incorrect (file:///c:/foo/bar -> /c:/foo/bar instead of c:\foo\bar). Calling .toFilePath() is better, but in this case I think we should compare URIs instead (and we should migrate refactors from paths to URIs).

Will ping you on a CL to fix shortly.

[DanTup]

@keertip I've opened https://dart-review.googlesource.com/c/sdk/+/397620 - you might need to find a second reviewer to land it though.