Skip to content

Failures on Remove unnecessary leftover @dart=2.19 from tests. #59625

@lrhn

Description

@lrhn

There are new test failures on Remove unnecessary leftover @dart=2.19 from tests..

The tests

language/const/map_hashcode_override_legacy_test RuntimeError (expected Pass)

are failing on configurations

dart2wasm-asserts-linux-chrome
dart2wasm-linux-chrome
dart2wasm-linux-d8
dart2wasm-linux-jscm-chrome

In 2.19-mode constant maps/sets should not read the hashCode of objects with trivial equality, they should just use identity hash code (except for the lucky few platform objects where it should use the actual hashCode, likely numbers, Symbol and Type objects, because there will be runtime created objects equal to them).

The Wasm code crashes badly if hashCode throws. (That's a silly thing to do, but we have tests.)
This was probably accepted already, and just popped up again because I copied/renamed a file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-dart2wasmIssues for the dart2wasm compiler.type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions