Quick fix for `@mustCallSuper` doesn't work with multiple parameters

[gaaclarke]

steps to reproduce

1. Get in a situation where you must call super on a method with multiple parameters
2. Select the first Quick Fix which should insert the call

observed result

The inserted fix was super.onCollision(other); with one argument.

expected result

super.onCollision(points, other); with two arguments.

screenshots

before

quick fix options

after

doctor

[!] Flutter (Channel [user-branch], 3.27.0-1.0.pre.644, on macOS 14.7.1 23H222 darwin-arm64, locale en)
    ! Flutter version 3.27.0-1.0.pre.644 on channel [user-branch] at /Users/aaclarke/dev/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision f3f72ede04 (3 weeks ago), 2024-11-25 16:14:30 -0800
    • Engine revision fe45a66086
    • Dart version 3.7.0 (build 3.7.0-183.0.dev)
    • DevTools version 2.41.0-dev.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform
      update checks and upgrades.

[dart-github-bot]

Summary: Dart's quick fix for @mustCallSuper methods incorrectly handles multiple parameters; it inserts a call with only the first argument. The fix should include all parameters.

[jakemac53]

I have a test for this out here, but it is passing, so I think this is fixed.

@gaaclarke can you confirm?

[gaaclarke]

@gaaclarke can you confirm?

Still doesn't work for me. If it helps my repo is using the Flame Engine: https://docs.flame-engine.org/latest/flame/collision_detection.html#collisioncallbacks

fix.mov

[!] Flutter (Channel [user-branch], 3.29.0-1.0.pre.284, on macOS 14.7.2 23H311 darwin-arm64, locale en) [4.2s]
    ! Flutter version 3.29.0-1.0.pre.284 on channel [user-branch] at /Users/aaclarke/dev/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision a6344bf2b3 (50 minutes ago), 2025-02-07 00:24:57 +0100
    • Engine revision a6344bf2b3
    • Dart version 3.8.0 (build 3.8.0-70.0.dev)
    • DevTools version 2.43.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[gaaclarke]

With the same version of dart I tried the following and it worked fine. There is something special about my flame engine repo.

class Foo {
  @mustCallSuper
  void foo(int x, int y) {}
}

class Bar extends Foo {
  @override
  void foo(int x, int y) {
    print("foo");
  }
}

[jakemac53]

Ah, I found the issue, if the parameter names do not match then the quick fix won't include them.