Skip to content

vm gcc bot is broken  #59811

@aam

Description

@aam

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8727606552721054881/+/u/build_dart_debug_ia32/stdout

[2471/2490] ASM x86_shared/obj/runtime/bin/ffi_test/libffi_test_functions.clobber_x86.o
[2472/2490] CXX obj/runtime/bin/dart_embedder_runtime_jit_set.dart_embedder_api_impl.o
FAILED: obj/runtime/bin/dart_embedder_runtime_jit_set.dart_embedder_api_impl.o 
i686-linux-gnu-g++ -MMD -MF obj/runtime/bin/dart_embedder_runtime_jit_set.dart_embedder_api_impl.o.d -D_FORTIFY_SOURCE=2 -DDEBUG -I../../runtime -I../../third_party/boringssl/src/include -I../../third_party -I../.. -Igen -I../../runtime/include -m32 -msse2 -mfpmath=sse -fPIE -Wall -Wextra -Werror -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-ignored-qualifiers -fdebug-prefix-map=/b/s/w/ir/cache/builder/sdk/= -no-canonical-prefixes -fvisibility=hidden -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -fdata-sections -ffunction-sections -g3 -ggdb3 -fvisibility-inlines-hidden -fno-omit-frame-pointer -std=c++20 -std=c++20 -fno-rtti -c ../../runtime/bin/dart_embedder_api_impl.cc -o obj/runtime/bin/dart_embedder_runtime_jit_set.dart_embedder_api_impl.o
In file included from ../../runtime/bin/socket.h:12,
                 from ../../runtime/bin/security_context.h:13,
                 from ../../runtime/bin/secure_socket_filter.h:16,
                 from ../../runtime/bin/dart_embedder_api_impl.cc:11:
../../runtime/bin/socket_base.h:97:9: error: multi-line comment [-Werror=comment]
   97 | #endif  // defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_MACOS) ||       \
      |         ^
cc1plus: all warnings being treated as errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.gardening

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions