Analysis appears to never complete (and delays other LSP requests) when using macros/augmentations

[ljmatan]

Using Visual Studio Code, augmentations are not available, and the files are not being saved.

Checking the analyzer, it looks like it's being stuck at the "textDocument/documentColor" request.

Attached are log files from the "Analysis Server Diagnostics" service.

dart_analyzer_diagnostics_report-2.json

[ljmatan]

It seems that disabling "Format on save" option fixes the "hang" issue, however, augmentations are still not visible.

[ljmatan]

Perhaps a new problem occurred when disabling the option. The VS Code is stuck "Analyzing...", a new request seems to result in a hang:

dart_analyzer_diagnostics_report-3.json

[pq]

@DanTup

[bwilkerson]

Thanks for the report.

The augmentations experiment is not fully implemented, so problems like this are expected. We can leave the issue open to remind us to verify that it's working as expected when we're farther along, but we likely can't fix the analysis server support until the analyzer's implementation is more complete.

[lrhn]

Does sound like the same behavior I consistently see when having the SDK repository open, and also saw before augmentations were a thing.
I use "Save without formatting" to avoid triggering the analyzer, because it'll just stall the save (and, worst case, succeed half a minute later and replace what I have written since then with what I tried to save, with no undo).

[DanTup]

@ljmatan @lrhn do either of you have some specific steps to reproduce what you see?

I have seen Format-on-Save be a little slow in the SDK sometimes (and also cancelled and used Save without Formatting). The times I've looked this seemed to be that the change made immediately before saving triggered a lot of analysis (eg. modifying a library that's imported by a lot of other libraries), that meant the server was busy for a while.

If you see this often and have some steps to trigger it, it would be worth profiling and seeing exactly what's happening.

and, worst case, succeed half a minute later and replace what I have written since then with what I tried to save, with no undo

I don't know if I understand correctly, but this sounds concerning. If you trigger an action like a format and then you modify the document, VS Code should cancel the format request and disregard any response that shows up. If it is corrupting code or leaving you without an undo, we should definitely open an issue with as much detail as you have - it sounds like something is going badly wrong there.
(I'll also note that there is a difference with how Format on save works compared to other actions like Organize Imports, so knowing if you also have any of those enabled on-save may help narrow that down too)

[ljmatan]

Hi all,

first to say, thank you for the prompt responses, and as a user, I'm very happy with the progress on the Dart SDK.

I'm experiencing issues with a personal project, I've updated the source code which you may find here.

I've opened the project a few moments ago, in the api/lib/src/models/src/model_address.dart file I've received an error stating the GsarModel class can't be extended outside of it's package as it's an interface class.

Moving into the plugins/arch/lib/src/model.dart file and removing the interface declaration from the GsarModel class, the file once again couldn't be saved.

Augmentations are also not working, once more. You may find macro implementations in the api/lib/src/models/src/ directory.

If you see this often and have some steps to trigger it, it would be worth profiling and seeing exactly what's happening.

I would be happy to help you with that if you could point me to some specific steps into "profiling", as I'm not completely sure what you're referring to.

[DanTup]

@ljmatan thanks for the sample. I can reproduce issues with that project, but they start as soon as I open the project - it appears that initial analysis never completes (I see "Analyzing..." in the status bar infinitely). I think this is related to macros or augmentations because if I remove the macro, this problem goes away.

I'll update the title to better reflect that, though as Brian noted these features are still incomplete and experimental, so issues are somewhat expected at this point.

@lhrn I suspect your issues are not related to macros or augmentations, so if you can figure out some steps to trigger it, it may be worth filing an additional issue (and perhaps a separate one about the code corruption, since that sounds like a more serious logic error and not only related to bad performance).