Code completion shows operators like == in places they are not valid to call

[DanTup]

Invoking completion at ^:

class A {

}

void f() {
  A().^
}

Includes the ==() method (and presumably, other operators):

However it's not valid to call them in this way ("Expected an identifier").

[FMorschel]

Similar to #59854, lots of invalid things here:

I'll place basically the same comment over on that issue with a bit more info.

---

Edit: Also, adding hashCode and whatever it showed there would make the assignment invalid so we sould only get the valid field names.

[FMorschel]

Small update: this error seems to be LSP-specific which is a bit weird:

With the same SDK I can reproduce on VS Code.

---

Edit: See that you were right:

and presumably, other operators

class A {
  int operator+(int other) => 0;
  int operator[](int index) => 0;
  double operator/(int other) => 0.0;
  int operator-() => 0;
  int operator-(int other) => 0;
}

void f() {
  A().;
}

Even the unary operator here:

[FMorschel]

Here is the CL https://dart-review.googlesource.com/c/sdk/+/417400

[DanTup]

Small update: this error seems to be LSP-specific which is a bit weird:

Out of interest, did you determine why this was? Looking at the CL, it doesn't seem like the changes are in LSP-specific code. Where those options being suggested but filtered out somewhere for the legacy protocol, or not suggested at all?

[FMorschel]

I started by creating a test on the Legacy tests and could not reproduce this. I did see that the == method was being suggested and would build the SuggestionItems. Maybe I was filtering the output the wrong way but since I could not see it on IntelliJ, I figured it was LSP specific.

I didn't see if this was being filtered somewhere else (other than the "name"-based filter that maybe I configured the wrong way) since the mere suggestion was wrong, hence the changes were on the base candidate suggestions. I could take a look at this again if you're interested.

[DanTup]

I can take a look, I just wanted to check you hadn't already figured it out :) There's probably an obvious explanation, but nothing comes to mind so I am curious (for ex. if there is additional filtering in the legacy layer somewhere, are there other things beyond these operators that it filters out and LSP is not, that could be yet-to-be-discovered bugs?).

[DanTup]

The reason these don't show up for legacy is because of this code path:

It ultimately ends up in _getCompletionString which has an exclusion for operators and the calling function (_createCompletionSuggestionBuilder) then also returns null and no completion is built.

I suspect this is a result of the slightly different paths legacy/LSP take (as discussed in another issue recently) and perhaps this condition is redundant now. As far as I can tell it's only operators that are excluded in this way (which will be covered by the fix above).

[FMorschel]

I'm aware you have a lot on your plate right now @bwilkerson. This is just an informer that I've added you as a reviewer for this CL, no rush (link copied here so it is easier to find https://dart-review.googlesource.com/c/sdk/+/417400).