pkg/vm_service/test/http_invocations/http_get_isolate_rpc_test failing on vm-aot-linux-debug-x64

[sstrickl]

There are new test failures on [migration] refactoring_manager.dart and handler_rename.dart...Elements. Remove FindElement fields where possible..

The test

pkg/vm_service/test/http_invocations/http_get_isolate_rpc_test RuntimeError (expected Pass)

is failing on configurations

vm-aot-linux-debug-x64

Relevant log portion:

stdout:
00:00 �[32m+0�[0m: out.aotsnapshot�[0m

** Launching SERVICE_TEST_TESTEE=true out/DebugX64/dartaotruntime --disable-service-auth-codes --profiler --sound-null-safety -Dtest_runner.configuration=vm-aot-linux-debug-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json --enable-vm-service:0 /b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-linux-debug-x64/pkg_vm_service_test_http_invocations_http_get_isolate_rpc_test/out.aotsnapshot

>testee>out> Waiting for the VM service URI to become available...
>testee>out> VM service URI has become available: http://127.0.0.1:44139/
>testee>out> The Dart VM service is listening on http://127.0.0.1:43385/
>testee>err> Unhandled exception:
>testee>err> invalid request: type 'Null' is not a subtype of type 'FutureOr<Map<String, dynamic>>'
>testee>err> #0      Expect.fail (file:///b/s/w/ir/pkg/vm_service/test/common/expect.dart:156)
>testee>err> #1      testeeBefore (file:///b/s/w/ir/pkg/vm_service/test/http_invocations/http_get_isolate_rpc_common.dart:54)
>testee>err> <asynchronous suspension>
>testee>err> #2      _ServiceTesteeRunner.run (file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:60)
>testee>err> <asynchronous suspension>
>testee>err> #3      runIsolateTests (file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:482)
>testee>err> <asynchronous suspension>
>testee>err> vm-service: Error: Unhandled exception:
>testee>err> Null check operator used on a null value
>testee>err> #0      NamedLookup.keyOf (dart:_vmservice/named_lookup.dart:29)
>testee>err> #1      VMService._removeClient (dart:_vmservice:295)
>testee>err> #2      Client.close (dart:_vmservice/client.dart:53)
>testee>err> #3      HttpRequestClient.disconnect (dart:vmservice_io/vmservice_server.dart:105)
>testee>err> <asynchronous suspension>
>testee>err> 
>testee>err> Unhandled exception:
>testee>err> Null check operator used on a null value
>testee>err> #0      NamedLookup.keyOf (dart:_vmservice/named_lookup.dart:29)
>testee>err> #1      VMService._removeClient (dart:_vmservice:295)
>testee>err> #2      Client.close (dart:_vmservice/client.dart:53)
>testee>err> #3      HttpRequestClient.disconnect (dart:vmservice_io/vmservice_server.dart:105)
>testee>err> <asynchronous suspension>

stderr:
Unhandled exception:
Testee exited with unexpected exitCode: 255
#0      _ServiceTesterRunner.run (file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:417)
<asynchronous suspension>
#1      runIsolateTests (file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:489)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-aot-linux-debug-x64 pkg/vm_service/test/http_invocations/http_get_isolate_rpc_test

/cc @bkonyi

[bkonyi]

Looks like we're crashing only on the HTTP service request code path. Luckily it's not commonly used, but we should guard against this failure.

[derekxu16]

The test went back to passing on all configs before b08d837 landed, but I think that change should fix the flakiness for good. This can be reopened if the test becomes flaky again.