type_annotate_public_apis ignores constructors

[munificent]

With an analysis_options.yaml file like:

linter:
  rules:
    - type_annotate_public_apis

When I analyze:

class A {
  A(foo) {}
  void method(blah) {}
}

I correctly get a lint error on blah, but not on foo.

Looking at the lint implementation, I see it visiting functions, methods, variables, and even function types, but it looks like it just doesn't implement visitConstructorDeclaration().

[bwilkerson]

That certainly seems inconsistent, and there's no justification for it in the documentation that I could see. It does seem like a case that the lint should report.

Unfortunately, fixing this issue would be a breaking change, so we'll need to consider whether the value to the community outweighs the cost of the breakage. The alternative would be to add a new lint to catch this missed case, but that carries a different cost in terms of discoverability.