Occurrences not working correctly for annotations

[FMorschel]

Repro:

@C<int>(C<int>())
class C<T> {
  const C([Object? o]);
}

Here, the type argument inside the argument list doesn't get highlighted:

Here, it seems like the annotation considers the first C a Type and not a constructor.

CC @bwilkerson @DanTup

[FMorschel]

[I]t seems like the annotation considers the first C a Type and not a constructor.

Even Go to Definition does this, so probably the element there is the wrong one?

[FMorschel]

I've basically finished fixing the above. I just have some wrapping up to do. I do have another question, though:

@C()
class C<T> {
  const C();
}

@D(C())
class D {
  const D(Object o);
}

The problem with the above is the range for inference_failure_on_instance_creation. It spans the entire annotation and not just the constructor name (like the one inside D). I've not looked into that one yet, but I'd say it should be fixed.

WDYT @bwilkerson

[FMorschel]

Here is the CL for this issue https://dart-review.googlesource.com/c/sdk/+/468700

[bwilkerson]

I agree. Highlighting only the constructor name would be better.