add some lints

Author: kevmoo

.analysis_options

@@ -1,2 +1,29 @@
 analyzer:
  strong-mode: true
+linter:
+  rules:
+     # Errors
+     - avoid_empty_else
+     - comment_references
+     - control_flow_in_finally
+     - empty_statements
+     #- hash_and_equals
+     - test_types_in_equals
+     - throw_in_finally
+     - unrelated_type_equality_checks
+     - valid_regexps
+
+     # Style
+     #- annotate_overrides
+     - avoid_init_to_null
+     - avoid_return_types_on_setters
+     - await_only_futures
+     - camel_case_types
+     - empty_catches
+     - empty_constructor_bodies
+     - library_names
+     - library_prefixes
+     - non_constant_identifier_names
+     - prefer_is_not_empty
+     - slash_for_doc_comments
+     - type_init_formals

test/annotation_test.dart

@@ -236,7 +236,7 @@ ClassElement _getAnnotatedClass(LibraryElement lib, String className) =>
         .expand((cu) => cu.types)
         .singleWhere((cd) => cd.name == className);
 
-/// Returns a mock [ElementAnnotationImpl] whose
+/// Returns a mock [MockElementAnnotation] whose
 /// `evaluationResult.value.type.element.library.source` is `libraryUri` and
 /// whose `evaluationResult.value.type.name` is `typeName`.
 ElementAnnotation _mockElementAnnotation(String typeName, Uri libraryUri) {

test/builder_test.dart

@@ -102,7 +102,7 @@ Future _simpleTest() => _generateTest(
     _testGenPartContent);
 
 Future _generateTest(CommentGenerator gen, String expectedContent) async {
-  var srcs = await _createPackageStub(pkgName);
+  var srcs = _createPackageStub(pkgName);
   var phaseGroup = new PhaseGroup.singleAction(new GeneratorBuilder([gen]),
       new InputSet(pkgName, ['lib/test_lib.dart']));
 

test/src/test_phases.dart

@@ -43,7 +43,7 @@ void checkOutputs(Map<String, dynamic> outputs, BuildResult result) {
     var id = new AssetId.parse(serializedId);
     remainingOutputIds.remove(id);
 
-    /// Check that the assets exist in [result.outputs].
+    // Check that the assets exist in [result.outputs].
     var actual = result.outputs
         .firstWhere((output) => output.id == id, orElse: () => null);
     expect(actual, isNotNull,