Removed timestamps from generated files

Author: kevmoo

CHANGELOG.md

@@ -12,6 +12,8 @@
   files via the `BuildStep` class, and that is now also provided to
   `Generator#generate` and `GeneratorForAnnotation#generateForAnnotatedElement`
   as a second argument.
+  
+* Timestamps are no longer included in generated code.
 
 * There is no longer a need to specify the files related to an individual
   generator via `AssociatedFileSet`. Simply use the `BuildStep` instance to read
@@ -26,7 +28,8 @@
 
 ## 0.4.7+2
 
-* Upgrade to `analyzer '^0.27.1'` and removed a work-around for a fixed `analyzer` issue.
+* Upgrade to `analyzer '^0.27.1'` and removed a work-around for a fixed 
+  `analyzer` issue.
 
 ## 0.4.7+1
 
@@ -54,7 +57,8 @@
 
 ## 0.4.4+1
 
-* Updated `README.md` to highlight the `build_system` package and deemphasize Dart Ediotr.
+* Updated `README.md` to highlight the `build_system` package and de-emphasize
+  Dart Editor.
 
 ## 0.4.4
 

example/example.g.dart

@@ -13,11 +13,9 @@ import 'utils.dart';
 
 class GeneratorBuilder extends Builder {
   final List<Generator> generators;
-  final bool omitGenerateTimestamp;
   final String generatedExtension;
 
-  GeneratorBuilder(this.generators,
-      {this.omitGenerateTimestamp: false, this.generatedExtension: '.g.dart'}) {
+  GeneratorBuilder(this.generators, {this.generatedExtension: '.g.dart'}) {
     // TODO: validate that generatedExtension starts with a `.'
     //       not null, empty, etc
   }
@@ -27,7 +25,7 @@ class GeneratorBuilder extends Builder {
     var id = buildStep.input.id;
     var resolver = await buildStep.resolve(id, resolveAllConstants: false);
     var lib = resolver.getLibrary(id);
-    await _generateForLibrary(lib, !omitGenerateTimestamp, buildStep);
+    await _generateForLibrary(lib, buildStep);
     resolver.release();
   }
 
@@ -40,8 +38,8 @@ class GeneratorBuilder extends Builder {
   AssetId _generatedFile(AssetId input) =>
       input.changeExtension(generatedExtension);
 
-  Future _generateForLibrary(LibraryElement library, bool includeTimestamp,
-      BuildStep buildStep) async {
+  Future _generateForLibrary(
+      LibraryElement library, BuildStep buildStep) async {
     buildStep.logger.fine('Running $generators for ${buildStep.input.id}');
     var generatedOutputs =
         await _generate(library, generators, buildStep).toList();
@@ -82,22 +80,9 @@ if approppriate.""",
     }
 
     var outputId = _generatedFile(buildStep.input.id);
-    var output =
-        new Asset(outputId, '${_getHeader(includeTimestamp)}$genPartContent');
+    var output = new Asset(outputId, '$_topHeader$genPartContent');
     buildStep.writeAsString(output);
   }
-
-  String _getHeader(bool includeTimestamp) {
-    var buffer = new StringBuffer('// GENERATED CODE - DO NOT MODIFY BY HAND');
-    buffer.writeln();
-
-    if (includeTimestamp) {
-      buffer.writeln("// ${new DateTime.now().toUtc().toIso8601String()}");
-    }
-
-    buffer.writeln();
-    return buffer.toString();
-  }
 }
 
 Stream<GeneratedOutput> _generate(LibraryElement unit,
@@ -125,4 +110,8 @@ Stream<GeneratedOutput> _processUnitMember(
   }
 }
 
+const _topHeader = '''// GENERATED CODE - DO NOT MODIFY BY HAND
+
+''';
+
 final _headerLine = '// '.padRight(77, '*');

lib/src/builder.dart

@@ -20,8 +20,7 @@ void main() {
   test('Bad generated source', () async {
     var srcs = _createPackageStub(pkgName);
     var phaseGroup = new PhaseGroup.singleAction(
-        new GeneratorBuilder([const _BadOutputGenerator()],
-            omitGenerateTimestamp: true),
+        new GeneratorBuilder([const _BadOutputGenerator()]),
         new InputSet(pkgName, ['lib/test_lib.dart']));
 
     await testPhases(phaseGroup, pkgName, srcs,
@@ -53,8 +52,7 @@ void main() {
     var srcs =
         _createPackageStub(pkgName, testLibContent: _testLibContentWithError);
     var phaseGroup = new PhaseGroup.singleAction(
-        new GeneratorBuilder([const CommentGenerator()],
-            omitGenerateTimestamp: true),
+        new GeneratorBuilder([const CommentGenerator()]),
         new InputSet(pkgName, ['lib/test_lib.dart']));
     await testPhases(phaseGroup, pkgName, srcs,
         {'$pkgName|lib/test_lib.g.dart': _testGenPartContentError,});
@@ -67,8 +65,7 @@ Future _simpleTest() => _generateTest(
 
 Future _generateTest(CommentGenerator gen, String expectedContent) async {
   var srcs = await _createPackageStub(pkgName);
-  var phaseGroup = new PhaseGroup.singleAction(
-      new GeneratorBuilder([gen], omitGenerateTimestamp: true),
+  var phaseGroup = new PhaseGroup.singleAction(new GeneratorBuilder([gen]),
       new InputSet(pkgName, ['lib/test_lib.dart']));
 
   await testPhases(phaseGroup, pkgName, srcs,