lints

Author: scheglov

example_usage/test/ensure_build_test.dart

@@ -13,6 +13,6 @@ import 'package:test/test.dart';
 void main() {
   test(
     'ensure_build',
-    () => expectBuildClean(packageRelativeDirectory: 'example_usage'),
+    () async => expectBuildClean(packageRelativeDirectory: 'example_usage'),
   );
 }

source_gen/lib/src/library.dart

@@ -141,11 +141,21 @@ class LibraryReader {
   ///
   /// Unlike [LibraryElement.getClass], this also correctly traverses
   /// identifiers that are accessible via one or more `export` directives.
+  @Deprecated('Use findType2() instead')
   ClassElement? findType(String name) {
     final type = element.exportNamespace.get(name);
     return type is ClassElement ? type : null;
   }
 
+  /// Returns a top-level [ClassElement] publicly visible in by [name].
+  ///
+  /// Unlike [LibraryElement.getClass], this also correctly traverses
+  /// identifiers that are accessible via one or more `export` directives.
+  ClassElement2? findType2(String name) {
+    final type = element.exportNamespace.get2(name);
+    return type is ClassElement2 ? type : null;
+  }
+
   /// Returns a [Uri] from the current library to the target [asset].
   ///
   /// This is a typed convenience function for using [pathToUrl], and the same

source_gen/lib/src/output_helpers.dart

@@ -11,6 +11,7 @@ Stream<String> normalizeGeneratorOutput(Object? value) {
   if (value == null) {
     return const Stream.empty();
   } else if (value is Future) {
+    // ignore:discarded_futures
     return StreamCompleter.fromFuture(value.then(normalizeGeneratorOutput));
   } else if (value is String) {
     value = [value];

source_gen/test/builder_test.dart

@@ -174,15 +174,15 @@ $dartFormatWidth
 
   test(
     'Simple Generator test for library',
-    () => _generateTest(
+    () async => _generateTest(
       const CommentGenerator(forClasses: false, forLibrary: true),
       _testGenPartContentForLibrary,
     ),
   );
 
   test(
     'Simple Generator test for classes and library',
-    () => _generateTest(
+    () async => _generateTest(
       const CommentGenerator(forLibrary: true),
       _testGenPartContentForClassesAndLibrary,
     ),

source_gen/test/external_only_type_checker_test.dart

@@ -37,7 +37,7 @@ void main() {
       inputId: AssetId('source_gen', 'test/example.dart'),
     );
 
-    staticNonPublic = thisTest.findType('NonPublic')!.instantiate(
+    staticNonPublic = thisTest.findType2('NonPublic')!.instantiate(
       typeArguments: const [],
       nullabilitySuffix: NullabilitySuffix.none,
     );

source_gen/test/library/find_type_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:build_test/build_test.dart';
 import 'package:source_gen/source_gen.dart';
 import 'package:test/test.dart';
@@ -47,24 +47,24 @@ void main() {
   });
 
   test('should return a type not exported', () {
-    expect(library.findType('Example'), _isClassElement);
+    expect(library.findType2('Example'), _isClassElement);
   });
 
   test('should return a type from a part', () {
-    expect(library.findType('PartClass'), _isClassElement);
+    expect(library.findType2('PartClass'), _isClassElement);
   });
 
   test('should return a type exported from dart:', () {
-    expect(library.findType('LinkedHashMap'), _isClassElement);
+    expect(library.findType2('LinkedHashMap'), _isClassElement);
   });
 
   test('should return a type exported from package:', () {
-    expect(library.findType('Generator'), _isClassElement);
+    expect(library.findType2('Generator'), _isClassElement);
   });
 
   test('should not return a type imported', () {
-    expect(library.findType('Stream'), isNull);
+    expect(library.findType2('Stream'), isNull);
   });
 }
 
-const _isClassElement = TypeMatcher<ClassElement>();
+const _isClassElement = TypeMatcher<ClassElement2>();

source_gen/test/type_checker_test.dart

@@ -11,6 +11,7 @@ library;
 import 'dart:collection';
 
 import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:build/build.dart';
@@ -91,28 +92,28 @@ void main() {
     );
     staticEnumChecker = TypeChecker.fromStatic(staticEnum);
     staticEnumMixin =
-        (testSource.exportNamespace.get('MyEnumMixin')! as InterfaceElement)
+        (testSource.exportNamespace.get2('MyEnumMixin')! as InterfaceElement2)
             .instantiate(
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
     staticEnumMixinChecker = TypeChecker.fromStatic(staticEnumMixin);
     staticMapMixin =
-        (testSource.exportNamespace.get('MyMapMixin')! as InterfaceElement)
+        (testSource.exportNamespace.get2('MyMapMixin')! as InterfaceElement2)
             .instantiate(
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
     staticMapMixinChecker = TypeChecker.fromStatic(staticMapMixin);
     staticMyEnum =
-        (testSource.exportNamespace.get('MyEnum')! as InterfaceElement)
+        (testSource.exportNamespace.get2('MyEnum')! as InterfaceElement2)
             .instantiate(
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
-    staticMyEnumWithMixin =
-        (testSource.exportNamespace.get('MyEnumWithMixin')! as InterfaceElement)
-            .instantiate(
+    staticMyEnumWithMixin = (testSource.exportNamespace.get2('MyEnumWithMixin')!
+            as InterfaceElement2)
+        .instantiate(
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
@@ -131,13 +132,13 @@ void main() {
       nullabilitySuffix: NullabilitySuffix.none,
     );
 
-    staticGenerator = sourceGen.findType('Generator')!.instantiate(
+    staticGenerator = sourceGen.findType2('Generator')!.instantiate(
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
     staticGeneratorChecker = TypeChecker.fromStatic(staticGenerator);
     staticGeneratorForAnnotation =
-        sourceGen.findType('GeneratorForAnnotation')!.instantiate(
+        sourceGen.findType2('GeneratorForAnnotation')!.instantiate(
       typeArguments: [core.typeProvider.dynamicType],
       nullabilitySuffix: NullabilitySuffix.none,
     );